Skip to content

Commit acbadec

Browse files
committed
Clean up outdated HMAC input constant names from comments
The reserved values [5; 16], [7; 16], and [8; 16] are already flagged as unsafe to reuse. Listing their old names from pre-LDK v0.3 days doesn't add value anymore and risks misleading anyone into thinking they’re still meaningful.
1 parent bbc8220 commit acbadec

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

lightning/src/offers/signer.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,11 +42,6 @@ const WITH_ENCRYPTED_PAYMENT_ID_HMAC_INPUT: &[u8; 16] = &[4; 16];
4242
// authentication.
4343
// Their corresponding values (`[5; 16]`, `[7; 16]` and `[8; 16]`) are now reserved and must not
4444
// be reused to ensure type confusion attacks are impossible.
45-
//
46-
// Reserved HMAC_INPUT values — do not reuse:
47-
//
48-
// const OFFER_PAYMENT_ID_HMAC_INPUT: &[u8; 16] = &[5; 16];
49-
// const PAYMENT_HASH_HMAC_INPUT: &[u8; 16] = &[7; 16];
5045

5146
/// Message metadata which possibly is derived from [`MetadataMaterial`] such that it can be
5247
/// verified.

0 commit comments

Comments
 (0)