Fixed wrongly returning error for valid descriptions

svera · svera · commit 0c29f5b65a14 · 2021-09-14T09:32:23.000+02:00
diff --git a/Magento2/Sniffs/Commenting/ClassPropertyPHPDocFormattingSniff.php b/Magento2/Sniffs/Commenting/ClassPropertyPHPDocFormattingSniff.php
@@ -140,11 +140,10 @@ public function processMemberVar(File $phpcsFile, $stackPtr)
                 /x';
         $varTagParts = preg_split($regularExpression, $tokens[$string]['content']);
 
-        if (stripos($tokens[$isShortDescriptionPreviousVar]['content'], implode('', $varTagParts)) === false) {
-            return;
+        if (stripos($tokens[$isShortDescriptionPreviousVar]['content'], implode('', $varTagParts)) !== false) {
+            $error = 'Short description duplicates class property name.';
+            $phpcsFile->addWarning($error, $isShortDescriptionPreviousVar, 'AlreadyHaveMeaningfulNameVar');
         }
-        $error = 'Short description duplicates class property name.';
-        $phpcsFile->addWarning($error, $isShortDescriptionPreviousVar, 'AlreadyHaveMeaningfulNameVar');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -140,11 +140,10 @@ public function processMemberVar(File $phpcsFile, $stackPtr)`
`140`	`140`	`/x';`
`141`	`141`	`$varTagParts = preg_split($regularExpression, $tokens[$string]['content']);`
`142`	`142`
`143`		`- if (stripos($tokens[$isShortDescriptionPreviousVar]['content'], implode('', $varTagParts)) === false) {`
`144`		`- return;`
	`143`	`+ if (stripos($tokens[$isShortDescriptionPreviousVar]['content'], implode('', $varTagParts)) !== false) {`
	`144`	`+ $error = 'Short description duplicates class property name.';`
	`145`	`+ $phpcsFile->addWarning($error, $isShortDescriptionPreviousVar, 'AlreadyHaveMeaningfulNameVar');`
`145`	`146`	`}`
`146`		`- $error = 'Short description duplicates class property name.';`
`147`		`- $phpcsFile->addWarning($error, $isShortDescriptionPreviousVar, 'AlreadyHaveMeaningfulNameVar');`
`148`	`147`	`}`
`149`	`148`
`150`	`149`	`/**`