Merge pull request #176 from magento-commerce/develop

Develop to master v22

Author: loginesta

.gitignore

@@ -9,3 +9,4 @@
 .vscode/
 
 .phpunit.result.cache
+.DS_Store

Magento2/Sniffs/Legacy/ObsoleteResponseSniff.php

@@ -29,7 +29,7 @@
  * @since 9.0.0  Dropped support for PHP_CodeSniffer 1.x.
  * @since 10.0.0 Updated for preliminary support of PHP_CodeSniffer 4.
  */
-class BaseSniffTest extends TestCase
+abstract class BaseSniffTest extends TestCase
 {
 
     /**

Magento2/Tests/Legacy/ObsoleteResponseUnitTest.inc

@@ -37,7 +37,7 @@ public function getErrorList()
      */
     public function getWarningList()
     {
-       return [
+        return [
             6 => 1,
             7 => 1,
             14 => 1,

Magento2/Tests/Legacy/ObsoleteResponseUnitTest.php

@@ -350,11 +350,7 @@
         <severity>8</severity>
         <type>warning</type>
     </rule>
-    <rule ref="Magento2.Legacy.ObsoleteResponse">
-        <severity>8</severity>
-        <type>warning</type>
-    </rule>
-
+   
     <!-- Severity 7 warnings: General code issues. -->
     <rule ref="Generic.Arrays.DisallowLongArraySyntax">
         <severity>7</severity>

Magento2/Tests/PHPCompatibility/BaseSniffTest.php

@@ -6,15 +6,15 @@
         "AFL-3.0"
     ],
     "type": "phpcodesniffer-standard",
-    "version": "21",
+    "version": "22",
     "require": {
         "php": ">=7.3",
         "webonyx/graphql-php": "^14.9",
         "ext-simplexml": "*",
         "ext-dom": "*",
         "phpcompatibility/php-compatibility": "^9.3",
         "squizlabs/php_codesniffer": "^3.6.1",
-        "rector/rector": ">=0.12.4 <=0.12.16"
+        "rector/rector": "^0.12.17"
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5.8"

Magento2/Tests/PHPCompatibility/ForbiddenFinalPrivateMethodsUnitTest.php

@@ -8,7 +8,7 @@
 use Rector\Core\ValueObject\PhpVersion;
 use Rector\Php80\Rector\Class_\StringableForToStringRector;
 use Rector\Php80\Rector\ClassMethod\FinalPrivateToPrivateVisibilityRector;
-use Rector\Php80\Rector\ClassMethod\OptionalParametersAfterRequiredRector;
+use Rector\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector;
 use Rector\Php80\Rector\ClassMethod\SetStateToStaticRector;
 use Rector\Php81\Rector\FuncCall\Php81ResourceReturnToObjectRector;
 use Magento2\Rector\Src\ReplacePregSplitNullLimit;