[Issue] Call RemoveItem on cart instead of ItemRepository

[m2-assistant]

This issue is automatically created based on existing pull request: #40248: Call RemoveItem on cart instead of ItemRepository

---

Description (*)

This PR replaces the deleteById calls on the CartItemRepository with removeItem on the cart instance.
This makes sure expected observers are triggered and the item is actually updated on the cart object as well, instead of in the database only.

This fixes a case where if you mass remove items using updateCartItems only a single item is removed in the response.

Manual testing scenarios (*)

1. Add multiple products to the cart
2. remove the products with the following query

mutation updateCart($input: UpdateCartItemsInput) {
  updateCartItems(input: $input) {
    cart {
      items {
        uid
      }
    }
  }
}

{
  "input": {
    "cart_id": "xxxx",
    "cart_items": [
      {
        "cart_item_id": "xx",
        "quantity": 0
      },
      {
        "cart_item_id": "xx",
        "quantity": 0
      },
      {
        "cart_item_id": "xx",
        "quantity": 0
      },
      {
        "cart_item_id": "xx",
        "quantity": 0
      },
      {
        "cart_item_id": "xx",
        "quantity": 0
      }
    ]
  }
}

3. Observe how items still appear to be in the cart until you manually request the cart again.
4. Repeat these steps after applying this PR
5. Observe how all selected items have immediately disappeared from the response.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[engcom-Bravo]

Hi @indykoning,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

We have updated multiple items and all items immediately disappeared from the response.Could you please let us know if we are still missing anything.

Thanks.

[indykoning]

Hi @indykoning,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

We have updated multiple items and all items immediately disappeared from the response.Could you please let us know if we are still missing anything.

Thanks.

The difference in your testing and the issue i ran into seems to be items vs itemsV2
Indeed you're right that it did get removed for itemsV2 but it still exists in items

I think the reason for this difference is that itemsV2 queries the database again with your pagination, page and sorting applied.
While items takes the data straight from the Quote object

[engcom-Bravo]

Hi @indykoning,

Thanks for your Update.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

all items are not removed from the cart.Hence Confirming the issue.

Thanks