fix

Author: gargsaumya

mssql_python/pybind/ddbc_bindings.cpp

@@ -2822,7 +2822,7 @@ SQLRETURN SQLGetData_wrap(SqlHandlePtr StatementHandle, SQLUSMALLINT colCount, p
                                      sizeof(timestampValue), NULL);
                 if (SQL_SUCCEEDED(ret)) {
                     row.append(
-                        PythonObjectCache::datetime_class(
+                        PythonObjectCache::get_datetime_class()(
                             timestampValue.year,
                             timestampValue.month,
                             timestampValue.day,
@@ -3649,7 +3649,7 @@ SQLRETURN FetchAll_wrap(SqlHandlePtr StatementHandle, py::list& rows) {
     }
 
     // Define a memory limit (1 GB)
-    const size_t memoryLimit = 1ULL * 1024 * 1024;
+    const size_t memoryLimit = 1ULL * 1024 * 1024 * 1024;
     size_t totalRowSize = calculateRowSize(columnNames, numCols);
 
     // Calculate fetch size based on the total row size and memory limit
@@ -3677,6 +3677,9 @@ SQLRETURN FetchAll_wrap(SqlHandlePtr StatementHandle, py::list& rows) {
         // If the row size is larger than the memory limit, fetch one row at a time
         fetchSize = 1;
     } else if (numRowsInMemLimit > 0 && numRowsInMemLimit <= 100) {
+        // If between 1-100 rows fit in memoryLimit, fetch 10 rows at a time
+        fetchSize = 10;
+    } else if (numRowsInMemLimit > 100 && numRowsInMemLimit <= 1000) {
         // If between 100-1000 rows fit in memoryLimit, fetch 100 rows at a time
         fetchSize = 100;
     } else {

tests/test_005_connection_cursor_lifecycle.py

@@ -610,18 +610,19 @@ def test_concurrent_cursor_operations_no_segfault(conn_str):
 import threading
 from mssql_python import connect
 
-conn = connect("{escaped_conn_str}")
 results = []
 exceptions = []
 
 def worker(thread_id):
     try:
+        conn = connect("{escaped_conn_str}")
         for i in range(15):
             cursor = conn.cursor()
             cursor.execute(f"SELECT {{thread_id * 100 + i}} as value")
             result = cursor.fetchone()
             results.append(result[0])
             # Don't explicitly close cursor - test concurrent destructors
+        conn.close()
     except Exception as e:
         exceptions.append(f"Thread {{thread_id}}: {{e}}")