Handle zip paths for LSP

Author: GGomez99

_extension/src/client.ts

@@ -28,7 +28,14 @@ export class Client {
         this.clientOptions = {
             documentSelector: [
                 ...jsTsLanguageModes.map(language => ({ scheme: "file", language })),
-                ...jsTsLanguageModes.map(language => ({ scheme: "untitled", language })),
+                ...jsTsLanguageModes.map(language => ({
+                    scheme: "untitled",
+                    language,
+                })),
+                ...jsTsLanguageModes.map(language => ({
+                    scheme: "zip",
+                    language,
+                })),
             ],
             outputChannel: this.outputChannel,
             traceOutputChannel: this.traceOutputChannel,

internal/ls/converters.go

@@ -128,7 +128,14 @@ func FileNameToDocumentURI(fileName string) lsproto.DocumentUri {
 		parts[i] = extraEscapeReplacer.Replace(url.PathEscape(part))
 	}
 
-	return lsproto.DocumentUri("file://" + volume + strings.Join(parts, "/"))
+	var prefix string
+	if tspath.IsZipPath(fileName) {
+		prefix = "zip:"
+	} else {
+		prefix = "file:"
+	}
+
+	return lsproto.DocumentUri(prefix + "//" + volume + strings.Join(parts, "/"))
 }
 
 func (c *Converters) LineAndCharacterToPosition(script Script, lineAndCharacter lsproto.Position) core.TextPos {

internal/ls/converters_test.go

@@ -31,6 +31,9 @@ func TestDocumentURIToFileName(t *testing.T) {
 		{"file://localhost/c%24/GitDevelopment/express", "//localhost/c$/GitDevelopment/express"},
 		{"file:///c%3A/test%20with%20%2525/c%23code", "c:/test with %25/c#code"},
 
+		{"zip:///path/to/archive.zip/file.ts", "/path/to/archive.zip/file.ts"},
+		{"zip:///d:/work/tsgo932/lib/archive.zip/utils.ts", "d:/work/tsgo932/lib/archive.zip/utils.ts"},
+
 		{"untitled:Untitled-1", "^/untitled/ts-nul-authority/Untitled-1"},
 		{"untitled:Untitled-1#fragment", "^/untitled/ts-nul-authority/Untitled-1#fragment"},
 		{"untitled:c:/Users/jrieken/Code/abc.txt", "^/untitled/ts-nul-authority/c:/Users/jrieken/Code/abc.txt"},
@@ -69,6 +72,9 @@ func TestFileNameToDocumentURI(t *testing.T) {
 		{"//localhost/c$/GitDevelopment/express", "file://localhost/c%24/GitDevelopment/express"},
 		{"c:/test with %25/c#code", "file:///c%3A/test%20with%20%2525/c%23code"},
 
+		{"/path/to/archive.zip/file.ts", "zip:///path/to/archive.zip/file.ts"},
+		{"d:/work/tsgo932/lib/archive.zip/utils.ts", "zip:///d%3A/work/tsgo932/lib/archive.zip/utils.ts"},
+
 		{"^/untitled/ts-nul-authority/Untitled-1", "untitled:Untitled-1"},
 		{"^/untitled/ts-nul-authority/c:/Users/jrieken/Code/abc.txt", "untitled:c:/Users/jrieken/Code/abc.txt"},
 		{"^/untitled/ts-nul-authority///wsl%2Bubuntu/home/jabaile/work/TypeScript-go/newfile.ts", "untitled://wsl%2Bubuntu/home/jabaile/work/TypeScript-go/newfile.ts"},

internal/lsp/lsproto/lsp.go

@@ -14,7 +14,7 @@ import (
 type DocumentUri string // !!!
 
 func (uri DocumentUri) FileName() string {
-	if strings.HasPrefix(string(uri), "file://") {
+	if strings.HasPrefix(string(uri), "file://") || strings.HasPrefix(string(uri), "zip:") {
 		parsed := core.Must(url.Parse(string(uri)))
 		if parsed.Host != "" {
 			return "//" + parsed.Host + parsed.Path