Fix vscode command in "Open in Copilot Agent Mode" (#20159) (#20162)

Author: caohai

localization/l10n/bundle.l10n.json

@@ -2008,6 +2008,7 @@
   },
   "Unknown error": "Unknown error",
   "No active database connection in the current editor. Please establish a connection to continue.": "No active database connection in the current editor. Please establish a connection to continue.",
+  "Chat command not available in this VS Code version": "Chat command not available in this VS Code version",
   "$(plug)  Connect to MSSQL": "$(plug)  Connect to MSSQL",
   "Cancel failed: {0}/{0} is the error message": {
     "message": "Cancel failed: {0}",

localization/xliff/vscode-mssql.xlf

@@ -429,6 +429,9 @@
       <note>{0} is the connection ID
 {1} is the database name</note>
     </trans-unit>
+    <trans-unit id="++CODE++6822b8489308b650f2e36cb439297b0c4a43859fe39e164aea3ad453f4bd14d7">
+      <source xml:lang="en">Chat command not available in this VS Code version</source>
+    </trans-unit>
     <trans-unit id="++CODE++c8cabf4a998e678eb3213d46a3e9e80217b7839fb5f3537ee550a65e3b2202c9">
       <source xml:lang="en">Check Constraint</source>
     </trans-unit>

src/constants/constants.ts

@@ -98,6 +98,8 @@ export const cmdAzureSignInToCloud = "azure-account.loginToCloud";
 export const cmdAadRemoveAccount = "mssql.removeAadAccount";
 export const cmdAadAddAccount = "mssql.addAadAccount";
 export const cmdClearAzureTokenCache = "mssql.clearAzureAccountTokenCache";
+export const vscodeWorkbenchChatOpenAgent = "workbench.action.chat.openagent";
+export const vscodeWorkbenchChatOpenAgentLegacy = "workbench.action.chat.openAgent";
 export const cmdShowEstimatedPlan = "mssql.showEstimatedPlan";
 export const cmdEnableActualPlan = "mssql.enableActualPlan";
 export const cmdDisableActualPlan = "mssql.disableActualPlan";

src/constants/locConstants.ts

@@ -1731,6 +1731,9 @@ export class MssqlChatAgent {
     public static noActiveDatabaseConnection = l10n.t(
         "No active database connection in the current editor. Please establish a connection to continue.",
     );
+    public static chatCommandNotAvailable = l10n.t(
+        "Chat command not available in this VS Code version",
+    );
 }
 
 export class QueryEditor {

src/controllers/mainController.ts

@@ -113,6 +113,7 @@ export default class MainController implements vscode.Disposable {
     private _queryHistoryProvider: QueryHistoryProvider;
     private _scriptingService: ScriptingService;
     private _queryHistoryRegistered: boolean = false;
+    private _availableCommands: string[] | undefined;
     public sqlTasksService: SqlTasksService;
     public dacFxService: DacFxService;
     public schemaCompareService: SchemaCompareService;
@@ -451,10 +452,20 @@ export default class MainController implements vscode.Disposable {
                     } else if (databaseName === LocalizedConstants.defaultDatabaseLabel) {
                         connectionCredentials.database = "";
                     }
-                    vscode.commands.executeCommand(
-                        "workbench.action.chat.openAgent",
-                        `Connect to ${connectionCredentials.server},${connectionCredentials.database}${connectionCredentials.profileName ? ` using profile ${connectionCredentials.profileName}` : ""}.`,
-                    );
+
+                    // Use the improved command detection
+                    const chatCommand = await this.findChatOpenAgentCommand();
+                    if (chatCommand) {
+                        vscode.commands.executeCommand(
+                            chatCommand,
+                            `Connect to ${connectionCredentials.server},${connectionCredentials.database}${connectionCredentials.profileName ? ` using profile ${connectionCredentials.profileName}` : ""}.`,
+                        );
+                    } else {
+                        // Fallback or error handling
+                        this._vscodeWrapper.showErrorMessage(
+                            LocalizedConstants.MssqlChatAgent.chatCommandNotAvailable,
+                        );
+                    }
                 },
             );
 
@@ -846,6 +857,37 @@ export default class MainController implements vscode.Disposable {
         return this._initialized;
     }
 
+    /**
+     * Get available VS Code commands (cached for performance)
+     */
+    private async getAvailableCommands(): Promise<string[]> {
+        if (!this._availableCommands) {
+            this._availableCommands = await vscode.commands.getCommands();
+        }
+        return this._availableCommands;
+    }
+
+    /**
+     * Find the correct chat open agent command variant that exists in the current VS Code version
+     */
+    private async findChatOpenAgentCommand(): Promise<string | undefined> {
+        const commands = await this.getAvailableCommands();
+
+        // Try to find the correct command, checking both variants
+        const possibleCommands = [
+            Constants.vscodeWorkbenchChatOpenAgent, // Current VS Code
+            Constants.vscodeWorkbenchChatOpenAgentLegacy, // Legacy VS Code
+        ];
+
+        for (const cmd of possibleCommands) {
+            if (commands.includes(cmd)) {
+                return cmd;
+            }
+        }
+
+        return undefined;
+    }
+
     public get context(): vscode.ExtensionContext {
         return this._context;
     }