Compilation failed in React Native 0.48.3

[ivan-magda]

Hey, @mohtada-h !

In React Native 0.48.3 I got some errors:

• [ReactNestedScrollViewHelper]: ScrollEvent.obtain method signature has changed. Added 2 additional parameters (xVelocity, yVelocity)
• [ReactNestedScrollViewManager]: ScrollEventType does not has ANIMATION_END
• [ReactNestedScrollViewPackage]: createJSModules - does not override method from its superclass

ScrollEvent

ScrollEvent's obtaib now has the following signature:

public static ScrollEvent obtain(
      int viewTag,
      ScrollEventType scrollEventType,
      int scrollX,
      int scrollY,
      float xVelocity,
      float yVelocity,
      int contentWidth,
      int contentHeight,
      int scrollViewWidth,
      int scrollViewHeight) {

ScrollEventType

ScrollEventType now it looks like this:

public enum ScrollEventType {
  BEGIN_DRAG("topScrollBeginDrag"),
  END_DRAG("topScrollEndDrag"),
  SCROLL("topScroll"),
  MOMENTUM_BEGIN("topMomentumScrollBegin"),
  MOMENTUM_END("topMomentumScrollEnd");
...
}

public static Map createExportedCustomDirectEventTypeConstants() {
    return MapBuilder.builder()
        .put(ScrollEventType.SCROLL.getJSEventName(), MapBuilder.of("registrationName", "onScroll"))
        .put(ScrollEventType.BEGIN_DRAG.getJSEventName(), MapBuilder.of("registrationName", "onScrollBeginDrag"))
        .put(ScrollEventType.END_DRAG.getJSEventName(), MapBuilder.of("registrationName", "onScrollEndDrag"))
        .put(ScrollEventType.MOMENTUM_BEGIN.getJSEventName(), MapBuilder.of("registrationName", "onMomentumScrollBegin"))
        .put(ScrollEventType.MOMENTUM_END.getJSEventName(), MapBuilder.of("registrationName", "onMomentumScrollEnd"))
        .build();
  }

ReactPackage

ReactPackage interface now has only 2 methods:

public interface ReactPackage {

  /**
   * @param reactContext react application context that can be used to create modules
   * @return list of native modules to register with the newly created catalyst instance
   */
  List<NativeModule> createNativeModules(ReactApplicationContext reactContext);

  /**
   * @return a list of view managers that should be registered with {@link UIManagerModule}
   */
  List<ViewManager> createViewManagers(ReactApplicationContext reactContext);
}

I was able to run the project after deleting ScrollEventType.ANIMATION_END, createJSModules and passing random values to velocity parameters.

Please take a look at this problem and do appropriate updates.

Thanks!

[smallpath]

It seems that this repo is not maintained any more. There is a pull request I sended here but gains nothing.

[ivan-magda]

@smallpath it’s sadly.

[Nyl000]

Fixed for 0.47.2 here #5
Maybe works with your 0.48.3 too ?