Small fixes

Author: papafe

src/MongoDB.Bson/IO/IBsonReader.cs

@@ -17,7 +17,8 @@
 
 namespace MongoDB.Bson.IO
 {
-    //FP This interface should have the settingg property as well, same way it's done for thr writer
+    //DOMAIN-API This interface should have the setting property as well probably., same way it's done for thr writer.
+    //Even if we don't need it now, it could be needed in the future.
     /// <summary>
     /// Represents a BSON reader.
     /// </summary>

src/MongoDB.Bson/Serialization/BsonSerializer.cs

@@ -34,6 +34,7 @@ static BsonSerializer()
             _serializationDomain = new BsonSerializationDomain("MAIN");
         }
 
+        //QUESTION I think we should have another property here, called StandardSerializationDomain, which would have only the standard serializers and conventions registered.
         internal static IBsonSerializationDomain DefaultSerializationDomain => _serializationDomain;
 
         // public static properties

src/MongoDB.Bson/Serialization/IBsonSerializationProvider.cs

@@ -55,7 +55,7 @@ internal interface IDomainAwareBsonSerializationProvider : IRegistryAwareBsonSer
     {
         IBsonSerializationDomain SerializationDomain { get; }
 
-        //FP Can't use just GetSerializer because it's already used by the base interface.
+        //FP Can't use just GetSerializer name because it's already used by the base interface.
         IBsonSerializer GetSerializerWithDomain(Type type);
     }
 }

src/MongoDB.Driver.Encryption/ExplicitEncryptionLibMongoCryptController.cs

@@ -102,7 +102,7 @@ public Guid CreateDataKey(
                 {
                     var wrappedKeyBytes = ProcessStates(context, _keyVaultNamespace.DatabaseNamespace.DatabaseName, cancellationToken);
 
-                    var wrappedKeyDocument = BsonSerializer.Deserialize<BsonDocument>(wrappedKeyBytes); //FP I think this is fine, as it should be default configuration.
+                    var wrappedKeyDocument = BsonSerializer.Deserialize<BsonDocument>(wrappedKeyBytes); //FP I think this is fine for now, this should use the standard domain.
                     var keyId = UnwrapKeyId(wrappedKeyDocument);
 
                     _keyVaultCollection.Value.InsertOne(wrappedKeyDocument, cancellationToken: cancellationToken);
@@ -131,7 +131,7 @@ public async Task<Guid> CreateDataKeyAsync(
                 {
                     var wrappedKeyBytes = await ProcessStatesAsync(context, _keyVaultNamespace.DatabaseNamespace.DatabaseName, cancellationToken).ConfigureAwait(false);
 
-                    var wrappedKeyDocument = BsonSerializer.Deserialize<BsonDocument>(wrappedKeyBytes); //FP I think this is fine, as it should be default configuration.
+                    var wrappedKeyDocument = BsonSerializer.Deserialize<BsonDocument>(wrappedKeyBytes); //FP I think this is fine for now, this should use the standard domain.
                     var keyId = UnwrapKeyId(wrappedKeyDocument);
 
                     await _keyVaultCollection.Value.InsertOneAsync(wrappedKeyDocument, cancellationToken: cancellationToken).ConfigureAwait(false);
@@ -555,7 +555,7 @@ private byte[] GetWrappedValueBytes(BsonValue value)
 
         private static BsonValue RenderFilter(FilterDefinition<BsonDocument> filter)
         {
-            var registry = BsonSerializer.SerializerRegistry; //FP I think this is fine, as it should be default configuration.
+            var registry = BsonSerializer.SerializerRegistry; //FP I think this is fine for now, this should use the standard domain.
             var serializer = registry.GetSerializer<BsonDocument>();
             return filter.Render(new(serializer, registry));
         }
@@ -572,7 +572,7 @@ private static Guid UnwrapKeyId(BsonDocument wrappedKeyDocument)
 
         private static BsonValue UnwrapValue(byte[] encryptedWrappedBytes)
         {
-            var bsonDocument = BsonSerializer.Deserialize<BsonDocument>(encryptedWrappedBytes); //FP I think this is fine, as it should be default configuration.
+            var bsonDocument = BsonSerializer.Deserialize<BsonDocument>(encryptedWrappedBytes); //FP I think this is fine for now, this should use the standard domain.
             return bsonDocument["v"];
         }
     }

src/MongoDB.Driver/Core/Bindings/CoreSession.cs

@@ -46,7 +46,6 @@ public sealed class CoreSession : ICoreSession, ICoreSessionInternal
         private BsonTimestamp _snapshotTime;
 
         // constructors
-        //FP This constructor is only used by the tests.
         internal CoreSession(
             IClusterInternal cluster,
             ICoreServerSession serverSession,

src/MongoDB.Driver/Core/WireProtocol/Messages/Encoders/BinaryEncoders/CommandMessageBinaryEncoder.cs

@@ -29,7 +29,7 @@ internal sealed class CommandMessageBinaryEncoder : MessageBinaryEncoderBase, IM
     {
         private const int EncryptedMaxBatchSize = 2 * 1024 * 1024; // 2 MiB
         private static readonly ICommandMessageSectionFormatter<Type0CommandMessageSection> __type0SectionFormatter = new Type0SectionFormatter(BsonSerializer.DefaultSerializationDomain);
-        //QUESTION Looking at the spec and our implementation, it seems that type 0 sections always serialize/deserialize RawBsonDocument, so they should use the default domain. Am I missing something?
+        //QUESTION Looking at the spec and our implementation, it seems that type 0 sections always serialize/deserialize RawBsonDocument, so they should use the standard domain. Am I missing something?
 
         // constructors
         public CommandMessageBinaryEncoder(Stream stream, MessageEncoderSettings encoderSettings)

src/MongoDB.Driver/GeoJsonObjectModel/Serializers/GeoJsonBoundingBoxSerializer.cs

@@ -93,14 +93,12 @@ protected override GeoJsonBoundingBox<TCoordinates> DeserializeValue(BsonDeseria
         /// <param name="value">The value.</param>
         protected override void SerializeValue(BsonSerializationContext context, BsonSerializationArgs args, GeoJsonBoundingBox<TCoordinates> value)
         {
-            var bsonWriter = context.Writer;
-
             // serialize min and max to a dummy document and then flatten the two arrays and serialize that
             var document = new BsonDocument();
             using (var documentWriter = new BsonDocumentWriter(document))
             {
                 var documentContext =
-                    BsonSerializationContext.CreateRoot(documentWriter, BsonSerializer.DefaultSerializationDomain); //FP Is this correct?;
+                    BsonSerializationContext.CreateRoot(documentWriter, context.SerializationDomain);
                 documentWriter.WriteStartDocument();
                 documentWriter.WriteName("min");
                 _coordinatesSerializer.Serialize(documentContext, value.Min);