Big serializer check

papafe · papafe · commit e9511c08cef9 · 2025-06-30T11:20:21.000+02:00
diff --git a/src/MongoDB.Bson/Serialization/Serializers/DictionaryInterfaceImplementerSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/DictionaryInterfaceImplementerSerializer.cs
@@ -31,13 +31,15 @@ public sealed class DictionaryInterfaceImplementerSerializer<TDictionary> :
         IDictionaryRepresentationConfigurable
             where TDictionary : class, IDictionary, new()
     {
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionaryInterfaceImplementerSerializer{TDictionary}"/> class.
         /// </summary>
         public DictionaryInterfaceImplementerSerializer()
         {
         }
 
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionaryInterfaceImplementerSerializer{TDictionary}"/> class.
         /// </summary>
diff --git a/src/MongoDB.Bson/Serialization/Serializers/DictionarySerializerBase.cs b/src/MongoDB.Bson/Serialization/Serializers/DictionarySerializerBase.cs
@@ -45,6 +45,7 @@ private static class Flags
         private readonly IBsonSerializer _valueSerializer;
 
         // constructors
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary}"/> class.
         /// </summary>
@@ -53,12 +54,13 @@ public DictionarySerializerBase()
         {
         }
 
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary}"/> class.
         /// </summary>
         /// <param name="dictionaryRepresentation">The dictionary representation.</param>
         public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)
-            : this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>())  //TODO We can keep this as is?
+            : this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>())
         {
         }
 
@@ -373,6 +375,7 @@ private static class Flags
         private readonly Lazy<IBsonSerializer<TValue>> _lazyValueSerializer;
 
         // constructors
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary, TKey, TValue}"/> class.
         /// </summary>
@@ -381,12 +384,14 @@ public DictionarySerializerBase()
         {
         }
 
+        //DOMAIN-API This version should be removed in the future.
+        //FP Fortunately it seems that all the constructors that should not be used are actually not used in the codebase.
         /// <summary>
         /// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary, TKey, TValue}" /> class.
         /// </summary>
         /// <param name="dictionaryRepresentation">The dictionary representation.</param>
         public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)
-            : this(dictionaryRepresentation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is?
+            : this(dictionaryRepresentation, BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/EnumerableSerializerBase.cs b/src/MongoDB.Bson/Serialization/Serializers/EnumerableSerializerBase.cs
@@ -31,11 +31,12 @@ public abstract class EnumerableSerializerBase<TValue> : SerializerBase<TValue>,
         private readonly Lazy<IBsonSerializer> _lazyItemSerializer;
 
         // constructors
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue}"/> class.
         /// </summary>
         protected EnumerableSerializerBase()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -230,11 +231,12 @@ public abstract class EnumerableSerializerBase<TValue, TItem> : SerializerBase<T
         private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;
 
         // constructors
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue, TItem}"/> class.
         /// </summary>
         protected EnumerableSerializerBase()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/ExpandoObjectSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/ExpandoObjectSerializer.cs
@@ -31,6 +31,7 @@ public sealed class ExpandoObjectSerializer : DynamicDocumentBaseSerializer<Expa
         // private fields
         private readonly IBsonSerializer<List<object>> _listSerializer;
 
+        //DOMAIN-API This version should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="ExpandoObjectSerializer"/> class.
         /// </summary>
@@ -39,10 +40,6 @@ public ExpandoObjectSerializer()
         {
         }
 
-        /// <summary>
-        /// //TODO
-        /// </summary>
-        /// <param name="serializerRegistry"></param>
         internal ExpandoObjectSerializer(IBsonSerializerRegistry serializerRegistry)
         {
             _listSerializer = serializerRegistry.GetSerializer<List<object>>();
diff --git a/src/MongoDB.Bson/Serialization/Serializers/IEnumerableDeserializingAsCollectionSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/IEnumerableDeserializingAsCollectionSerializer.cs
@@ -45,12 +45,13 @@ private static void EnsureTIEnumerableIsAnInterface()
         // private fields
         private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;
 
+        //DOMAIN-API This should be removed in the future.
         // constructors
         /// <summary>
         /// Initializes a new instance of the IEnumerableDeserializingAsCollectionSerializer class.
         /// </summary>
         public IEnumerableDeserializingAsCollectionSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/ImpliedImplementationInterfaceSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/ImpliedImplementationInterfaceSerializer.cs
@@ -48,11 +48,12 @@ public sealed class ImpliedImplementationInterfaceSerializer<TInterface, TImplem
         private readonly Lazy<IBsonSerializer<TImplementation>> _lazyImplementationSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="ImpliedImplementationInterfaceSerializer{TInterface, TImplementation}"/> class.
         /// </summary>
         public ImpliedImplementationInterfaceSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/KeyValuePairSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/KeyValuePairSerializer.cs
@@ -53,6 +53,7 @@ private static class Flags
         private readonly Lazy<IBsonSerializer<TValue>> _lazyValueSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="KeyValuePairSerializer{TKey, TValue}"/> class.
         /// </summary>
@@ -61,12 +62,13 @@ public KeyValuePairSerializer()
         {
         }
 
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="KeyValuePairSerializer{TKey, TValue}"/> class.
         /// </summary>
         /// <param name="representation">The representation.</param>
         public KeyValuePairSerializer(BsonType representation)
-            : this(representation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is?
+            : this(representation, BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/NullableSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/NullableSerializer.cs
@@ -60,11 +60,12 @@ public sealed class NullableSerializer<T> :
         private Lazy<IBsonSerializer<T>> _lazySerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="NullableSerializer{T}"/> class.
         /// </summary>
         public NullableSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/ObjectSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/ObjectSerializer.cs
@@ -47,7 +47,7 @@ public sealed class ObjectSerializer : ClassSerializerBase<object>, IHasDiscrimi
         /// <summary>
         /// Gets the standard instance.
         /// </summary>
-        public static ObjectSerializer Instance => __instance;
+        public static ObjectSerializer Instance => __instance;  //FP This is problematic, but can't do much about it now.
 
         /// <summary>
         /// An allowed types function that returns false for all types.
@@ -63,11 +63,12 @@ public sealed class ObjectSerializer : ClassSerializerBase<object>, IHasDiscrimi
         private readonly GuidSerializer _guidSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="ObjectSerializer"/> class.
         /// </summary>
         public ObjectSerializer()
-            : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object))) //TODO We can keep this as is
+            : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)))
         {
         }
 
@@ -91,12 +92,13 @@ public ObjectSerializer(IDiscriminatorConvention discriminatorConvention, GuidRe
         {
         }
 
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="ObjectSerializer"/> class.
         /// </summary>
         /// <param name="allowedTypes">A delegate that determines what types are allowed.</param>
         public ObjectSerializer(Func<Type, bool> allowedTypes)
-            : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes) //TODO We can keep this as is
+            : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/SerializeAsNominalTypeSerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/SerializeAsNominalTypeSerializer.cs
@@ -28,11 +28,12 @@ public sealed class SerializeAsNominalTypeSerializer<TActualType, TNominalType>
         private readonly Lazy<IBsonSerializer<TNominalType>> _lazyNominalTypeSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="SerializeAsNominalTypeSerializer{TActualType, TNominalType}"/> class.
         /// </summary>
         public SerializeAsNominalTypeSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/ThreeDimensionalArraySerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/ThreeDimensionalArraySerializer.cs
@@ -30,11 +30,12 @@ public sealed class ThreeDimensionalArraySerializer<TItem> :
         private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="ThreeDimensionalArraySerializer{TItem}"/> class.
         /// </summary>
         public ThreeDimensionalArraySerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/TwoDimensionalArraySerializer.cs b/src/MongoDB.Bson/Serialization/Serializers/TwoDimensionalArraySerializer.cs
@@ -30,11 +30,12 @@ public sealed class TwoDimensionalArraySerializer<TItem> :
         private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future.
         /// <summary>
         /// Initializes a new instance of the <see cref="TwoDimensionalArraySerializer{TItem}"/> class.
         /// </summary>
         public TwoDimensionalArraySerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Bson/Serialization/Serializers/ValueTupleSerializers.cs b/src/MongoDB.Bson/Serialization/Serializers/ValueTupleSerializers.cs
@@ -71,11 +71,12 @@ public sealed class ValueTupleSerializer<T1> : StructSerializerBase<ValueTuple<T
         private readonly Lazy<IBsonSerializer<T1>> _lazyItem1Serializer;
 
         // constructors
+        //DOMAIN-API This should be removed in the future (also for the other versions)
         /// <summary>
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -193,7 +194,7 @@ public sealed class ValueTupleSerializer<T1, T2> : StructSerializerBase<ValueTup
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -329,7 +330,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3> : StructSerializerBase<Valu
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -483,7 +484,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3, T4> : StructSerializerBase<
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3, T4}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -655,7 +656,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3, T4, T5> : StructSerializerB
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3, T4, T5}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -845,7 +846,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3, T4, T5, T6> : StructSeriali
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3, T4, T5, T6}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -1053,7 +1054,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3, T4, T5, T6, T7> : StructSer
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3, T4, T5, T6, T7}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
@@ -1280,7 +1281,7 @@ public sealed class ValueTupleSerializer<T1, T2, T3, T4, T5, T6, T7, TRest> : St
         /// Initializes a new instance of the <see cref="ValueTupleSerializer{T1, T2, T3, T4, T5, T6, T7, TRest}"/> class.
         /// </summary>
         public ValueTupleSerializer()
-            : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is
+            : this(BsonSerializer.SerializerRegistry)
         {
         }
 
diff --git a/src/MongoDB.Driver/Core/Operations/GroupOperation.cs b/src/MongoDB.Driver/Core/Operations/GroupOperation.cs
@@ -165,7 +165,7 @@ public async Task<IEnumerable<TResult>> ExecuteAsync(OperationContext operationC
         private ReadCommandOperation<TResult[]> CreateOperation()
         {
             var command = CreateCommand();
-            var resultSerializer = _resultSerializer ?? BsonSerializer.LookupSerializer<TResult>(); //FP Need to take a look
+            var resultSerializer = _resultSerializer ?? _messageEncoderSettings.GetOrDefault(MessageEncoderSettingsName.SerializationDomain, BsonSerializer.DefaultSerializationDomain).LookupSerializer<TResult>();
             var resultArraySerializer = new ArraySerializer<TResult>(resultSerializer);
             var commandResultSerializer = new ElementDeserializer<TResult[]>("retval", resultArraySerializer);
             return new ReadCommandOperation<TResult[]>(_collectionNamespace.DatabaseNamespace, command, commandResultSerializer, _messageEncoderSettings)
diff --git a/src/MongoDB.Driver/GeoJsonObjectModel/Serializers/GeoJsonPointSerializer.cs b/src/MongoDB.Driver/GeoJsonObjectModel/Serializers/GeoJsonPointSerializer.cs
@@ -31,7 +31,7 @@ private static class Flags
         }
 
         // private fields
-        private readonly IBsonSerializer<TCoordinates> _coordinatesSerializer = BsonSerializer.LookupSerializer<TCoordinates>();
+        private readonly IBsonSerializer<TCoordinates> _coordinatesSerializer = BsonSerializer.LookupSerializer<TCoordinates>();  //QUESTION What do we do? We could lazily initialize it when we get the serialization/deserialization context.
         private readonly GeoJsonObjectSerializerHelper<TCoordinates> _helper;
 
         // constructors

Original file line number	Diff line number	Diff line change
`@@ -31,13 +31,15 @@ public sealed class DictionaryInterfaceImplementerSerializer<TDictionary> :`
`31`	`31`	`IDictionaryRepresentationConfigurable`
`32`	`32`	`where TDictionary : class, IDictionary, new()`
`33`	`33`	`{`
	`34`	`+ //DOMAIN-API This version should be removed in the future.`
`34`	`35`	`/// <summary>`
`35`	`36`	`/// Initializes a new instance of the <see cref="DictionaryInterfaceImplementerSerializer{TDictionary}"/> class.`
`36`	`37`	`/// </summary>`
`37`	`38`	`public DictionaryInterfaceImplementerSerializer()`
`38`	`39`	`{`
`39`	`40`	`}`
`40`	`41`
	`42`	`+ //DOMAIN-API This version should be removed in the future.`
`41`	`43`	`/// <summary>`
`42`	`44`	`/// Initializes a new instance of the <see cref="DictionaryInterfaceImplementerSerializer{TDictionary}"/> class.`
`43`	`45`	`/// </summary>`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ private static class Flags`
`45`	`45`	`private readonly IBsonSerializer _valueSerializer;`
`46`	`46`
`47`	`47`	`// constructors`
	`48`	`+ //DOMAIN-API This version should be removed in the future.`
`48`	`49`	`/// <summary>`
`49`	`50`	`/// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary}"/> class.`
`50`	`51`	`/// </summary>`
`@@ -53,12 +54,13 @@ public DictionarySerializerBase()`
`53`	`54`	`{`
`54`	`55`	`}`
`55`	`56`
	`57`	`+ //DOMAIN-API This version should be removed in the future.`
`56`	`58`	`/// <summary>`
`57`	`59`	`/// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary}"/> class.`
`58`	`60`	`/// </summary>`
`59`	`61`	`/// <param name="dictionaryRepresentation">The dictionary representation.</param>`
`60`	`62`	`public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)`
`61`		`- : this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>()) //TODO We can keep this as is?`
	`63`	`+ : this(dictionaryRepresentation, BsonSerializer.LookupSerializer<object>(), BsonSerializer.LookupSerializer<object>())`
`62`	`64`	`{`
`63`	`65`	`}`
`64`	`66`
`@@ -373,6 +375,7 @@ private static class Flags`
`373`	`375`	`private readonly Lazy<IBsonSerializer<TValue>> _lazyValueSerializer;`
`374`	`376`
`375`	`377`	`// constructors`
	`378`	`+ //DOMAIN-API This version should be removed in the future.`
`376`	`379`	`/// <summary>`
`377`	`380`	`/// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary, TKey, TValue}"/> class.`
`378`	`381`	`/// </summary>`
`@@ -381,12 +384,14 @@ public DictionarySerializerBase()`
`381`	`384`	`{`
`382`	`385`	`}`
`383`	`386`
	`387`	`+ //DOMAIN-API This version should be removed in the future.`
	`388`	`+ //FP Fortunately it seems that all the constructors that should not be used are actually not used in the codebase.`
`384`	`389`	`/// <summary>`
`385`	`390`	`/// Initializes a new instance of the <see cref="DictionarySerializerBase{TDictionary, TKey, TValue}" /> class.`
`386`	`391`	`/// </summary>`
`387`	`392`	`/// <param name="dictionaryRepresentation">The dictionary representation.</param>`
`388`	`393`	`public DictionarySerializerBase(DictionaryRepresentation dictionaryRepresentation)`
`389`		`- : this(dictionaryRepresentation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is?`
	`394`	`+ : this(dictionaryRepresentation, BsonSerializer.SerializerRegistry)`
`390`	`395`	`{`
`391`	`396`	`}`
`392`	`397`
Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,12 @@ public abstract class EnumerableSerializerBase<TValue> : SerializerBase<TValue>,`
`31`	`31`	`private readonly Lazy<IBsonSerializer> _lazyItemSerializer;`
`32`	`32`
`33`	`33`	`// constructors`
	`34`	`+ //DOMAIN-API This version should be removed in the future.`
`34`	`35`	`/// <summary>`
`35`	`36`	`/// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue}"/> class.`
`36`	`37`	`/// </summary>`
`37`	`38`	`protected EnumerableSerializerBase()`
`38`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`39`	`+ : this(BsonSerializer.SerializerRegistry)`
`39`	`40`	`{`
`40`	`41`	`}`
`41`	`42`
`@@ -230,11 +231,12 @@ public abstract class EnumerableSerializerBase<TValue, TItem> : SerializerBase<T`
`230`	`231`	`private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;`
`231`	`232`
`232`	`233`	`// constructors`
	`234`	`+ //DOMAIN-API This version should be removed in the future.`
`233`	`235`	`/// <summary>`
`234`	`236`	`/// Initializes a new instance of the <see cref="EnumerableSerializerBase{TValue, TItem}"/> class.`
`235`	`237`	`/// </summary>`
`236`	`238`	`protected EnumerableSerializerBase()`
`237`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`239`	`+ : this(BsonSerializer.SerializerRegistry)`
`238`	`240`	`{`
`239`	`241`	`}`
`240`	`242`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public sealed class ExpandoObjectSerializer : DynamicDocumentBaseSerializer<Expa`
`31`	`31`	`// private fields`
`32`	`32`	`private readonly IBsonSerializer<List<object>> _listSerializer;`
`33`	`33`
	`34`	`+ //DOMAIN-API This version should be removed in the future.`
`34`	`35`	`/// <summary>`
`35`	`36`	`/// Initializes a new instance of the <see cref="ExpandoObjectSerializer"/> class.`
`36`	`37`	`/// </summary>`
`@@ -39,10 +40,6 @@ public ExpandoObjectSerializer()`
`39`	`40`	`{`
`40`	`41`	`}`
`41`	`42`
`42`		`- /// <summary>`
`43`		`- /// //TODO`
`44`		`- /// </summary>`
`45`		`- /// <param name="serializerRegistry"></param>`
`46`	`43`	`internal ExpandoObjectSerializer(IBsonSerializerRegistry serializerRegistry)`
`47`	`44`	`{`
`48`	`45`	`_listSerializer = serializerRegistry.GetSerializer<List<object>>();`
Original file line number	Diff line number	Diff line change
`@@ -45,12 +45,13 @@ private static void EnsureTIEnumerableIsAnInterface()`
`45`	`45`	`// private fields`
`46`	`46`	`private readonly Lazy<IBsonSerializer<TItem>> _lazyItemSerializer;`
`47`	`47`
	`48`	`+ //DOMAIN-API This should be removed in the future.`
`48`	`49`	`// constructors`
`49`	`50`	`/// <summary>`
`50`	`51`	`/// Initializes a new instance of the IEnumerableDeserializingAsCollectionSerializer class.`
`51`	`52`	`/// </summary>`
`52`	`53`	`public IEnumerableDeserializingAsCollectionSerializer()`
`53`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`54`	`+ : this(BsonSerializer.SerializerRegistry)`
`54`	`55`	`{`
`55`	`56`	`}`
`56`	`57`
Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,12 @@ public sealed class ImpliedImplementationInterfaceSerializer<TInterface, TImplem`
`48`	`48`	`private readonly Lazy<IBsonSerializer<TImplementation>> _lazyImplementationSerializer;`
`49`	`49`
`50`	`50`	`// constructors`
	`51`	`+ //DOMAIN-API This should be removed in the future.`
`51`	`52`	`/// <summary>`
`52`	`53`	`/// Initializes a new instance of the <see cref="ImpliedImplementationInterfaceSerializer{TInterface, TImplementation}"/> class.`
`53`	`54`	`/// </summary>`
`54`	`55`	`public ImpliedImplementationInterfaceSerializer()`
`55`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`56`	`+ : this(BsonSerializer.SerializerRegistry)`
`56`	`57`	`{`
`57`	`58`	`}`
`58`	`59`
Original file line number	Diff line number	Diff line change
`@@ -53,6 +53,7 @@ private static class Flags`
`53`	`53`	`private readonly Lazy<IBsonSerializer<TValue>> _lazyValueSerializer;`
`54`	`54`
`55`	`55`	`// constructors`
	`56`	`+ //DOMAIN-API This should be removed in the future.`
`56`	`57`	`/// <summary>`
`57`	`58`	`/// Initializes a new instance of the <see cref="KeyValuePairSerializer{TKey, TValue}"/> class.`
`58`	`59`	`/// </summary>`
`@@ -61,12 +62,13 @@ public KeyValuePairSerializer()`
`61`	`62`	`{`
`62`	`63`	`}`
`63`	`64`
	`65`	`+ //DOMAIN-API This should be removed in the future.`
`64`	`66`	`/// <summary>`
`65`	`67`	`/// Initializes a new instance of the <see cref="KeyValuePairSerializer{TKey, TValue}"/> class.`
`66`	`68`	`/// </summary>`
`67`	`69`	`/// <param name="representation">The representation.</param>`
`68`	`70`	`public KeyValuePairSerializer(BsonType representation)`
`69`		`- : this(representation, BsonSerializer.SerializerRegistry) //TODO We can keep this as is?`
	`71`	`+ : this(representation, BsonSerializer.SerializerRegistry)`
`70`	`72`	`{`
`71`	`73`	`}`
`72`	`74`
Original file line number	Diff line number	Diff line change
`@@ -60,11 +60,12 @@ public sealed class NullableSerializer<T> :`
`60`	`60`	`private Lazy<IBsonSerializer<T>> _lazySerializer;`
`61`	`61`
`62`	`62`	`// constructors`
	`63`	`+ //DOMAIN-API This should be removed in the future.`
`63`	`64`	`/// <summary>`
`64`	`65`	`/// Initializes a new instance of the <see cref="NullableSerializer{T}"/> class.`
`65`	`66`	`/// </summary>`
`66`	`67`	`public NullableSerializer()`
`67`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`68`	`+ : this(BsonSerializer.SerializerRegistry)`
`68`	`69`	`{`
`69`	`70`	`}`
`70`	`71`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public sealed class ObjectSerializer : ClassSerializerBase<object>, IHasDiscrimi`
`47`	`47`	`/// <summary>`
`48`	`48`	`/// Gets the standard instance.`
`49`	`49`	`/// </summary>`
`50`		`- public static ObjectSerializer Instance => __instance;`
	`50`	`+ public static ObjectSerializer Instance => __instance; //FP This is problematic, but can't do much about it now.`
`51`	`51`
`52`	`52`	`/// <summary>`
`53`	`53`	`/// An allowed types function that returns false for all types.`
`@@ -63,11 +63,12 @@ public sealed class ObjectSerializer : ClassSerializerBase<object>, IHasDiscrimi`
`63`	`63`	`private readonly GuidSerializer _guidSerializer;`
`64`	`64`
`65`	`65`	`// constructors`
	`66`	`+ //DOMAIN-API This should be removed in the future.`
`66`	`67`	`/// <summary>`
`67`	`68`	`/// Initializes a new instance of the <see cref="ObjectSerializer"/> class.`
`68`	`69`	`/// </summary>`
`69`	`70`	`public ObjectSerializer()`
`70`		`- : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object))) //TODO We can keep this as is`
	`71`	`+ : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)))`
`71`	`72`	`{`
`72`	`73`	`}`
`73`	`74`
`@@ -91,12 +92,13 @@ public ObjectSerializer(IDiscriminatorConvention discriminatorConvention, GuidRe`
`91`	`92`	`{`
`92`	`93`	`}`
`93`	`94`
	`95`	`+ //DOMAIN-API This should be removed in the future.`
`94`	`96`	`/// <summary>`
`95`	`97`	`/// Initializes a new instance of the <see cref="ObjectSerializer"/> class.`
`96`	`98`	`/// </summary>`
`97`	`99`	`/// <param name="allowedTypes">A delegate that determines what types are allowed.</param>`
`98`	`100`	`public ObjectSerializer(Func<Type, bool> allowedTypes)`
`99`		`- : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes) //TODO We can keep this as is`
	`101`	`+ : this(BsonSerializer.LookupDiscriminatorConvention(typeof(object)), allowedTypes)`
`100`	`102`	`{`
`101`	`103`	`}`
`102`	`104`
Original file line number	Diff line number	Diff line change
`@@ -28,11 +28,12 @@ public sealed class SerializeAsNominalTypeSerializer<TActualType, TNominalType>`
`28`	`28`	`private readonly Lazy<IBsonSerializer<TNominalType>> _lazyNominalTypeSerializer;`
`29`	`29`
`30`	`30`	`// constructors`
	`31`	`+ //DOMAIN-API This should be removed in the future.`
`31`	`32`	`/// <summary>`
`32`	`33`	`/// Initializes a new instance of the <see cref="SerializeAsNominalTypeSerializer{TActualType, TNominalType}"/> class.`
`33`	`34`	`/// </summary>`
`34`	`35`	`public SerializeAsNominalTypeSerializer()`
`35`		`- : this(BsonSerializer.SerializerRegistry) //TODO We can keep this as is`
	`36`	`+ : this(BsonSerializer.SerializerRegistry)`
`36`	`37`	`{`
`37`	`38`	`}`
`38`	`39`