Code polishing

Author: jeffgbutler

src/main/java/org/mybatis/dynamic/sql/render/RenderingStrategy.java

@@ -32,5 +32,6 @@ public String getFormattedJdbcPlaceholder(String prefix, String parameterName) {
         return getFormattedJdbcPlaceholder(Optional.empty(), prefix, parameterName);
     }
 
-    public abstract String getFormattedJdbcPlaceholder(Optional<BindableColumn<?>> column, String prefix, String parameterName);
+    public abstract String getFormattedJdbcPlaceholder(Optional<BindableColumn<?>> column, String prefix,
+            String parameterName);
 }

src/main/java/org/mybatis/dynamic/sql/select/render/SelectRenderer.java

@@ -79,13 +79,15 @@ private String orderByPhrase(SortSpecification column) {
     }
 
     private String renderLimit(Map<String, Object> parameters, Long limit) {
-        String placeholder = renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX, LIMIT_PARAMETER); 
+        String placeholder = renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX,
+                LIMIT_PARAMETER); 
         parameters.put(LIMIT_PARAMETER, limit);
         return "limit " + placeholder; //$NON-NLS-1$
     }
 
     private String renderOffset(Map<String, Object> parameters, Long offset) {
-        String placeholder = renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX, OFFSET_PARAMETER);
+        String placeholder = renderingStrategy.getFormattedJdbcPlaceholder(RenderingStrategy.DEFAULT_PARAMETER_PREFIX,
+                OFFSET_PARAMETER);
         parameters.put(OFFSET_PARAMETER, offset);
         return "offset " + placeholder; //$NON-NLS-1$
     }

src/test/java/examples/springbatch/cursor/SpringBatchCursorTest.java

@@ -28,6 +28,7 @@
 import org.springframework.batch.core.ExitStatus;
 import org.springframework.batch.core.JobExecution;
 import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.item.ExecutionContext;
 import org.springframework.batch.test.JobLauncherTestUtils;
 import org.springframework.batch.test.context.SpringBatchTest;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -61,10 +62,14 @@ public void testThatRowsAreTransformedToUpperCase() throws Exception {
     private int numberOfRowsProcessed(JobExecution jobExecution) {
         return jobExecution.getStepExecutions().stream()
                 .map(StepExecution::getExecutionContext)
-                .mapToInt(ec -> ec.getInt("row_count"))
+                .mapToInt(this::getRowCount)
                 .sum();
     }
 
+    private int getRowCount(ExecutionContext executionContext) {
+        return executionContext.getInt("row_count", 0);
+    }
+    
     private long upperCaseRowCount() throws Exception {
         try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
             PersonMapper personMapper = sqlSession.getMapper(PersonMapper.class);

src/test/java/examples/springbatch/paging/SpringBatchPagingTest.java

@@ -28,6 +28,7 @@
 import org.springframework.batch.core.ExitStatus;
 import org.springframework.batch.core.JobExecution;
 import org.springframework.batch.core.StepExecution;
+import org.springframework.batch.item.ExecutionContext;
 import org.springframework.batch.test.JobLauncherTestUtils;
 import org.springframework.batch.test.context.SpringBatchTest;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -62,17 +63,25 @@ public void testThatRowsAreTransformedToUpperCase() throws Exception {
     private int numberOfRowsProcessed(JobExecution jobExecution) {
         return jobExecution.getStepExecutions().stream()
                 .map(StepExecution::getExecutionContext)
-                .mapToInt(ec -> ec.getInt("row_count"))
+                .mapToInt(this::getRowCount)
                 .sum();
     }
 
+    private int getRowCount(ExecutionContext executionContext) {
+        return executionContext.getInt("row_count", 0);
+    }
+    
     private int numberOfChunks(JobExecution jobExecution) {
         return jobExecution.getStepExecutions().stream()
                 .map(StepExecution::getExecutionContext)
-                .mapToInt(ec -> ec.getInt("chunk_count"))
+                .mapToInt(this::getChunkCount)
                 .sum();
     }
 
+    private int getChunkCount(ExecutionContext executionContext) {
+        return executionContext.getInt("chunk_count", 0);
+    }
+    
     private long upperCaseRowCount() throws Exception {
         try (SqlSession sqlSession = sqlSessionFactory.openSession()) {
             PersonMapper personMapper = sqlSession.getMapper(PersonMapper.class);