Skip to content

Commit f8bc228

Browse files
committed
Fixed props merging for new names
1 parent e0a4aff commit f8bc228

File tree

2 files changed

+24
-32
lines changed

2 files changed

+24
-32
lines changed

lib/connect.js

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,15 +40,10 @@ function getActions(component, mapActionsToProps) {
4040
function getProps(component) {
4141
var props = {};
4242
var attrs = getAttrs(component);
43-
var stateNames = component.vuaReduxStateNames;
44-
var actionNames = component.vuaReduxActionNames;
43+
var propNames = component.vuaReduxPropNames;
4544

46-
for (var ii = 0; ii < stateNames.length; ii++) {
47-
props[stateNames[ii]] = component[stateNames[ii]];
48-
}
49-
50-
for (var _ii = 0; _ii < actionNames.length; _ii++) {
51-
props[actionNames[_ii]] = component[actionNames[_ii]];
45+
for (var ii = 0; ii < propNames.length; ii++) {
46+
props[propNames[ii]] = component[propNames[ii]];
5247
}
5348

5449
return _extends({}, props, attrs);
@@ -97,12 +92,11 @@ function connect(mapStateToProps, mapActionsToProps, mergeProps) {
9792
data: function data() {
9893
var state = getStates(this, mapStateToProps);
9994
var actions = getActions(this, mapActionsToProps);
100-
var stateNames = Object.keys(state);
101-
var actionNames = Object.keys(actions);
95+
var merged = mergeProps(state, actions);
96+
var propNames = Object.keys(merged);
10297

10398
return _extends({}, mergeProps(state, actions), {
104-
vuaReduxStateNames: stateNames,
105-
vuaReduxActionNames: actionNames
99+
vuaReduxPropNames: propNames
106100
});
107101
},
108102
created: function created() {
@@ -112,11 +106,13 @@ function connect(mapStateToProps, mapActionsToProps, mergeProps) {
112106

113107
this.vuaReduxUnsubscribe = store.subscribe(function () {
114108
var state = getStates(_this, mapStateToProps);
115-
var stateNames = Object.keys(state);
116-
_this.vuaReduxStateNames = stateNames;
109+
var actions = getActions(_this, mapActionsToProps);
110+
var merged = mergeProps(state, actions);
111+
var propNames = Object.keys(merged);
112+
_this.vuaReduxPropNames = propNames;
117113

118-
for (var ii = 0; ii < stateNames.length; ii++) {
119-
_this[stateNames[ii]] = state[stateNames[ii]];
114+
for (var ii = 0; ii < propNames.length; ii++) {
115+
_this[propNames[ii]] = state[propNames[ii]];
120116
}
121117
});
122118
},

src/connect.js

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,10 @@ function getActions(component, mapActionsToProps) {
2727
function getProps(component) {
2828
let props = {};
2929
const attrs = getAttrs(component);
30-
const stateNames = component.vuaReduxStateNames;
31-
const actionNames = component.vuaReduxActionNames;
30+
const propNames = component.vuaReduxPropNames;
3231

33-
for (let ii = 0; ii < stateNames.length; ii++) {
34-
props[stateNames[ii]] = component[stateNames[ii]];
35-
}
36-
37-
for (let ii = 0; ii < actionNames.length; ii++) {
38-
props[actionNames[ii]] = component[actionNames[ii]];
32+
for (let ii = 0; ii < propNames.length; ii++) {
33+
props[propNames[ii]] = component[propNames[ii]];
3934
}
4035

4136
return {
@@ -95,13 +90,12 @@ export default function connect(mapStateToProps, mapActionsToProps, mergeProps)
9590
data() {
9691
const state = getStates(this, mapStateToProps);
9792
const actions = getActions(this, mapActionsToProps);
98-
const stateNames = Object.keys(state);
99-
const actionNames = Object.keys(actions);
93+
const merged = mergeProps(state, actions);
94+
const propNames = Object.keys(merged);
10095

10196
return {
10297
...mergeProps(state, actions),
103-
vuaReduxStateNames: stateNames,
104-
vuaReduxActionNames: actionNames
98+
vuaReduxPropNames: propNames,
10599
};
106100
},
107101

@@ -110,11 +104,13 @@ export default function connect(mapStateToProps, mapActionsToProps, mergeProps)
110104

111105
this.vuaReduxUnsubscribe = store.subscribe(() => {
112106
const state = getStates(this, mapStateToProps);
113-
const stateNames = Object.keys(state);
114-
this.vuaReduxStateNames = stateNames;
107+
const actions = getActions(this, mapActionsToProps);
108+
const merged = mergeProps(state, actions);
109+
const propNames = Object.keys(merged);
110+
this.vuaReduxPropNames = propNames;
115111

116-
for (let ii = 0; ii < stateNames.length; ii++) {
117-
this[stateNames[ii]] = state[stateNames[ii]];
112+
for (let ii = 0; ii < propNames.length; ii++) {
113+
this[propNames[ii]] = state[propNames[ii]];
118114
}
119115
});
120116
},

0 commit comments

Comments
 (0)