Merge pull request #83 from nebarf/refactor/use-http-event

refactor(use-http-event): remove useless unsubscribe ref

Author: nebarf

.eslintrc.json

@@ -36,12 +36,11 @@
     "react/jsx-uses-react": "error",
     "react/jsx-uses-vars": "error",
     "react-hooks/rules-of-hooks": "error", // Check hooks rules
-    // "react-hooks/exhaustive-deps": "warn", // Check hooks deps
     "react-hooks/exhaustive-deps": [
-      "warn",
+      "error",
       {
         "additionalHooks":
-          "(useCompareCallback, useCompareMemo, useCompareEffect, useCompareLayoutEffect)"
+          "(useCompareCallback|useCompareMemo|useCompareEffect|useCompareLayoutEffect)"
       }
     ],
     "camelcase": "warn",

src/client/use-http-client.ts

@@ -80,7 +80,7 @@ export const useHttpClient = (): UseHttpClientReturn => {
        */
       const cachedResponse = cache.get<HttpResponseT, HttpRequestBodyT>(requestInfo);
       if (cachedResponse) {
-        return cachedResponse;
+        return Promise.resolve(cachedResponse);
       }
 
       try {

src/events-manager/types.ts

@@ -8,4 +8,5 @@ export enum HttpEventIdentifier {
 
 export type HttpEventHandler<PayloadT> = (payload: PayloadT) => void;
 
-export type HttpEventClassType<PayloadT> = new (...args: unknown[]) => HttpEvent<PayloadT>;
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export type HttpEventClassType<PayloadT> = new (...args: any[]) => HttpEvent<PayloadT>;

src/events-manager/use-http-event.ts

@@ -1,4 +1,3 @@
-import { useRef, useCallback } from 'react';
 import fastCompare from 'react-fast-compare';
 import { HttpEventClassType, HttpEventHandler } from './types';
 import { useEventBus } from './event-bus-context';
@@ -11,34 +10,12 @@ export const useHttpEvent = <PayloadT>(
   // The event bus.
   const eventBus = useEventBus();
 
-  // A ref to unsubscribe from the event. It helps to avoid
-  // registering the same event handler multiple times.
-  const unsubscribeRef = useRef<() => void>();
-
-  /**
-   * Detach the handler for the event.
-   */
-  const unsubscribe = useCallback(() => {
-    if (unsubscribeRef.current) {
-      unsubscribeRef.current();
-      unsubscribeRef.current = undefined;
-    }
-  }, []);
-
   /**
    * Setup the event handler.
    */
   useCompareLayoutEffect(
-    () => {
-      // Subscribe to the event and keep track of the subscription.
-      unsubscribeRef.current = eventBus.subscribe(eventType, handler);
-
-      // Clean up: unsubscribe the previous event handler.
-      return () => {
-        unsubscribe();
-      };
-    },
-    [eventBus, eventType, handler, unsubscribe],
+    () => eventBus.subscribe(eventType, handler),
+    [eventBus, eventType, handler],
     fastCompare
   );
 };