add condition back and update graph tests

Author: salonichf5

internal/controller/state/conditions/conditions.go

@@ -854,6 +854,25 @@ func NewGatewayInvalid(msg string) []Condition {
 	}
 }
 
+// NewGatewayUnsupportedValue returns Conditions that indicate that a field of the Gateway has an unsupported value.
+// Unsupported means that the value is not supported by the implementation or invalid.
+func NewGatewayUnsupportedValue(msg string) []Condition {
+	return []Condition{
+		{
+			Type:    string(v1.GatewayConditionAccepted),
+			Status:  metav1.ConditionFalse,
+			Reason:  string(GatewayReasonUnsupportedValue),
+			Message: msg,
+		},
+		{
+			Type:    string(v1.GatewayConditionProgrammed),
+			Status:  metav1.ConditionFalse,
+			Reason:  string(GatewayReasonUnsupportedValue),
+			Message: msg,
+		},
+	}
+}
+
 // NewGatewayUnsupportedAddress returns a Condition that indicates the Gateway is not accepted because it
 // contains an address type that is not supported.
 func NewGatewayUnsupportedAddress(msg string) Condition {

internal/controller/state/graph/graph_test.go

@@ -363,6 +363,21 @@ func TestBuildGraph(t *testing.T) {
 		},
 	}
 
+	gatewaySecret := &v1.Secret{
+		TypeMeta: metav1.TypeMeta{
+			Kind: "Secret",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Namespace: testNs,
+			Name:      "gateway-secret",
+		},
+		Data: map[string][]byte{
+			v1.TLSCertKey:       cert,
+			v1.TLSPrivateKeyKey: key,
+		},
+		Type: v1.SecretTypeTLS,
+	}
+
 	ns := &v1.Namespace{
 		ObjectMeta: metav1.ObjectMeta{
 			Name: testNs,
@@ -442,6 +457,13 @@ func TestBuildGraph(t *testing.T) {
 							TLS:      &gatewayv1.GatewayTLSConfig{Mode: helpers.GetPointer(gatewayv1.TLSModePassthrough)},
 						},
 					},
+					BackendTLS: &gatewayv1.GatewayBackendTLS{
+						ClientCertificateRef: &gatewayv1.SecretObjectReference{
+							Kind:      helpers.GetPointer[gatewayv1.Kind]("Secret"),
+							Name:      gatewayv1.ObjectName(gatewaySecret.Name),
+							Namespace: helpers.GetPointer(gatewayv1.Namespace(gatewaySecret.Namespace)),
+						},
+					},
 				},
 			},
 		}
@@ -712,8 +734,9 @@ func TestBuildGraph(t *testing.T) {
 				client.ObjectKeyFromObject(grToServiceNsRefGrant): grToServiceNsRefGrant,
 			},
 			Secrets: map[types.NamespacedName]*v1.Secret{
-				client.ObjectKeyFromObject(secret):     secret,
-				client.ObjectKeyFromObject(plusSecret): plusSecret,
+				client.ObjectKeyFromObject(secret):        secret,
+				client.ObjectKeyFromObject(plusSecret):    plusSecret,
+				client.ObjectKeyFromObject(gatewaySecret): gatewaySecret,
 			},
 			BackendTLSPolicies: map[types.NamespacedName]*v1alpha3.BackendTLSPolicy{
 				client.ObjectKeyFromObject(btp.Source): btp.Source,
@@ -1093,6 +1116,7 @@ func TestBuildGraph(t *testing.T) {
 						Namespace: "test",
 						Name:      "gateway-1-my-class",
 					},
+					SecretRef: helpers.GetPointer(client.ObjectKeyFromObject(gatewaySecret)),
 				},
 				{Namespace: testNs, Name: "gateway-2"}: {
 					Source: gw2.Source,
@@ -1169,6 +1193,7 @@ func TestBuildGraph(t *testing.T) {
 						Namespace: "test",
 						Name:      "gateway-2-my-class",
 					},
+					SecretRef: helpers.GetPointer(client.ObjectKeyFromObject(gatewaySecret)),
 				},
 			},
 			Routes: map[RouteKey]*L7Route{
@@ -1188,6 +1213,13 @@ func TestBuildGraph(t *testing.T) {
 						TLSPrivateKey: key,
 					}),
 				},
+				client.ObjectKeyFromObject(gatewaySecret): {
+					Source: gatewaySecret,
+					CertBundle: NewCertificateBundle(client.ObjectKeyFromObject(gatewaySecret), "Secret", &Certificate{
+						TLSCert:       cert,
+						TLSPrivateKey: key,
+					}),
+				},
 			},
 			ReferencedNamespaces: map[types.NamespacedName]*v1.Namespace{
 				client.ObjectKeyFromObject(ns): ns,
@@ -1277,14 +1309,13 @@ func TestBuildGraph(t *testing.T) {
 		{
 			store:               createStateWithGatewayClass(normalGC),
 			expected:            createExpectedGraphWithGatewayClass(normalGC),
-			experimentalEnabled: false,
+			experimentalEnabled: true,
 			name:                "normal case",
 		},
 		{
-			store:               createStateWithGatewayClass(differentControllerGC),
-			expected:            &Graph{},
-			experimentalEnabled: true,
-			name:                "gatewayclass belongs to a different controller",
+			store:    createStateWithGatewayClass(differentControllerGC),
+			expected: &Graph{},
+			name:     "gatewayclass belongs to a different controller",
 		},
 	}