Do not use mutex lock during init-finalise-registration of mca-sources

Signed-off-by: Kingshuk Haldar <kingshuk.haldar@hlrs.de>

Author: kingshuk00

opal/mca/base/mca_base_source.c

@@ -62,25 +62,19 @@ int mca_base_source_init (void)
 {
     int ret = OPAL_SUCCESS;
 
-    OPAL_THREAD_LOCK(&mca_base_source_lock);
-
     if (false == mca_base_source_initialized) {
         mca_base_source_initialized = true;
 
         OBJ_CONSTRUCT(&registered_sources, opal_pointer_array_t);
         opal_pointer_array_init(&registered_sources, 16, 512, 16);
 
-        OPAL_THREAD_UNLOCK(&mca_base_source_lock);
-
         /* mca_base_source_register will use lock */
         mca_base_source_default_source = mca_base_source_register ("opal", "mca", "base", "default_source",
                                                                    "Default source for MCA events", true,
                                                                    mca_base_source_default_time_source,
                                                                    mca_base_source_default_time_source_ticks ());
 
     }
-    else
-        OPAL_THREAD_UNLOCK(&mca_base_source_lock);
 
     return ret;
 }
@@ -89,7 +83,6 @@ int mca_base_source_finalize (void)
 {
     int i;
 
-    OPAL_THREAD_LOCK(&mca_base_source_lock);
     if (true == mca_base_source_initialized)  {
         for (i = 0 ; i < source_count ; ++i) {
             mca_base_source_t *source = opal_pointer_array_get_item (&registered_sources, i);
@@ -103,7 +96,6 @@ int mca_base_source_finalize (void)
         OBJ_DESTRUCT(&registered_sources);
         mca_base_source_initialized = false;
     }
-    OPAL_THREAD_UNLOCK(&mca_base_source_lock);
 
     return OPAL_SUCCESS;
 }
@@ -188,12 +180,9 @@ int mca_base_source_register (const char *project, const char *framework, const
     char *source_name;
     int ret;
 
-    OPAL_THREAD_LOCK(&mca_base_source_lock);
-
     /* generate the variable's full name */
     ret = mca_base_var_generate_full_name4 (NULL, framework, component, name, &source_name);
     if (OPAL_SUCCESS != ret) {
-        OPAL_THREAD_UNLOCK(&mca_base_source_lock);
         return ret;
     }
 
@@ -204,7 +193,6 @@ int mca_base_source_register (const char *project, const char *framework, const
         /* create a new parameter entry */
         source = OBJ_NEW(mca_base_source_t);
         if (NULL == source) {
-            OPAL_THREAD_UNLOCK(&mca_base_source_lock);
             return OPAL_ERR_OUT_OF_RESOURCE;
         }
 
@@ -231,7 +219,6 @@ int mca_base_source_register (const char *project, const char *framework, const
 
         if (OPAL_SUCCESS != ret) {
             OBJ_RELEASE(source);
-            OPAL_THREAD_UNLOCK(&mca_base_source_lock);
             return ret;
         }
     } else {
@@ -247,8 +234,6 @@ int mca_base_source_register (const char *project, const char *framework, const
     source->source_time = source_time;
     source->source_ticks = source_ticks;
 
-    OPAL_THREAD_UNLOCK(&mca_base_source_lock);
-
     return OPAL_SUCCESS;
 }
 int mca_base_component_source_register (const mca_base_component_t *component, const char *name, const char *description, bool ordered,