semconv for http server span names

Author: krnr

instrumentation/opentelemetry-instrumentation-aiohttp-server/src/opentelemetry/instrumentation/aiohttp_server/__init__.py

@@ -244,12 +244,12 @@ def get_default_span_name(request: web.Request) -> str:
     Returns:
         The span name.
     """
-    span_name = request.path.strip() or f"HTTP {request.method}"
+    path = request.path.strip()
     if request.match_info and request.match_info.route.resource:
         resource = request.match_info.route.resource
         if resource.canonical:
-            span_name = resource.canonical
-    return span_name
+            path = resource.canonical
+    return f"{request.method} {path}"
 
 
 def _get_view_func(request: web.Request) -> str:

instrumentation/opentelemetry-instrumentation-aiohttp-server/tests/test_aiohttp_server_integration.py

@@ -181,17 +181,17 @@ async def test_status_code_instrumentation(
 
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
-    "url, example_paths",
+    "span_name, example_paths",
     [
         (
-            "/test-path/{url_param}",
+            "GET /test-path/{url_param}",
             (
                 "/test-path/foo",
                 "/test-path/bar",
             ),
         ),
         (
-            "/object/{object_id}/action/{another_param}",
+            "GET /object/{object_id}/action/{another_param}",
             (
                 "/object/1/action/bar",
                 "/object/234/action/baz",
@@ -203,7 +203,7 @@ async def test_url_params_instrumentation(
     tracer,
     server_fixture,
     aiohttp_client,
-    url,
+    span_name,
     example_paths,
 ):
     _, memory_exporter = tracer
@@ -220,7 +220,7 @@ async def test_url_params_instrumentation(
     for request_path, span in zip(
         example_paths, memory_exporter.get_finished_spans()
     ):
-        assert url == span.name
+        assert span_name == span.name
         assert request_path == span.attributes[HTTP_TARGET]
         full_url = f"http://{server.host}:{server.port}{request_path}"
         assert full_url == span.attributes[HTTP_URL]