Skip to content

Commit 4acd343

Browse files
committed
fix(tests): prevent null exception in ConnectionFailed event assertions
1 parent 698b828 commit 4acd343

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

tests/Http/HandlerTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,9 @@ public function __invoke(RequestInterface $request, array $config)
196196

197197
// Assert Laravel events
198198
Event::assertDispatched(ConnectionFailed::class, function ($event) {
199-
return $event->exception->getMessage() === 'Connection failed';
199+
return isset($event->exception)
200+
&& $event->exception instanceof \Throwable
201+
&& $event->exception->getMessage() === 'Connection failed';
200202
});
201203
Event::assertDispatched(RequestSending::class);
202204
Event::assertNotDispatched(ResponseReceived::class);

tests/Http/HttpEventTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@
3535
} catch (\GuzzleHttp\Exception\ConnectException $e) {
3636
// expected
3737
}
38-
3938
Event::assertDispatched(ConnectionFailed::class, function ($event) {
40-
return $event->exception->getMessage() === 'Connection failed';
39+
return isset($event->exception)
40+
&& $event->exception instanceof \Throwable
41+
&& $event->exception->getMessage() === 'Connection failed';
4142
});
4243
Event::assertNotDispatched(RequestSending::class);
4344
Event::assertNotDispatched(ResponseReceived::class);

0 commit comments

Comments
 (0)