further simplifying

Author: shawkins

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/TemporaryResourceCache.java

@@ -87,39 +87,19 @@ public synchronized void putAddedResource(T newResource) {
   public synchronized void putResource(T newResource, String previousResourceVersion) {
     var resourceId = ResourceID.fromResource(newResource);
 
-    var cachedResource = managedInformerEventSource.get(resourceId).orElse(null);
-
-    boolean moveAhead = false;
     String latest = managedInformerEventSource.getLastSyncResourceVersion(resourceId.getNamespace()).orElse(null);
-    if (latest != null && latest > newResource.getMetadata().getResourceVersion()) {
+    if (latest != null && latest >= newResource.getMetadata().getResourceVersion()) {
       log.debug(
-          "Won't move backwards for {}: resourceVersion {}, latest {}",
+          "Resource {}: resourceVersion {} is not later than latest {}",
           resourceId,
           newResource.getMetadata().getResourceVersion(),
           latest);
-      return;
-    }
-      
-    if (previousResourceVersion == null && cachedResource == null) {
-      // we can skip further checks as this is a simple add and there's no previous entry to
-      // consider
-      moveAhead = true;
-    }
-
-    if (moveAhead
-        || (cachedResource != null
-                && (cachedResource
-                    .getMetadata()
-                    .getResourceVersion()
-                    .equals(previousResourceVersion))
-            || isLaterResourceVersion(resourceId, newResource, cachedResource))) {
+    } else {
       log.debug(
           "Temporarily moving ahead to target version {} for resource id: {}",
           newResource.getMetadata().getResourceVersion(),
           resourceId);
       cache.put(resourceId, newResource);
-    } else if (cache.remove(resourceId) != null) {
-      log.debug("Removed an obsolete resource from cache for id: {}", resourceId);
     }
   }