refactor: remove getName method from ResourceController

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ResourceController.java

@@ -1,7 +1,6 @@
 package io.javaoperatorsdk.operator.api;
 
 import io.fabric8.kubernetes.client.CustomResource;
-import io.javaoperatorsdk.operator.ControllerUtils;
 import io.javaoperatorsdk.operator.processing.event.EventSourceManager;
 
 public interface ResourceController<R extends CustomResource> {
@@ -38,8 +37,4 @@ public interface ResourceController<R extends CustomResource> {
    * @param eventSourceManager
    */
   default void init(EventSourceManager eventSourceManager) {}
-
-  default String getName() {
-    return ControllerUtils.getNameFor(this);
-  }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/AbstractConfigurationService.java

@@ -1,6 +1,7 @@
 package io.javaoperatorsdk.operator.api.config;
 
 import io.fabric8.kubernetes.client.CustomResource;
+import io.javaoperatorsdk.operator.ControllerUtils;
 import io.javaoperatorsdk.operator.api.ResourceController;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -27,6 +28,6 @@ protected <R extends CustomResource> void register(ControllerConfiguration<R> co
   @Override
   public <R extends CustomResource> ControllerConfiguration<R> getConfigurationFor(
       ResourceController<R> controller) {
-    return configurations.get(controller.getName());
+    return configurations.get(ControllerUtils.getNameFor(controller));
   }
 }

operator-framework-spring-boot-starter/src/main/java/io/javaoperatorsdk/operator/springboot/starter/OperatorAutoConfiguration.java

@@ -6,6 +6,7 @@
 import io.fabric8.kubernetes.client.DefaultKubernetesClient;
 import io.fabric8.kubernetes.client.KubernetesClient;
 import io.fabric8.openshift.client.DefaultOpenShiftClient;
+import io.javaoperatorsdk.operator.ControllerUtils;
 import io.javaoperatorsdk.operator.Operator;
 import io.javaoperatorsdk.operator.api.ResourceController;
 import io.javaoperatorsdk.operator.api.config.AbstractConfigurationService;
@@ -56,7 +57,7 @@ public Operator operator(
 
   private ResourceController<?> processController(ResourceController<?> controller) {
     final var controllerPropertiesMap = configuration.getControllers();
-    final var name = controller.getName();
+    final var name = ControllerUtils.getNameFor(controller);
     var controllerProps = controllerPropertiesMap.get(name);
     register(new ConfigurationWrapper(controller, controllerProps));
     return controller;

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/AnnotationConfiguration.java

@@ -21,7 +21,7 @@ public AnnotationConfiguration(ResourceController<R> controller) {
 
   @Override
   public String getName() {
-    return controller.getName();
+    return ControllerUtils.getNameFor(controller);
   }
 
   @Override