[Bug fix] Report generator script for PII operator (#1149)

Author: VipulMascarenhas

ads/dataset/recommendation.py

@@ -1,15 +1,14 @@
 #!/usr/bin/env python
-# -*- coding: utf-8; -*-
 
-# Copyright (c) 2020, 2022 Oracle and/or its affiliates.
+# Copyright (c) 2020, 2025 Oracle and/or its affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 
 import copy
 import importlib
 
 from ads.common.decorator.runtime_dependency import (
-    runtime_dependency,
     OptionalDependency,
+    runtime_dependency,
 )
 from ads.dataset import logger
 
@@ -59,11 +58,10 @@ def on_action_change(change):
             if change["type"] == "change" and change["name"] == "value":
                 if change["new"] == "Fill missing values with constant":
                     self._show_constant_fill_widget(column)
-                else:
-                    if change["old"] == "Fill missing values with constant":
-                        text = self.fill_nan_dict.pop(column, None)
-                        if text is not None:
-                            text.close()
+                elif change["old"] == "Fill missing values with constant":
+                    text = self.fill_nan_dict.pop(column, None)
+                    if text is not None:
+                        text.close()
                 self.reco_dict[recommendation_type][column]["Selected Action"] = change[
                     "new"
                 ]
@@ -151,7 +149,6 @@ def show_in_notebook(self):
     @runtime_dependency(module="IPython", install_from=OptionalDependency.NOTEBOOK)
     @runtime_dependency(module="ipywidgets", install_from=OptionalDependency.NOTEBOOK)
     def _display(self):
-
         from IPython.core.display import display
 
         if self.recommendation_type_index != len(self.recommendation_types):
@@ -164,11 +161,7 @@ def _display(self):
                 ]
                 if self.recommendation_type_index == 0:
                     for column in recommendation:
-                        print(
-                            "Column '{0}' is constant and will be dropped".format(
-                                column
-                            )
-                        )
+                        print(f"Column '{column}' is constant and will be dropped")
                     self.recommendation_type_index += 1
                     self._display()
                     return
@@ -184,17 +177,17 @@ def _display(self):
                                     self.recommendation_type_labels[
                                         self.recommendation_type_index
                                     ]
-                                )
+                                ),
+                                layout=ipywidgets.Layout(display="flex"),
                             ),
-                            layout=ipywidgets.Layout(display="flex"),
                         )
                         self.action_list[
                             self.recommendation_types[self.recommendation_type_index]
                         ] = []
                         self.column_list = []
                         self.message_list = []
                         self.extra_info_list = []
-                        for column in recommendation.keys():
+                        for column in recommendation:
                             messages = ipywidgets.Label(
                                 recommendation[column]["Message"],
                                 layout=ipywidgets.Layout(
@@ -240,9 +233,7 @@ def _display(self):
                             self.column_list.append(
                                 ipywidgets.Label(
                                     column
-                                    + "(type: {0})".format(
-                                        self.ds.sampled_df[column].dtype
-                                    ),
+                                    + f"(type: {self.ds.sampled_df[column].dtype})",
                                     layout=ipywidgets.Layout(flex="auto"),
                                     color="grey",
                                 )

ads/opctl/operator/lowcode/pii/model/report.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python
 
-# Copyright (c) 2023, 2024 Oracle and/or its affiliates.
+# Copyright (c) 2023, 2025 Oracle and/or its affiliates.
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/
 
 
@@ -123,7 +123,6 @@ def make_model_card(model_name="", readme_path=""):
         )
         return rc.Group(
             rc.Text("-"),
-            columns=1,
         )
 
     try:
@@ -156,7 +155,6 @@ def make_model_card(model_name="", readme_path=""):
     return rc.Group(
         rc.Text(text),
         eval_res_tb,
-        columns=2,
     )
 
 
@@ -216,7 +214,7 @@ def build_entity_df(entites, id) -> pd.DataFrame:
             "Type": "-",
             "Redacted To": "-",
         }
-        df = df.append(df2, ignore_index=True)
+        df = pd.concat([df, pd.DataFrame([df2])], ignore_index=True)
     return df
 
 
@@ -232,7 +230,6 @@ def build_report(self) -> rc.Group:
                     self._make_stats_card(),
                     self._make_text_card(),
                 ],
-                type=rc.SelectType.TABS,
             ),
             label="Row Id: " + str(self.spec.id),
         )
@@ -256,7 +253,7 @@ def _make_stats_card(self):
                     index=True,
                 )
             )
-        return rc.Group(stats, label="STATS")
+        return rc.Group(*stats, label="STATS")
 
     def _make_text_card(self):
         annotations = []
@@ -277,7 +274,7 @@ def _make_text_card(self):
             },
             return_html=True,
         )
-        return rc.Group(rc.HTML(render_html), label="TEXT")
+        return rc.Group(rc.Html(render_html), label="TEXT")
 
 
 class PIIOperatorReport:
@@ -292,7 +289,7 @@ def __init__(self, report_spec: PiiReportSpec, report_uri: str):
             RowReportFields(r, report_spec.run_summary.show_sensitive_info)
             for r in rows
         ]
-
+        self.report_sections = None
         self.report_uri = report_uri
 
     def make_view(self):
@@ -317,7 +314,6 @@ def make_view(self):
                         label="Details",
                     ),
                 ],
-                type=rc.SelectType.TABS,
             )
         )
         self.report_sections = [title_text, report_description, time_proceed, structure]
@@ -331,7 +327,8 @@ def save_report(
             disable_print()
             with rc.ReportCreator("My Report") as report:
                 report.save(
-                    rc.Block(report_sections or self.report_sections), report_local_path
+                    rc.Block(*(report_sections or self.report_sections)),
+                    report_local_path,
                 )
             enable_print()
 
@@ -354,7 +351,6 @@ def _build_summary_page(self):
                     self._make_yaml_card(),
                     self._make_model_card(),
                 ],
-                type=rc.SelectType.TABS,
             ),
         )
 
@@ -367,7 +363,6 @@ def _build_details_page(self):
                 blocks=[
                     row.build_report() for row in self.rows_details
                 ],  # RowReportFields
-                type=rc.SelectType.DROPDOWN,
                 label="Details",
             ),
         )
@@ -414,7 +409,6 @@ def _make_summary_stats_card(self) -> rc.Group:
                         self.report_spec.run_summary.elapsed_time
                     ),
                 ),
-                columns=2,
             ),
             rc.Heading("Entities Distribution", level=3),
             plot_pie(self.report_spec.run_summary.statics),
@@ -423,7 +417,7 @@ def _make_summary_stats_card(self) -> rc.Group:
             entites_df = self._build_total_entity_df()
             summary_stats.append(rc.Heading("Resolved Entities", level=3))
             summary_stats.append(rc.DataTable(entites_df, index=True))
-        return rc.Group(summary_stats, label="STATS")
+        return rc.Group(*summary_stats, label="STATS")
 
     def _make_yaml_card(self) -> rc.Group:
         """Shows the full pii config yaml."""
@@ -449,13 +443,12 @@ def _make_model_card(self) -> rc.Group:
 
         if len(model_cards) <= 1:
             return rc.Group(
-                model_cards,
+                *model_cards,
                 label="MODEL CARD",
             )
         return rc.Group(
             rc.Select(
                 model_cards,
-                type=rc.SelectType.TABS,
             ),
             label="MODEL CARD",
         )