Merge pull request #1 from php-istio/fix/auto-add-authenticator-when-not-config

vuongxuongminh · web-flow · commit 1182ffc5392a · 2021-06-29T00:20:16.000+07:00
Fix auto add authenticator when not config
diff --git a/src/DependencyInjection/Security/AuthenticatorFactory.php b/src/DependencyInjection/Security/AuthenticatorFactory.php
@@ -61,7 +61,6 @@ public function getKey()
     public function addConfiguration(NodeDefinition $builder)
     {
         $builder
-            ->cannotBeEmpty()
             ->fixXmlConfig('origin_token_header')
             ->fixXmlConfig('origin_token_query_param')
             ->fixXmlConfig('base64_header')
diff --git a/tests/Unit/DepdendencyInjection/Security/AuthenticatorFactoryTest.php b/tests/Unit/DepdendencyInjection/Security/AuthenticatorFactoryTest.php
@@ -138,9 +138,6 @@ public function validConfigurations(): array
     public function invalidConfigurations(): array
     {
         return [
-            [
-                [],
-            ],
             [
                 [
                     ['issuer' => ''],

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ public function getKey()`
`61`	`61`	`public function addConfiguration(NodeDefinition $builder)`
`62`	`62`	`{`
`63`	`63`	`$builder`
`64`		`- ->cannotBeEmpty()`
`65`	`64`	`->fixXmlConfig('origin_token_header')`
`66`	`65`	`->fixXmlConfig('origin_token_query_param')`
`67`	`66`	`->fixXmlConfig('base64_header')`
Original file line number	Diff line number	Diff line change
`@@ -138,9 +138,6 @@ public function validConfigurations(): array`
`138`	`138`	`public function invalidConfigurations(): array`
`139`	`139`	`{`
`140`	`140`	`return [`
`141`		`- [`
`142`		`- [],`
`143`		`- ],`
`144`	`141`	`[`
`145`	`142`	`[`
`146`	`143`	`['issuer' => ''],`