Introduce phpstan-deprecation-rules

Author: staabm

composer.json

@@ -14,6 +14,7 @@
 	},
 	"require-dev": {
 		"php-parallel-lint/php-parallel-lint": "^1.2",
+		"phpstan/phpstan-deprecation-rules": "^2.0",
 		"phpstan/phpstan-strict-rules": "^2.0",
 		"phpunit/phpunit": "^9.6"
 	},

phpstan.neon

@@ -2,6 +2,7 @@ includes:
 	- extension.neon
 	- rules.neon
 	- vendor/phpstan/phpstan-strict-rules/rules.neon
+	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
 	- phar://phpstan.phar/conf/bleedingEdge.neon
 	- phpstan-baseline.neon
 

src/Rules/PHPUnit/ClassCoversExistsRule.php

@@ -50,7 +50,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $node->getClassReflection();
 
-		if (!$classReflection->isSubclassOf(TestCase::class)) {
+		if (!$classReflection->is(TestCase::class)) {
 			return [];
 		}
 

src/Rules/PHPUnit/ClassMethodCoversExistsRule.php

@@ -56,7 +56,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$classReflection->isSubclassOf(TestCase::class)) {
+		if (!$classReflection->is(TestCase::class)) {
 			return [];
 		}
 

src/Rules/PHPUnit/DataProviderDeclarationRule.php

@@ -52,7 +52,7 @@ public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
 
-		if ($classReflection === null || !$classReflection->isSubclassOf(TestCase::class)) {
+		if ($classReflection === null || !$classReflection->is(TestCase::class)) {
 			return [];
 		}
 

src/Rules/PHPUnit/DataProviderHelper.php

@@ -76,7 +76,7 @@ public function getDataProviderMethods(
 				}
 
 				$dataProviderMethod = $this->parseDataProviderAnnotationValue($scope, $dataProviderValue);
-				$dataProviderMethod[] = $node->getLine();
+				$dataProviderMethod[] = $node->getStartLine();
 
 				yield $dataProviderValue => $dataProviderMethod;
 			}
@@ -257,7 +257,7 @@ private function parseDataProviderExternalAttribute(Attribute $attribute): ?arra
 			sprintf('%s::%s', $className, $methodNameArg->value) => [
 				$dataProviderClassReflection,
 				$methodNameArg->value,
-				$attribute->getLine(),
+				$attribute->getStartLine(),
 			],
 		];
 	}
@@ -279,7 +279,7 @@ private function parseDataProviderAttribute(Attribute $attribute, ClassReflectio
 			$methodNameArg->value => [
 				$classReflection,
 				$methodNameArg->value,
-				$attribute->getLine(),
+				$attribute->getStartLine(),
 			],
 		];
 	}

src/Rules/PHPUnit/NoMissingSpaceInClassAnnotationRule.php

@@ -33,7 +33,7 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
-		if ($classReflection === null || $classReflection->isSubclassOf(TestCase::class) === false) {
+		if ($classReflection === null || $classReflection->is(TestCase::class) === false) {
 			return [];
 		}
 

src/Rules/PHPUnit/NoMissingSpaceInMethodAnnotationRule.php

@@ -33,7 +33,7 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$classReflection = $scope->getClassReflection();
-		if ($classReflection === null || $classReflection->isSubclassOf(TestCase::class) === false) {
+		if ($classReflection === null || $classReflection->is(TestCase::class) === false) {
 			return [];
 		}
 

src/Rules/PHPUnit/ShouldCallParentMethodsRule.php

@@ -33,7 +33,7 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
-		if (!$scope->getClassReflection()->isSubclassOf(TestCase::class)) {
+		if (!$scope->getClassReflection()->is(TestCase::class)) {
 			return [];
 		}