Make AssertEqualsIsDiscouragedRule auto-fixable

Author: ondrejmirtes

src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php

@@ -60,14 +60,27 @@ public function processNode(Node $node, Scope $scope): array
 			&& ($leftType->isSuperTypeOf($rightType)->yes())
 			&& ($rightType->isSuperTypeOf($leftType)->yes())
 		) {
+			$correctName = strtolower($node->name->name) === 'assertnotequals' ? 'assertNotSame' : 'assertSame';
 			return [
 				RuleErrorBuilder::message(
 					sprintf(
 						'You should use %s() instead of %s(), because both values are scalars of the same type',
-						strtolower($node->name->name) === 'assertnotequals' ? 'assertNotSame' : 'assertSame',
+						$correctName,
 						$node->name->name,
 					),
-				)->identifier('phpunit.assertEquals')->build(),
+				)->identifier('phpunit.assertEquals')
+					->fixNode($node, static function (CallLike $node) use ($correctName) {
+						if ($node instanceof Node\Expr\MethodCall) {
+							$node->name = new Node\Identifier($correctName);
+						}
+
+						if ($node instanceof Node\Expr\StaticCall) {
+							$node->name = new Node\Identifier($correctName);
+						}
+
+						return $node;
+					})
+					->build(),
 			];
 		}
 

tests/Rules/PHPUnit/AssertEqualsIsDiscouragedRuleTest.php

@@ -34,6 +34,11 @@ public function testRule(): void
 		]);
 	}
 
+	public function testFix(): void
+	{
+		$this->fix(__DIR__ . '/data/assert-equals-is-discouraged-fixable.php', __DIR__ . '/data/assert-equals-is-discouraged-fixable.php.fixed');
+	}
+
 	protected function getRule(): Rule
 	{
 		return new AssertEqualsIsDiscouragedRule();

tests/Rules/PHPUnit/data/assert-equals-is-discouraged-fixable.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SameAssertEqualsTestFix;
+
+use PHPUnit\Framework\TestCase;
+
+class Foo extends TestCase
+{
+
+	public function doFoo(string $s, string $t): void
+	{
+		$this->assertEquals('', $s);
+		$this->assertNotEquals('', $t);
+	}
+
+	public function doFoo2(string $s, string $t): void
+	{
+		self::assertEquals('', $s);
+		self::assertNotEquals('', $t);
+	}
+
+}

tests/Rules/PHPUnit/data/assert-equals-is-discouraged-fixable.php.fixed

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace SameAssertEqualsTestFix;
+
+use PHPUnit\Framework\TestCase;
+
+class Foo extends TestCase
+{
+
+	public function doFoo(string $s, string $t): void
+	{
+		$this->assertSame('', $s);
+		$this->assertNotSame('', $t);
+	}
+
+	public function doFoo2(string $s, string $t): void
+	{
+		self::assertSame('', $s);
+		self::assertNotSame('', $t);
+	}
+
+}