Assert*Rules: Do cheap checks first (#247)

Author: staabm

src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php

@@ -27,24 +27,27 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+		if (!$node instanceof Node\Expr\MethodCall && ! $node instanceof Node\Expr\StaticCall) {
 			return [];
 		}
-
-		if ($node->isFirstClassCallable()) {
+		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-
-		if (count($node->getArgs()) < 2) {
+		if ($node->isFirstClassCallable()) {
 			return [];
 		}
+
 		if (
 			!$node->name instanceof Node\Identifier
 			|| !in_array(strtolower($node->name->name), ['assertequals', 'assertnotequals'], true)
 		) {
 			return [];
 		}
 
+		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+			return [];
+		}
+
 		$leftType = TypeCombinator::removeNull($scope->getType($node->getArgs()[0]->value));
 		$rightType = TypeCombinator::removeNull($scope->getType($node->getArgs()[1]->value));
 

src/Rules/PHPUnit/AssertRuleHelper.php

@@ -11,9 +11,6 @@
 class AssertRuleHelper
 {
 
-	/**
-	 * @phpstan-assert-if-true Node\Expr\MethodCall|Node\Expr\StaticCall $node
-	 */
 	public static function isMethodOrStaticCallOnAssert(Node $node, Scope $scope): bool
 	{
 		if ($node instanceof Node\Expr\MethodCall) {

src/Rules/PHPUnit/AssertSameBooleanExpectedRule.php

@@ -23,15 +23,13 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+		if (!$node instanceof Node\Expr\MethodCall && ! $node instanceof Node\Expr\StaticCall) {
 			return [];
 		}
-
-		if ($node->isFirstClassCallable()) {
+		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-
-		if (count($node->getArgs()) < 2) {
+		if ($node->isFirstClassCallable()) {
 			return [];
 		}
 		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
@@ -43,6 +41,10 @@ public function processNode(Node $node, Scope $scope): array
 			return [];
 		}
 
+		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+			return [];
+		}
+
 		if ($expectedArgumentValue->name->toLowerString() === 'true') {
 			return [
 				RuleErrorBuilder::message('You should use assertTrue() instead of assertSame() when expecting "true"')->identifier('phpunit.assertTrue')->build(),

src/Rules/PHPUnit/AssertSameNullExpectedRule.php

@@ -23,21 +23,23 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+		if (!$node instanceof Node\Expr\MethodCall && ! $node instanceof Node\Expr\StaticCall) {
 			return [];
 		}
-
-		if ($node->isFirstClassCallable()) {
+		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-
-		if (count($node->getArgs()) < 2) {
+		if ($node->isFirstClassCallable()) {
 			return [];
 		}
 		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
 
+		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+			return [];
+		}
+
 		$expectedArgumentValue = $node->getArgs()[0]->value;
 		if (!($expectedArgumentValue instanceof ConstFetch)) {
 			return [];

src/Rules/PHPUnit/AssertSameWithCountRule.php

@@ -24,23 +24,24 @@ public function getNodeType(): string
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
+		if (!$node instanceof Node\Expr\MethodCall && ! $node instanceof Node\Expr\StaticCall) {
+			return [];
+		}
+		if (count($node->getArgs()) < 2) {
 			return [];
 		}
-
 		if ($node->isFirstClassCallable()) {
 			return [];
 		}
-
-		if (count($node->getArgs()) < 2) {
+		if (!$node->name instanceof Node\Identifier	|| $node->name->toLowerString() !== 'assertsame') {
 			return [];
 		}
-		if (!$node->name instanceof Node\Identifier || $node->name->toLowerString() !== 'assertsame') {
+
+		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
 			return [];
 		}
 
 		$right = $node->getArgs()[1]->value;
-
 		if (
 			$right instanceof Node\Expr\FuncCall
 			&& $right->name instanceof Node\Name