test limits

Author: staabm

src/Analyser/TypeSpecifier.php

@@ -93,6 +93,8 @@
 final class TypeSpecifier
 {
 
+	private const MAX_ACCESSORIES_LIMIT = 8;
+
 	/** @var MethodTypeSpecifyingExtension[][]|null */
 	private ?array $methodTypeSpecifyingExtensionsByClass = null;
 
@@ -1203,12 +1205,19 @@ private function specifyTypesForCountFuncCall(
 					$intersection[] = new NonEmptyArrayType();
 
 					$zero = new ConstantIntegerType(0);
+					$i = 0;
 					foreach ($builderData as [$offsetType, $valueType]) {
 						// non-empty-list already implies the offset 0
 						if ($zero->isSuperTypeOf($offsetType)->yes()) {
 							continue;
 						}
+
+						if ($i > self::MAX_ACCESSORIES_LIMIT) {
+							break;
+						}
+
 						$intersection[] = new HasOffsetValueType($offsetType, $valueType);
+						$i++;
 					}
 
 					$resultTypes[] = TypeCombinator::intersect(...$intersection);

tests/PHPStan/Analyser/nsrt/bug-13747.php

@@ -51,4 +51,27 @@ public function doBar($list): void
 			assertType('1', count($list));
 		}
 	}
+
+	/** @param list<int> $list */
+	public function checkLimit($list): void
+	{
+		if (count($list) === 0) {
+			return;
+		}
+
+		if (count($list) > 9) {
+			assertType('non-empty-list<int>&hasOffsetValue(1, int)&hasOffsetValue(2, int)&hasOffsetValue(3, int)&hasOffsetValue(4, int)&hasOffsetValue(5, int)&hasOffsetValue(6, int)&hasOffsetValue(7, int)&hasOffsetValue(8, int)&hasOffsetValue(9, int)', $list);
+			assertType('int<10, max>', count($list));
+		} else {
+			assertType('non-empty-list<int>', $list);
+		}
+
+		if (count($list) > 10) {
+			assertType('non-empty-list<int>&hasOffsetValue(1, int)&hasOffsetValue(2, int)&hasOffsetValue(3, int)&hasOffsetValue(4, int)&hasOffsetValue(5, int)&hasOffsetValue(6, int)&hasOffsetValue(7, int)&hasOffsetValue(8, int)&hasOffsetValue(9, int)', $list);
+			assertType('int<11, max>', count($list));
+		} else {
+			assertType('non-empty-list<int>', $list);
+		}
+
+	}
 }