Rework

Author: VincentLanglet

src/Reflection/InitializerExprTypeResolver.php

@@ -91,6 +91,7 @@
 use function max;
 use function min;
 use function sprintf;
+use function str_starts_with;
 use function strtolower;
 use const INF;
 
@@ -506,9 +507,9 @@ public function resolveConcatType(Type $left, Type $right): Type
 
 		$leftNumericStringNonEmpty = TypeCombinator::remove($leftStringType, new ConstantStringType(''));
 		if ($leftNumericStringNonEmpty->isNumericString()->yes()) {
-			$allowedRightPattern = $left->isInteger()->yes()
-				? '#^(\d+|\d+.\d+)([eE][+-]?\d+)?$#' // non-negative integer, float or scientific string
-				: '#^\d+$#'; // non-negative integer string
+			$validationCallback = $left->isInteger()->yes()
+				? static fn (string $value): bool => !str_starts_with($value, '-')
+				: static fn (string $value): bool => Strings::match($value, '#^\d+$#') !== null;
 
 			$allRightConstantsZeroOrMore = false;
 			foreach ($rightConstantStrings as $rightConstantString) {
@@ -518,7 +519,7 @@ public function resolveConcatType(Type $left, Type $right): Type
 
 				if (
 					!is_numeric($rightConstantString->getValue())
-					|| Strings::match($rightConstantString->getValue(), $allowedRightPattern) === null
+					|| !$validationCallback($rightConstantString->getValue())
 				) {
 					$allRightConstantsZeroOrMore = false;
 					break;