Fix strtr inferences

Author: VincentLanglet

src/Type/Php/ReplaceFunctionsDynamicReturnTypeExtension.php

@@ -98,6 +98,12 @@ private function getPreliminarilyResolvedTypeFromFunctionCall(
 				if ($replaceArgumentType->isArray()->yes()) {
 					$replaceArgumentType = $replaceArgumentType->getIterableValueType();
 				}
+			} elseif ($functionReflection->getName() === 'strtr' && isset($functionCall->getArgs()[1])) {
+				// `strtr` has two signatures: `strtr($string1, $string2, $string3)` and `strtr($string1, $array)`
+				$secondArgumentType = $scope->getType($functionCall->getArgs()[1]->value);
+				if ($secondArgumentType->isArray()->yes()) {
+					$replaceArgumentType = $secondArgumentType->getIterableValueType();
+				}
 			}
 		}
 

tests/PHPStan/Rules/Methods/CallMethodsRuleTest.php

@@ -3656,6 +3656,16 @@ public function testBug5642(): void
 		]);
 	}
 
+	public function testBug13708(): void
+	{
+		$this->checkThisOnly = false;
+		$this->checkNullables = false;
+		$this->checkUnionTypes = true;
+		$this->checkExplicitMixed = false;
+
+		$this->analyse([__DIR__ . '/data/bug-13708.php'], []);
+	}
+
 	public function testBug3396(): void
 	{
 		$this->checkThisOnly = false;

tests/PHPStan/Rules/Methods/data/bug-13708.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace Bug13708;
+
+class HelloWorld
+{
+	/**
+	 * @param non-empty-string $s
+	 */
+	public function takeNonEmpty(string $s): void
+	{
+		return;
+	}
+
+	public function doStuff(): void
+	{
+		$this->takeNonEmpty(
+			strtr('change {me}', ['{me}' => 'me'])
+		);
+	}
+}