feat: enable reading githubActions from fs

Author: dominykas

lib/github-actions/index.js

@@ -2,12 +2,54 @@
 
 const Nv = require('@pkgjs/nv');
 
+
+const internals = {};
+
+
+internals.parseActionsSetupNode = function * (workflow) {
+
+    for (const job of Object.values(workflow.jobs)) {
+
+        const nodeSteps = job.steps.filter(({ uses }) => uses && uses.startsWith('actions/setup-node'));
+        for (const step of nodeSteps) {
+            const nodeVersion = step.with && step.with['node-version'];
+
+            if (!nodeVersion) {
+                // Docs say: "The node-version input is optional. If not supplied, the node version that is PATH will be used."
+                // Therefore we cannot reliably detect a specific version, but we do want to let the user know
+                yield 'not-set';
+                continue;
+            }
+
+            const matrixMatch = nodeVersion.match(/^\${{\s+matrix.(?<matrixVarName>.*)\s+}}$/);
+            if (matrixMatch) {
+                const matrix = job.strategy.matrix[matrixMatch.groups.matrixVarName];
+
+                yield * matrix;
+                continue;
+            }
+
+            const envMatch = nodeVersion.match(/^\${{\s+env.(?<envVarName>.*)\s+}}$/);
+            if (envMatch) {
+                const envValue = workflow.env[envMatch.groups.envVarName];
+
+                yield envValue;
+                continue;
+            }
+
+            yield nodeVersion;
+        }
+    }
+};
+
+
 exports.detect = async (meta) => {
 
     const files = await meta.loadFolder('.github/workflows');
     const rawSet = new Set();
 
     if (!files.length) {
+        // explicitly return no `githubActions` - this is different to finding actions and detecting no Node.js versions
         return;
     }
 
@@ -19,37 +61,8 @@ exports.detect = async (meta) => {
 
         const workflow = await meta.loadFile(`.github/workflows/${file}`, { yaml: true });
 
-        for (const job of Object.values(workflow.jobs)) {
-
-            const nodeSteps = job.steps.filter(({ uses }) => uses && uses.startsWith('actions/setup-node'));
-            for (const step of nodeSteps) {
-                const nodeVersion = step.with && step.with['node-version'];
-
-                if (!nodeVersion) {
-                    // @todo - no node version defined - use default? what is the default?
-                    continue;
-                }
-
-                const matrixMatch = nodeVersion.match(/^\${{\s+matrix.(?<matrixVarName>.*)\s+}}$/);
-                if (matrixMatch) {
-                    const matrix = job.strategy.matrix[matrixMatch.groups.matrixVarName];
-
-                    for (const version of matrix) {
-                        rawSet.add(version);
-                    }
-
-                    continue;
-                }
-
-                const envMatch = nodeVersion.match(/^\${{\s+env.(?<envVarName>.*)\s+}}$/);
-                if (envMatch) {
-                    rawSet.add(workflow.env[envMatch.groups.envVarName]);
-
-                    continue;
-                }
-
-                rawSet.add(nodeVersion);
-            }
+        for (const version of internals.parseActionsSetupNode(workflow)) {
+            rawSet.add(version);
         }
     }
 

lib/loader/path.js

@@ -25,10 +25,9 @@ exports.create = async (path) => {
 
             return simpleGit.revparse(['HEAD']);
         },
-        loadFolder: () => {
+        loadFolder: (path) => {
 
-            // @todo
-            return [];
+            return Fs.readdirSync(path);
         },
         loadFile: (filename, options = {}) => {