Merge pull request #6429 from plotly/fix6407-line-redraw

Fix line redraw

Author: archmoj

draftlogs/6429_fix.md

@@ -0,0 +1 @@
+ - Fix line redraw (regression introduced in 2.15.0) [[#6429](https://github.com/plotly/plotly.js/pull/6429)]

src/traces/scatter/plot.js

@@ -248,7 +248,7 @@ function plotOne(gd, idx, plotinfo, cdscatter, cdscatterAll, element, transition
                     revpath = thisrevpath + 'Z' + revpath;
                 }
 
-                if(subTypes.hasLines(trace) && pts.length > 1) {
+                if(subTypes.hasLines(trace)) {
                     var el = d3.select(this);
 
                     // This makes the coloring work correctly:

test/jasmine/tests/scatter_test.js

@@ -1035,6 +1035,27 @@ describe('end-to-end scatter tests', function() {
         .then(done, done.fail);
     });
 
+    it('updates line segments on redraw when having null values', function(done) {
+        function checkSegments(exp, msg) {
+            var lineSelection = d3Select(gd).selectAll('.scatterlayer .js-line');
+            expect(lineSelection.size()).toBe(exp, msg);
+        }
+
+        Plotly.newPlot(gd, [{
+            y: [1, null, 2, 3],
+            mode: 'lines+markers'
+        }])
+        .then(function() {
+            checkSegments(2, 'inital');
+
+            return Plotly.relayout(gd, 'xaxis.range', [0, 10]);
+        })
+        .then(function() {
+            checkSegments(2, 'after redraw');
+        })
+        .then(done, done.fail);
+    });
+
     it('correctly autoranges fill tonext traces across multiple subplots', function(done) {
         Plotly.newPlot(gd, [
             {y: [3, 4, 5], fill: 'tonexty'},