Merge pull request #204 from plotly/circle-pyenv

Circle pyenv

Author: theengineear

circle.yml

@@ -7,14 +7,20 @@ machine:
     PLOTLY_OPTIONAL_REQUIREMENTS_FILE: ${PLOTLY_PACKAGE_ROOT}/optional-requirements.txt
     PLOTLY_OPTIONAL_REQUIREMENTS_FILE_2_6: ${PLOTLY_PACKAGE_ROOT}/optional-requirements-2-6.txt
 dependencies:
-  pre:
+  override:
+
     # run all the pre-written installers (this will take a *while*)
     - bash circle/setup.sh
+
     # install testing tools for circle's version of things
-    - PYENV_VERSION=2.7 && pip install nose coverage
-  override:
-    - PYENV_VERSION=2.7 && pip install -I .
-    - PYENV_VERSION=2.7 && cd ~ && python -c "import plotly"
+    - pip install nose coverage
+    - pip install -I .
+
+    # we need to cd out of the project root to ensure the install worked
+    - cd ~ && python -c "import plotly"
+
+  cache_directories:
+    - "~/.pyenv/versions"  # attempt to just cache installed pyenv things
 test:
   override:
 
@@ -28,6 +34,6 @@ test:
 #    - sudo chmod 600 ${PLOTLY_CONFIG_DIR} && python -c "import plotly"
 
     # test core things in the general 2.7 version that circle has
-    - PYENV_VERSION=2.7 && nosetests -xv plotly/tests --with-coverage --cover-package=plotly
+    - nosetests -xv plotly/tests --with-coverage --cover-package=plotly
     - mkdir "${CIRCLE_ARTIFACTS}/2.7" || true
     - coverage html -d "${CIRCLE_ARTIFACTS}/2.7" --title=2.7

circle/setup.sh

@@ -12,6 +12,10 @@ function error_exit
     exit 1
 }
 
+# PYENV shims need to be infront of the rest of the path to work!
+echo "adding pyenv shims to the beginning of the path in this shell"
+export PATH="/home/ubuntu/.pyenv/shims:$PATH"
+
 # for each version we want, setup a functional virtual environment
 for version in ${PLOTLY_PYTHON_VERSIONS[@]}; do
     echo Setting up Python ${version}
@@ -20,6 +24,11 @@ for version in ${PLOTLY_PYTHON_VERSIONS[@]}; do
     export PYENV_VERSION=${version}
     echo "Using pyenv version $(pyenv version)"
 
+    # this was a major issue previously, sanity check that we're using the
+    # version we *think* we're using (that pyenv is pointing to)
+    echo "python -c 'import sys; print(sys.version)'"
+    python -c 'import sys; print(sys.version)'
+
     # install core requirements all versions need
     pip install -r ${PLOTLY_CORE_REQUIREMENTS_FILE} ||
         error_exit "${LINENO}: can't install core reqs for Python ${version}"

circle/test.sh

@@ -12,6 +12,10 @@ function error_exit
     exit 1
 }
 
+# PYENV shims need to be infront of the rest of the path to work!
+echo "adding pyenv shims to the beginning of the path in this shell"
+export PATH="/home/ubuntu/.pyenv/shims:$PATH"
+
 # for each version we want, setup a functional virtual environment
 for version in ${PLOTLY_PYTHON_VERSIONS[@]}; do
     echo Testing Python ${version}
@@ -20,6 +24,12 @@ for version in ${PLOTLY_PYTHON_VERSIONS[@]}; do
     export PYENV_VERSION=${version}
     echo "Using pyenv version $(pyenv version)"
 
+    # this was a major issue previously, sanity check that we're using the
+    # version we *think* we're using (that pyenv is pointing to)
+    echo "python -c 'import sys; print(sys.version)'"
+    python -c 'import sys; print(sys.version)'
+
+
     echo "install plotly (ignoring possibly cached versions)"
     pip install -I ${PLOTLY_PACKAGE_ROOT} ||
         error_exit "${LINENO}: can't install plotly package from project root"

plotly/exceptions.py

@@ -15,9 +15,14 @@
 
 
 """
-import json
+import sys
 import six
 
+if sys.version[:3] == '2.6':
+    import simplejson as json
+else:
+    import json
+
 ## Base Plotly Error ##
 
 class PlotlyError(Exception):
@@ -49,7 +54,10 @@ def __init__(self, requests_exception):
         elif content_type == 'text/plain':
             self.message = requests_exception.response.content
         else:
-            self.message = requests_exception.message
+            try:
+                self.message = requests_exception.message
+            except AttributeError:
+                self.message = 'unknown error'
 
     def __str__(self):
         return self.message

plotly/grid_objs/grid_objs.py

@@ -5,12 +5,16 @@
 """
 from __future__ import absolute_import
 
-
-import json
+import sys
 from collections import MutableSequence
 from plotly import exceptions
 from plotly import utils
 
+if sys.version[:3] == '2.6':
+    import simplejson as json
+else:
+    import json
+
 __all__ = None
 
 

plotly/plotly/plotly.py

@@ -17,7 +17,6 @@
 from __future__ import absolute_import
 
 import sys
-import json
 import warnings
 import copy
 import os
@@ -30,6 +29,11 @@
 else:
     from urllib.parse import urlparse
 
+if sys.version[:3] == '2.6':
+    import simplejson as json
+else:
+    import json
+
 from plotly.plotly import chunked_requests
 from plotly import utils
 from plotly import tools

plotly/tests/test_core/test_get_figure/test_get_figure.py

@@ -10,10 +10,10 @@
 from plotly import exceptions
 from nose.tools import raises
 import six
-import json
 
 from unittest import TestCase
-from unittest import skipIf
+
+version = six.sys.version_info[:2]  # need this for conditional testing
 
 
 # username for tests: 'plotlyimagetest'
@@ -198,12 +198,18 @@ def test_all():
 
 class TestBytesVStrings(TestCase):
 
-    @skipIf(not six.PY3, 'Decoding and missing escapes is only seen in PY3')
-    def test_proper_escaping(self):
-        un = 'PlotlyImageTest'
-        ak = '786r5mecv0'
-        url = "https://plot.ly/~PlotlyImageTest/91/"
-        py.sign_in(un, ak)
-        print("getting: https://plot.ly/~PlotlyImageTest/91/")
-        print("###########################################\n\n")
-        fig = py.get_figure(url)
+    # unittest `skipIf` not supported in 2.6
+    if version < (2, 7) or (2, 7) < version < (3, 3):
+        pass
+    else:
+        from unittest import skipIf
+
+        @skipIf(not six.PY3, 'Decoding and missing escapes only seen in PY3')
+        def test_proper_escaping(self):
+            un = 'PlotlyImageTest'
+            ak = '786r5mecv0'
+            url = "https://plot.ly/~PlotlyImageTest/91/"
+            py.sign_in(un, ak)
+            print("getting: https://plot.ly/~PlotlyImageTest/91/")
+            print("###########################################\n\n")
+            fig = py.get_figure(url)

plotly/tests/test_core/test_get_requests/test_get_requests.py

@@ -8,8 +8,13 @@
 
 import requests
 import copy
-import json
 import six
+import sys
+
+if sys.version[:3] == '2.6':
+    import simplejson as json
+else:
+    import json
 
 default_headers = {'plotly-username': '',
                    'plotly-apikey': '',

plotly/tests/test_core/test_utils/test_utils.py

@@ -1,8 +1,13 @@
-import json
+import sys
 from unittest import TestCase
 
 from plotly.utils import PlotlyJSONEncoder
 
+if sys.version[:3] == '2.6':
+    import simplejson as json
+else:
+    import json
+
 
 class TestJSONEncoder(TestCase):
 

plotly/tests/test_optional/test_ipython/test_embed.py

@@ -5,13 +5,14 @@
 import threading
 import six
 import unittest
-from unittest import skip
 version = six.sys.version_info[:2]  # need this for conditional testing
 
 # unittest `skipIf` not supported in 2.6 and IPython not supported in 2.6/3.2
 if version < (2, 7) or (2, 7) < version < (3, 3):
     pass
 else:
+    from unittest import skip
+
     @skip
     class TestPlotlyDisplay(unittest.TestCase):