Merge branch 'update-go-1-23' into 'master'

chore: update Go, golangci-lint and deps

See merge request postgres-ai/database-lab!917

Author: agneum

engine/.gitlab-ci.yml

@@ -1,5 +1,5 @@
 default:
-  image: golang:1.20
+  image: golang:1.23
 
 stages:
   - test
@@ -56,7 +56,7 @@ lint:
 ### Build binary.
 build-binary-alpine:
   <<: *only_engine
-  image: golang:1.20-alpine
+  image: golang:1.23-alpine
   stage: build-binary
   artifacts:
     paths:

engine/.golangci.yml

@@ -2,10 +2,9 @@ run:
   timeout: 2m
   issues-exit-code: 1
   tests: true
-  skip-dirs:
-    - vendor
 output:
-  format: colored-line-number
+  formats:
+   - format: colored-line-number
   print-issued-lines: true
   print-linter-name: true
 
@@ -22,10 +21,8 @@ linters-settings:
   gofmt:
     simplify: true
   gofumpt:
-    lang-version: "1.17"
     extra-rules: false
   gosimple:
-    go: "1.18"
     checks: [ "all" ]
   goimports:
     local-prefixes: gitlab.com/postgres-ai/database-lab
@@ -37,14 +34,17 @@ linters-settings:
   lll:
     line-length: 140
     tab-width: 1
-  gomnd:
-    settings:
-      mnd:
-        ignored-functions: strconv.Format*,os.*,strconv.Parse*,strings.SplitN,bytes.SplitN
+  mnd:
+    ignored-functions:
+      - strconv.Format*
+      - os.*
+      - strconv.Parse*
+      - strings.SplitN
+      - bytes.SplitN
   revive:
-    min-confidence: 0.8
+    confidence: 0.8
   unused:
-    check-exported: false
+    exported-fields-are-used: false
   unparam:
     check-exported: false
   nakedret:
@@ -72,15 +72,15 @@ linters:
     - goconst
     - gocritic
     - goimports
-    - gomnd
     - gosimple
     - govet
     - ineffassign
     - lll
-    - megacheck
     - misspell
+    - mnd
     - prealloc
     - revive
+    - staticcheck
     - stylecheck
     - unconvert
     - unused
@@ -90,9 +90,8 @@ linters:
   disable:
     - depguard
     - gosec
-    - interfacer
     - gocyclo # currently unmaintained
-  presets:
+  #presets:
   fast: false
 
 issues:
@@ -104,7 +103,9 @@ issues:
         - lll
         - errcheck
         - wsl
-        - gomnd
+        - mnd
+  exclude-dirs:
+    - vendor
 
   exclude-use-default: false
   max-issues-per-linter: 0

engine/Dockerfile.dblab-server-debug

@@ -1,7 +1,7 @@
 # How to start a container: https://postgres.ai/docs/how-to-guides/administration/engine-manage
 
 # Compile stage
-FROM golang:1.18 AS build-env
+FROM golang:1.23 AS build-env
 
 # Build Delve
 RUN go install github.com/go-delve/delve/cmd/dlv@latest

engine/Makefile

@@ -34,7 +34,7 @@ help: ## Display the help message
 all: clean build ## Build all binary components of the project
 
 install-lint: ## Install the linter to $GOPATH/bin which is expected to be in $PATH
-	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.53.3
+	curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.61.0
 
 run-lint: ## Run linters
 	golangci-lint run

engine/cmd/cli/main.go

@@ -24,7 +24,7 @@ func main() {
 	app := &cli.App{
 		Version: version.GetVersion(),
 		CommandNotFound: func(c *cli.Context, command string) {
-			fmt.Fprintf(c.App.Writer, "[ERROR] Command %q not found.\n", command)
+			_, _ = fmt.Fprintf(c.App.Writer, "[ERROR] Command %q not found.\n", command)
 		},
 		Before: loadEnvironmentParams,
 		Commands: joinCommands(

engine/go.mod

@@ -1,14 +1,14 @@
 module gitlab.com/postgres-ai/database-lab/v3
 
-go 1.20
+go 1.23
 
 require (
 	github.com/AlekSi/pointer v1.2.0
 	github.com/ahmetalpbalkan/dlog v0.0.0-20170105205344-4fb5f8204f26
 	github.com/araddon/dateparse v0.0.0-20210429162001-6b43995a97de
 	github.com/aws/aws-sdk-go v1.44.309
-	github.com/docker/cli v24.0.9+incompatible
-	github.com/docker/docker v24.0.9+incompatible
+	github.com/docker/cli v25.0.6+incompatible
+	github.com/docker/docker v25.0.6+incompatible
 	github.com/docker/go-connections v0.4.0
 	github.com/docker/go-units v0.5.0
 	github.com/dustin/go-humanize v1.0.1
@@ -27,7 +27,7 @@ require (
 	github.com/sergi/go-diff v1.3.1
 	github.com/sethvargo/go-password v0.2.0
 	github.com/shirou/gopsutil v3.21.11+incompatible
-	github.com/stretchr/testify v1.8.2
+	github.com/stretchr/testify v1.9.0
 	github.com/testcontainers/testcontainers-go v0.12.0
 	github.com/urfave/cli/v2 v2.25.7
 	github.com/wagslane/go-password-validator v0.3.0
@@ -43,9 +43,14 @@ require (
 	github.com/Microsoft/go-winio v0.6.1 // indirect
 	github.com/cenkalti/backoff v2.2.1+incompatible // indirect
 	github.com/containerd/containerd v1.7.2 // indirect
+	github.com/containerd/log v0.1.0 // indirect
 	github.com/cpuguy83/go-md2man/v2 v2.0.2 // indirect
+	github.com/cyphar/filepath-securejoin v0.2.4 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/docker/distribution v2.8.2+incompatible // indirect
+	github.com/distribution/reference v0.6.0 // indirect
+	github.com/felixge/httpsnoop v1.0.4 // indirect
+	github.com/go-logr/logr v1.4.2 // indirect
+	github.com/go-logr/stdr v1.2.2 // indirect
 	github.com/go-ole/go-ole v1.2.6 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/golang/protobuf v1.5.3 // indirect
@@ -58,26 +63,37 @@ require (
 	github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a // indirect
 	github.com/jmespath/go-jmespath v0.4.0 // indirect
 	github.com/klauspost/compress v1.16.7 // indirect
+	github.com/kr/pretty v0.3.1 // indirect
 	github.com/magiconair/properties v1.8.5 // indirect
 	github.com/moby/patternmatcher v0.5.0 // indirect
 	github.com/moby/sys/sequential v0.5.0 // indirect
+	github.com/moby/sys/user v0.3.0 // indirect
 	github.com/moby/term v0.5.0 // indirect
 	github.com/morikuni/aec v1.0.0 // indirect
 	github.com/opencontainers/go-digest v1.0.0 // indirect
 	github.com/opencontainers/image-spec v1.1.0-rc4 // indirect
-	github.com/opencontainers/runc v1.1.12 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
+	github.com/rogpeppe/go-internal v1.10.0 // indirect
 	github.com/russross/blackfriday/v2 v2.1.0 // indirect
 	github.com/sirupsen/logrus v1.9.3 // indirect
-	github.com/stretchr/objx v0.5.0 // indirect
+	github.com/stretchr/objx v0.5.2 // indirect
 	github.com/tklauser/go-sysconf v0.3.11 // indirect
 	github.com/tklauser/numcpus v0.6.1 // indirect
 	github.com/xrash/smetrics v0.0.0-20201216005158-039620a65673 // indirect
 	github.com/yusufpapurcu/wmi v1.2.3 // indirect
+	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.55.0 // indirect
+	go.opentelemetry.io/otel v1.30.0 // indirect
+	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.18.0 // indirect
+	go.opentelemetry.io/otel/metric v1.30.0 // indirect
+	go.opentelemetry.io/otel/sdk v1.18.0 // indirect
+	go.opentelemetry.io/otel/trace v1.30.0 // indirect
 	golang.org/x/net v0.17.0 // indirect
 	golang.org/x/sys v0.13.0 // indirect
 	golang.org/x/text v0.13.0 // indirect
 	golang.org/x/tools v0.11.0 // indirect
 	google.golang.org/appengine v1.6.7 // indirect
+	google.golang.org/genproto/googleapis/api v0.0.0-20230711160842-782d3b101e98 // indirect
+	google.golang.org/genproto/googleapis/rpc v0.0.0-20230711160842-782d3b101e98 // indirect
 	google.golang.org/protobuf v1.31.0 // indirect
+	gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c // indirect
 )