Update deps, rm custom browser option (#17)

- Remove customBrowser option; it wasn't used anyway
- Upgrade Puppeteer to v2.0.0
- Update devDependencies
- Start testing on Node 12 too

BREAKING CHANGES

Author: bartveneman

.travis.yml

@@ -2,3 +2,4 @@ language: node_js
 node_js:
   - '8'
   - '10'
+  - '12'

package-lock.json

@@ -1,41 +1,38 @@
 {
-  "name": "extract-css-core",
-  "description": "Extract all CSS from a given url, both server side and client side rendered.",
-  "version": "1.1.0",
-  "homepage": "https://www.projectwallace.com/oss",
-  "repository": "https://github.com/bartveneman/extract-css-core",
-  "issues": "https://github.com/bartveneman/extract-css-core/issues",
-  "license": "MIT",
-  "author": "Bart Veneman",
-  "keywords": [
-    "extract",
-    "css",
-    "scrape",
-    "get-css",
-    "css"
-  ],
-  "scripts": {
-    "test": "eslint ./src ./test && ava"
-  },
-  "files": [
-    "src"
-  ],
-  "main": "src/index.js",
-  "engines": {
-    "node": ">=8.0"
-  },
-  "devDependencies": {
-    "@bartveneman/eslint-config-bv": "0.0.2",
-    "ava": "^2.1.0",
-    "chromium": "^2.1.0",
-    "create-test-server": "^3.0.1",
-    "eslint": "^6.3.0",
-    "puppeteer-core": "^1.18.1"
-  },
-  "dependencies": {
-    "puppeteer": "^1.18.1"
-  },
-  "eslintConfig": {
-    "extends": "@bartveneman/eslint-config-bv"
-  }
+	"name": "extract-css-core",
+	"description": "Extract all CSS from a given url, both server side and client side rendered.",
+	"version": "1.1.0",
+	"homepage": "https://www.projectwallace.com/oss",
+	"repository": "https://github.com/bartveneman/extract-css-core",
+	"issues": "https://github.com/bartveneman/extract-css-core/issues",
+	"license": "MIT",
+	"author": "Bart Veneman",
+	"keywords": [
+		"extract",
+		"css",
+		"scrape",
+		"get-css"
+	],
+	"scripts": {
+		"test": "eslint ./src ./test && ava"
+	},
+	"files": [
+		"src"
+	],
+	"main": "src/index.js",
+	"engines": {
+		"node": ">=8.0"
+	},
+	"devDependencies": {
+		"@bartveneman/eslint-config-bv": "0.0.2",
+		"ava": "^2.4.0",
+		"create-test-server": "^3.0.1",
+		"eslint": "^6.7.2"
+	},
+	"dependencies": {
+		"puppeteer": "^2.0.0"
+	},
+	"eslintConfig": {
+		"extends": "@bartveneman/eslint-config-bv"
+	}
 }

package.json

@@ -19,7 +19,7 @@
 Existing packages like
 [get-css](https://github.com/cssstats/cssstats/tree/master/packages/get-css)
 look at a server-generated piece of HTML and get all the `<link>` and `<style>`
-tags from it. This works fine for 100% server rendered pages, and pages with 
+tags from it. This works fine for 100% server rendered pages, and pages with
 CSS-in-JS styling.
 
 ### Solution
@@ -68,21 +68,8 @@ Default: `networkidle2`
 Can be any value as provided by the
 [Puppeteer docs](https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#pagegotourl-options).
 
-#### customBrowser
-
-Type: `Browser`
-
-Default: `null`
-
-A
-[Puppeteer Browser](https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#class-browser)
-instance. See the `test` directory for implementation examples. This option
-exists primarily for use with
-[extract-css](https://github.com/bartveneman/extract-css)
-
 ## Related
 
-- [extract-css](https://github.com/bartveneman/extract-css) - Extract CSS
-  running as a serverless function
+- [Wallace CLI](https://github.com/bartveneman/wallace-cli) - Pretty CSS analytics in your terminal
 - [get-css](https://github.com/cssstats/cssstats/tree/master/packages/get-css) -
   The original get-css

readme.md

@@ -7,21 +7,9 @@ function InvalidUrlError({url, statusCode, statusText}) {
 
 InvalidUrlError.prototype = Error.prototype
 
-module.exports = async (
-	url,
-	{waitUntil = 'networkidle2', customBrowser = null} = {}
-) => {
-	if (
-		customBrowser !== null &&
-		(!customBrowser.isConnected || !customBrowser.isConnected())
-	) {
-		return Promise.reject(
-			new TypeError('The `customBrowser` option is invalid')
-		)
-	}
-
+module.exports = async (url, {waitUntil = 'networkidle2'} = {}) => {
 	// Setup a browser instance
-	const browser = customBrowser || (await puppeteer.launch())
+	const browser = await puppeteer.launch()
 
 	// Create a new page and navigate to it
 	const page = await browser.newPage()

src/index.js

@@ -2,8 +2,6 @@ const test = require('ava')
 const createTestServer = require('create-test-server')
 const {readFileSync} = require('fs')
 const {resolve} = require('path')
-const chromium = require('chromium')
-const puppeteerCore = require('puppeteer-core')
 
 const extractCss = require('..')
 
@@ -137,29 +135,3 @@ test('it rejects if the url has an HTTP error status', async t => {
 test('it rejects on an invalid url', async t => {
 	await t.throwsAsync(extractCss('site.example'))
 })
-
-test('it accepts a browser override for usage with other browsers', async t => {
-	const path = '/browser-override'
-	server.get(path, (req, res) => {
-		res.send(`
-		<!doctype html>
-		<style>
-			body::before { content: "${req.headers['user-agent']}"; }
-		</style>
-	`)
-	})
-	const customBrowser = await puppeteerCore.launch({
-		executablePath: chromium.path,
-		args: ['--user-agent=Extract CSS Core']
-	})
-	const actual = await extractCss(server.url + path, {customBrowser})
-
-	t.is(actual, 'body::before { content: "Extract CSS Core"; }')
-})
-
-test('it rejects on an invalid customBrowser option', async t => {
-	const path = '/browser-override'
-	await t.throwsAsync(extractCss(server.url + path, {customBrowser: {}}), {
-		message: 'The `customBrowser` option is invalid'
-	})
-})