Cleanup imports in graph/rewriting/basic.py

Author: ricardoV94

pytensor/graph/rewriting/basic.py

@@ -13,9 +13,8 @@
 from collections.abc import Callable, Iterable, Sequence
 from functools import _compose_mro, partial  # type: ignore
 from itertools import chain
-from typing import TYPE_CHECKING, Literal
+from typing import Literal
 
-import pytensor
 from pytensor.configdefaults import config
 from pytensor.graph import destroyhandler as dh
 from pytensor.graph.basic import (
@@ -30,15 +29,12 @@
 from pytensor.graph.features import AlreadyThere, Feature
 from pytensor.graph.fg import FunctionGraph, Output
 from pytensor.graph.op import Op
+from pytensor.graph.rewriting.unify import Var, convert_strs_to_vars
 from pytensor.graph.utils import AssocList, InconsistencyError
 from pytensor.misc.ordered_set import OrderedSet
 from pytensor.utils import flatten
 
 
-if TYPE_CHECKING:
-    from pytensor.graph.rewriting.unify import Var
-
-
 _logger = logging.getLogger("pytensor.graph.rewriting.basic")
 
 RemoveKeyType = Literal["remove"]
@@ -59,14 +55,6 @@
 ]
 
 
-class MetaNodeRewriterSkip(AssertionError):
-    """This is an `AssertionError`, but instead of having the
-    `MetaNodeRewriter` print the error, it just skip that
-    compilation.
-
-    """
-
-
 class Rewriter(abc.ABC):
     """Abstract base class for graph/term rewriters."""
 
@@ -1414,8 +1402,6 @@ def __init__(
         frequent `Op`, which will prevent the rewrite from being tried as often.
 
         """
-        from pytensor.graph.rewriting.unify import convert_strs_to_vars
-
         var_map: dict[str, Var] = {}
         self.in_pattern = convert_strs_to_vars(in_pattern, var_map=var_map)
         self.out_pattern = convert_strs_to_vars(out_pattern, var_map=var_map)
@@ -1457,9 +1443,6 @@ def transform(self, fgraph, node, get_nodes=True):
                 if ret is not False and ret is not None:
                     return dict(zip(real_node.outputs, ret, strict=True))
 
-        if node.op != self.op:
-            return False
-
         if len(node.outputs) != 1:
             # PatternNodeRewriter doesn't support replacing multi-output nodes
             return False
@@ -1488,11 +1471,13 @@ def transform(self, fgraph, node, get_nodes=True):
 
         [old_out] = node.outputs
         if not old_out.type.is_super(ret.type):
+            from pytensor.tensor.type import TensorType
+
             # Type doesn't match
             if not (
                 self.allow_cast
-                and isinstance(old_out.type, pytensor.tensor.TensorType)
-                and isinstance(ret.type, pytensor.tensor.TensorType)
+                and isinstance(old_out.type, TensorType)
+                and isinstance(ret.type, TensorType)
             ):
                 return False
 
@@ -2744,10 +2729,10 @@ def check_stack_trace(f_or_fgraph, ops_to_check="last", bug_print="raise"):
         otherwise.
 
     """
-    if isinstance(f_or_fgraph, pytensor.compile.function.types.Function):
-        fgraph = f_or_fgraph.maker.fgraph
-    elif isinstance(f_or_fgraph, pytensor.graph.fg.FunctionGraph):
+    if isinstance(f_or_fgraph, FunctionGraph):
         fgraph = f_or_fgraph
+    elif hasattr(f_or_fgraph, "fgraph"):
+        fgraph = f_or_fgraph.fgraph
     else:
         raise ValueError("The type of f_or_fgraph is not supported")