Skip to content

Commit 68f19c1

Browse files
authored
disposable pattern implemented for main object, version bump and readme
1 parent 78b2da7 commit 68f19c1

File tree

6 files changed

+21
-9
lines changed

6 files changed

+21
-9
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,4 +360,4 @@ MigrationBackup/
360360

361361
# Fody - auto-generated XML schema
362362
FodyWeavers.xsd
363-
/src/QAToolKit.Core.Test/global.json
363+
/src/QAToolKit.Engine.HttpTester.Test/global.json

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<Project>
22
<PropertyGroup>
3-
<Version>0.3.0</Version>
3+
<Version>0.1.0</Version>
44
</PropertyGroup>
55
</Project>

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# QAToolKit Engine HttpTester library
2-
![https://github.com/qatoolkit/qatoolkit-engine-httptester-net/actions](https://github.com/qatoolkit/qatoolkit-engine-httptester-net/workflows/.NET%20Core/badge.svg?branch=main)
2+
![https://github.com/qatoolkit/qatoolkit-engine-httptester-net/actions](![Build .NET Library](https://github.com/qatoolkit/qatoolkit-engine-httptester-net/workflows/Build%20.NET%20Library/badge.svg))
33
![https://github.com/qatoolkit/qatoolkit-engine-httptester-net/security/code-scanning](https://github.com/qatoolkit/qatoolkit-engine-httptester-net/workflows/CodeQL%20Analyze/badge.svg)
44
![https://sonarcloud.io/dashboard?id=qatoolkit_qatoolkit-engine-httptester-net](https://github.com/qatoolkit/qatoolkit-engine-httptester-net/workflows/Sonarqube%20Analyze/badge.svg)
55
![https://www.nuget.org/packages/QAToolKit.Engine.HttpTester/](https://img.shields.io/nuget/v/QAToolKit.Engine.HttpTester?label=QAToolKit.Engine.HttpTester)

src/QAToolKit.Engine.HttpTester.Test/global.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/QAToolKit.Engine.HttpTester/HttpTesterClient.cs

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,26 @@ public async Task<HttpResponseMessage> Start()
170170
/// Dispose the object
171171
/// </summary>
172172
public void Dispose()
173+
{
174+
Dispose(true);
175+
GC.SuppressFinalize(this);
176+
}
177+
178+
/// <summary>
179+
/// Dispose object
180+
/// </summary>
181+
/// <param name="disposing"></param>
182+
protected virtual void Dispose(bool disposing)
173183
{
174184
HttpClient?.Dispose();
175185
}
186+
187+
/// <summary>
188+
/// Destructor
189+
/// </summary>
190+
~HttpTesterClient()
191+
{
192+
Dispose(false);
193+
}
176194
}
177195
}

src/QAToolKit.Engine.HttpTester/QAToolKit.Engine.HttpTester.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
<RepositoryUrl>https://github.com/qatoolkit/qatoolkit-core-net</RepositoryUrl>
2222
<PackageTags>qatoolkit-core-net;.net;c#;f#;dotnet;netstandard;net5</PackageTags>
2323
<Configurations>Debug;Release;Debug With Project References</Configurations>
24-
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
2524
</PropertyGroup>
2625

2726
<PropertyGroup>

0 commit comments

Comments
 (0)