Asserter has new methods ResponseStatusCodeIsSuccess and ResponseBodyIsEmpty, small updates

Author: mihaj

Directory.Build.props

@@ -1,5 +1,5 @@
 <Project>
   <PropertyGroup>
-    <Version>0.2.8</Version>
+    <Version>0.2.9</Version>
   </PropertyGroup>
 </Project>

README.md

@@ -173,7 +173,15 @@ Currently `HttpTesterClient` supports:
 
 ### HttpTestAsserter
 
-This is an implementation of the HTTP response message asserter, which can be used to assert different paramters.
+This is an implementation of the HTTP response message asserter, which can be used to assert different parameters.
+
+Here is a list of Asserters:
+- `ResponseContentContains`: HTTP body contains a string (ignores case)
+- `RequestDurationEquals`: Verify request duration
+- `ResponseStatusCodeEquals`: Verify if response code equals
+- `ResponseHasHttpHeader`: HTTP response contains a header
+- `ResponseStatusCodeIsSuccess`: HTTP response status code is one of 2xx
+- `ResponseBodyIsEmpty`: HTTP response body is empty
 
 Asserter produces a list of `AssertResult`:
 
@@ -220,6 +228,7 @@ using (var client = new HttpTesterClient())
         .ResponseContentContains("scott")
         .RequestDurationEquals(duration, (x) => x < 1000)
         .ResponseStatusCodeEquals(HttpStatusCode.OK)
+        .ResponseStatusCodeIsSuccess()
         .AssertAll();
 
     //if you use xUnit, you can assert the results like this
@@ -232,7 +241,9 @@ using (var client = new HttpTesterClient())
 
 ## To-do
 
-- **This library is an early alpha version**
+- **This library is a beta version**
+- Add more Http Asserters
+- Cover more test cases with HTTP Tester client
 
 ## License
 

src/QAToolKit.Engine.HttpTester.Test/HttpTestAsserterTests.cs

@@ -33,6 +33,7 @@ public async Task HttpTestAsserterSimple_Success()
                     .ResponseContentContains("scott")
                     .RequestDurationEquals(duration, (x) => x < 1000)
                     .ResponseStatusCodeEquals(HttpStatusCode.OK)
+                    .ResponseHasHttpHeader("Date")
                     .AssertAll();
 
                 foreach (var result in assertResults)
@@ -168,9 +169,38 @@ public async Task HttpTestAsserterAlternativeDurationPredicate_Success()
                     .ResponseContentContains("id")
                     .RequestDurationEquals(duration, (x) => (x > 100 && x < 1000))
                     .ResponseStatusCodeEquals(HttpStatusCode.OK)
+                    .ResponseStatusCodeIsSuccess()
                     .AssertAll();
 
-                Assert.Equal(4, assertResults.ToList().Count);
+                Assert.Equal(5, assertResults.ToList().Count);
+                foreach (var result in assertResults)
+                {
+                    Assert.True(result.IsTrue, result.Message);
+                }
+            }
+        }
+
+        [Fact]
+        public async Task HttpTestAsserterDeleteIsBodyEmpty_Success()
+        {
+            using (var client = new HttpTesterClient())
+            {
+                var response = await client
+                 .CreateHttpRequest(new Uri("https://qatoolkitapi.azurewebsites.net"))
+                 .WithQueryParams(new Dictionary<string, string>() { { "api-version", "1" } })
+                 .WithMethod(HttpMethod.Delete)
+                 .WithPath("/api/bicycles/1")
+                 .Start();
+
+                var asserter = new HttpTestAsserter(response);
+                var duration = client.Duration;
+                var assertResults = asserter
+                    .ResponseBodyIsEmpty()
+                    .RequestDurationEquals(duration, (x) => (x > 100 && x < 1000))
+                    .ResponseStatusCodeIsSuccess()
+                    .AssertAll();
+
+                Assert.Equal(3, assertResults.ToList().Count);
                 foreach (var result in assertResults)
                 {
                     Assert.True(result.IsTrue, result.Message);

src/QAToolKit.Engine.HttpTester.Test/HttpTesterClientTests.cs

@@ -567,7 +567,7 @@ public async Task HttpTesterClientAddPostHttpRequest_Success()
             });
 
             var requests = await urlSource.Load(new Uri[] {
-                new Uri("https://qatoolkitapi.azurewebsites.net/swagger/v1/swagger.json")
+                new Uri("https://qatoolkitapi.azurewebsites.net/swagger/v2/swagger.json")
             });
 
             using (var client = new HttpTesterClient())
@@ -599,7 +599,7 @@ public async Task HttpTesterClientAddGetHttpRequest_Success()
             });
 
             var requests = await urlSource.Load(new Uri[] {
-                new Uri("https://qatoolkitapi.azurewebsites.net/swagger/v1/swagger.json")
+                new Uri("https://qatoolkitapi.azurewebsites.net/swagger/v2/swagger.json")
             });
 
             using (var client = new HttpTesterClient())

src/QAToolKit.Engine.HttpTester.Test/QAToolKit.Engine.HttpTester.Test.csproj

@@ -13,8 +13,8 @@
     </PackageReference>
     <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="5.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.0" />
-    <PackageReference Include="QAToolKit.Source.Swagger" Version="0.3.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
+    <PackageReference Include="QAToolKit.Source.Swagger" Version="0.3.9" />
 	<PackageReference Include="ExpectedObjects" Version="2.3.6" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">

src/QAToolKit.Engine.HttpTester/HttpTestAsserter.cs

@@ -3,6 +3,7 @@
 using QAToolKit.Engine.HttpTester.Models;
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using System.Net;
 using System.Net.Http;
 
@@ -95,8 +96,8 @@ public IHttpTestAsserter ResponseHasHttpHeader(string headerName)
             {
                 Name = nameof(ResponseHasHttpHeader),
                 Message = $"Contains header '{headerName}'.",
-                IsTrue = _httpResponseMessage.Headers.Contains(headerName)
-            });
+                IsTrue = _httpResponseMessage.Headers.TryGetValues(headerName, out var values)
+        });
 
             return this;
         }
@@ -117,5 +118,39 @@ public IHttpTestAsserter ResponseStatusCodeEquals(HttpStatusCode httpStatusCode)
 
             return this;
         }
+
+        /// <summary>
+        /// HTTP response status code is one of 2xx
+        /// </summary>
+        /// <returns></returns>
+        public IHttpTestAsserter ResponseStatusCodeIsSuccess()
+        {
+            _assertResults.Add(new AssertResult()
+            {
+                Name = nameof(ResponseStatusCodeIsSuccess),
+                Message = $"Expected status code is '2xx' return code is '{_httpResponseMessage.StatusCode}'.",
+                IsTrue = _httpResponseMessage.IsSuccessStatusCode
+            });
+
+            return this;
+        }
+
+        /// <summary>
+        /// HTTP response body is empty
+        /// </summary>
+        /// <returns></returns>
+        public IHttpTestAsserter ResponseBodyIsEmpty()
+        {
+            var bodyString = _httpResponseMessage.Content.ReadAsStringAsync().GetAwaiter().GetResult();
+
+            _assertResults.Add(new AssertResult()
+            {
+                Name = nameof(ResponseBodyIsEmpty),
+                Message = $"Expected empty body, returned body is '{bodyString}'.",
+                IsTrue = string.IsNullOrEmpty(bodyString)
+            });
+
+            return this;
+        }
     }
 }

src/QAToolKit.Engine.HttpTester/Interfaces/IHttpTestAsserter.cs

@@ -37,6 +37,16 @@ public interface IHttpTestAsserter
         /// <returns></returns>
         IHttpTestAsserter ResponseHasHttpHeader(string headerName);
         /// <summary>
+        /// HTTP response status code is one of 2xx
+        /// </summary>
+        /// <returns></returns>
+        IHttpTestAsserter ResponseStatusCodeIsSuccess();
+        /// <summary>
+        /// HTTP response body is empty
+        /// </summary>
+        /// <returns></returns>
+        IHttpTestAsserter ResponseBodyIsEmpty();
+        /// <summary>
         /// Return all Assert messages of the Asserter
         /// </summary>
         /// <returns></returns>

src/QAToolKit.Engine.HttpTester/QAToolKit.Engine.HttpTester.csproj

@@ -35,6 +35,6 @@
 
 	<ItemGroup>
 	  <PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
-	  <PackageReference Include="QAToolKit.Core" Version="0.3.0" />
+	  <PackageReference Include="QAToolKit.Core" Version="0.3.6" />
 	</ItemGroup>
 </Project>