Rename mdn strategies

Author: nathancyam

src/commands/mdn/__snapshots__/index.test.ts.snap renamed to src/commands/mdn/__snapshots__/dom.test.ts.snap

@@ -0,0 +1,43 @@
+import { updatedQueryBuilder } from './api';
+
+import { searchResponse } from './__fixtures__/responses';
+import useData from '../../utils/useData';
+import { getChosenResult } from '../../utils/discordTools';
+
+describe('updatedMDNQuery', () => {
+  const mockUseData: jest.MockedFunction<typeof useData> = jest.fn();
+  const mockChoose: jest.MockedFunction<typeof getChosenResult> = jest.fn();
+
+  const editMsg = {
+    edit: jest.fn(),
+  };
+  const sendMock = jest.fn();
+  const replyMock = jest.fn();
+  const msg: any = {
+    channel: { send: sendMock },
+    reply: replyMock,
+  };
+
+  test('should work', async () => {
+    mockUseData.mockResolvedValueOnce({
+      error: false,
+      text: null,
+      json: searchResponse,
+    });
+
+    mockChoose.mockResolvedValueOnce({
+      title: 'DOM (Document Object Model)',
+      slug: 'Glossary/DOM',
+      locale: 'en-US',
+      excerpt:
+        'The DOM (Document Object Model) is an API that represents and interacts with any HTML or XML document. The DOM is a document model loaded in the browser and representing the document as a node tree, where each node represents part of the document (e.g. an element, text string, or comment).',
+    });
+
+    sendMock.mockResolvedValue(editMsg);
+    const handler = updatedQueryBuilder(mockUseData, mockChoose);
+
+    await handler(msg, 'Search Term');
+    expect(msg.channel.send.mock.calls).toMatchSnapshot();
+    expect(editMsg.edit.mock.calls).toMatchSnapshot();
+  });
+});

src/commands/mdn/api.test.ts

@@ -4,9 +4,8 @@ import * as errors from '../../utils/errors';
 import { getSearchUrl } from '../../utils/urlTools';
 import useData from '../../utils/useData';
 
-import { queryBuilder, updatedQueryBuilder } from '.';
+import { queryBuilder } from './dom';
 import { getChosenResult } from '../../utils/discordTools';
-import { searchResponse } from './__fixtures__/responses';
 
 jest.mock('dom-parser');
 jest.mock('../../utils/urlTools');
@@ -118,28 +117,3 @@ describe('handleMDNQuery', () => {
     expect(sentMessage).toMatchSnapshot();
   });
 });
-
-describe('updatedMDNQuery', () => {
-  const sendMock = jest.fn();
-  const replyMock = jest.fn();
-  const msg: any = {
-    channel: { send: sendMock },
-    reply: replyMock,
-  };
-
-  test('should work', async () => {
-    mockGetSearchUrl.mockReturnValue('http://example.com');
-    mockUseData.mockResolvedValueOnce({
-      error: false,
-      text: null,
-      json: searchResponse,
-    });
-
-    const handler = updatedQueryBuilder(
-      mockGetSearchUrl,
-      mockUseData,
-      mockChoose
-    );
-    await handler(msg, 'Search Term');
-  });
-});

src/commands/mdn/updated.ts renamed to src/commands/mdn/api.ts

@@ -107,65 +107,6 @@ const extractMetadataFromResult = (result: ResultMeta) => {
   };
 };
 
-export const updatedQueryBuilder = (
-  searchUrl: typeof getSearchUrl = getSearchUrl,
-  fetch: typeof useData = useData,
-  waitForChosenResult: typeof getChosenResult = getChosenResult
-) => async (msg: Message, searchTerm: string) => {
-  const url = searchUrl(provider, searchTerm);
-  const { error, json } = await fetch<SearchResponse>(url, 'json');
-  if (!error) {
-    return msg.reply(errors.invalidResponse);
-  }
-
-  if (json.documents.length === 0) {
-    const sentMsg = await msg.reply(errors.noResults(searchTerm));
-    return delayedMessageAutoDeletion(sentMsg);
-  }
-
-  let preparedDescription = json.documents.map(
-    ({ title, excerpt, slug }, index) =>
-      createMarkdownListItem(
-        index,
-        createMarkdownLink(
-          adjustTitleLength([`**${title}**`, excerpt].join(' - ')),
-          buildDirectUrl(provider, slug)
-        )
-      )
-  );
-
-  const expectedLength = preparedDescription.reduce(
-    (sum, item) => sum + item.length,
-    0
-  );
-  if (expectedLength + BASE_DESCRIPTION.length + 10 * '\n'.length > 2048) {
-    preparedDescription = preparedDescription.map(string => {
-      // split at markdown link ending
-      const [title, ...rest] = string.split('...]');
-
-      // split title on title - excerpt glue
-      // concat with rest
-      // fix broken markdown link ending
-      return [title.split(' - ')[0], rest.join('')].join(']');
-    });
-  }
-
-  const sentMsg = await msg.channel.send(
-    createListEmbed({
-      description: createDescription(preparedDescription),
-      footerText: 'Powered by the search API',
-      provider,
-      searchTerm,
-      url,
-    })
-  );
-
-  const result = await waitForChosenResult(sentMsg, msg, json.documents);
-  if (!result) {
-    return;
-  }
-};
-
 /**
  * Poor man's dependency injection without introducing classes, just use closures
  * and higher order functions instead. Also provides a default so we don't have

src/commands/mdn/index.test.ts renamed to src/commands/mdn/dom.test.ts

@@ -7,7 +7,7 @@ import handleComposerQuery from './commands/composer';
 import handleFormattingRequest from './commands/formatting';
 import handleGithubQuery from './commands/github';
 import handleJQueryCommand from './commands/jquery';
-import handleMDNQuery from './commands/mdn';
+import handleMDNQuery from './commands/mdn/dom';
 import handleNPMQuery from './commands/npm';
 import handlePHPQuery from './commands/php';
 import handleJobPostingRequest from './commands/post';