Allow starting scheduler if no static recurring tasks

Author: cupatea

lib/solid_queue/configuration.rb

@@ -93,7 +93,7 @@ def default_options
       end
 
       def invalid_tasks
-        recurring_tasks.select(&:invalid?)
+        static_recurring_tasks.select(&:invalid?)
       end
 
       def only_work?
@@ -122,8 +122,8 @@ def dispatchers
       end
 
       def schedulers
-        if !skip_recurring_tasks? && recurring_tasks.any?
-          [ Process.new(:scheduler, recurring_tasks: recurring_tasks) ]
+        if !skip_recurring_tasks?
+          [ Process.new(:scheduler, recurring_tasks: static_recurring_tasks) ]
         else
           []
         end
@@ -139,8 +139,8 @@ def dispatchers_options
           .map { |options| options.dup.symbolize_keys }
       end
 
-      def recurring_tasks
-        @recurring_tasks ||= recurring_tasks_config.map do |id, options|
+      def static_recurring_tasks
+        @static_recurring_tasks ||= recurring_tasks_config.map do |id, options|
           RecurringTask.from_configuration(id, **options) if options&.has_key?(:schedule)
         end.compact
       end

test/unit/configuration_test.rb

@@ -21,7 +21,7 @@ class ConfigurationTest < ActiveSupport::TestCase
   test "default configuration when config given is empty" do
     configuration = SolidQueue::Configuration.new(config_file: config_file_path(:empty_configuration), recurring_schedule_file: config_file_path(:empty_configuration))
 
-    assert_equal 2, configuration.configured_processes.count
+    assert_equal 3, configuration.configured_processes.count # includes scheduler for dynamic tasks
     assert_processes configuration, :worker, 1, queues: "*"
     assert_processes configuration, :dispatcher, 1, batch_size: SolidQueue::Configuration::DISPATCHER_DEFAULTS[:batch_size]
   end
@@ -101,11 +101,11 @@ class ConfigurationTest < ActiveSupport::TestCase
 
     configuration = SolidQueue::Configuration.new(recurring_schedule_file: config_file_path(:recurring_with_production_only))
     assert configuration.valid?
-    assert_processes configuration, :scheduler, 0
+    assert_processes configuration, :scheduler, 1 # Starts in case of dynamic tasks
 
     configuration = SolidQueue::Configuration.new(recurring_schedule_file: config_file_path(:recurring_with_empty))
     assert configuration.valid?
-    assert_processes configuration, :scheduler, 0
+    assert_processes configuration, :scheduler, 1 # Starts in case of dynamic tasks
 
     # No processes
     configuration = SolidQueue::Configuration.new(skip_recurring: true, dispatchers: [], workers: [])