Update author test

Author: rashidi

jdbi/src/main/java/zin/rashidi/boot/jdbi/book/AuthorReadOnlyRepository.java

@@ -18,9 +18,6 @@ interface AuthorReadOnlyRepository {
     @SqlQuery("SELECT * FROM author")
     Stream<Author> findAll();
 
-    @SqlQuery("SELECT * FROM author WHERE id = :id")
-    Optional<Author> findById(@Bind("id") Long id);
-
     @SqlQuery("SELECT * FROM author WHERE name = :name")
     Stream<Author> findByName(@Bind("name") String name);
 

jdbi/src/test/java/zin/rashidi/boot/jdbi/book/AuthorReadOnlyRepositoryTests.java

@@ -1,46 +1,44 @@
 package zin.rashidi.boot.jdbi.book;
 
-import org.assertj.core.api.Assertions;
-import org.jdbi.v3.spring.EnableJdbiRepositories;
+import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
-import org.springframework.boot.test.autoconfigure.data.jdbc.AutoConfigureDataJdbc;
 import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase;
 import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.context.annotation.ComponentScan;
-import org.springframework.context.annotation.ComponentScan.Filter;
 import org.springframework.context.annotation.Import;
 import org.springframework.test.context.jdbc.Sql;
 import org.springframework.transaction.annotation.Transactional;
 import zin.rashidi.boot.jdbi.TestcontainersConfiguration;
 
+import static org.assertj.core.api.Assertions.assertThat;
 import static org.springframework.boot.test.context.SpringBootTest.WebEnvironment.NONE;
+import static org.springframework.test.context.jdbc.Sql.ExecutionPhase.BEFORE_TEST_CLASS;
 
 /**
  * @author Rashidi Zin
  */
+@SpringBootTest(webEnvironment = NONE)
 @Import(TestcontainersConfiguration.class)
 @AutoConfigureTestDatabase
 @Transactional
-@SpringBootTest(webEnvironment = NONE)
-@Sql(scripts = "classpath:schema.sql")
+@Sql(scripts = "classpath:schema.sql", executionPhase = BEFORE_TEST_CLASS)
 class AuthorReadOnlyRepositoryTests {
 
     @Autowired
     private AuthorReadOnlyRepository authors;
 
     @Test
+    @DisplayName("Given is only one author, When I search for all authors, Then I should get one author")
     void findAll() {
-        Assertions.assertThat(authors.findAll()).hasSize(1);
-    }
-
-    @Test
-    void findById() {
+        assertThat(authors.findAll())
+                .hasSize(1)
+                .extracting("name").containsOnly("Sun Tzu");
     }
 
     @Test
+    @DisplayName("Given there is an author named Sun Tzu, When I search by the name, Then the result should have size of one")
     void findByName() {
+        assertThat(authors.findByName("Sun Tzu")).hasSize(1);
     }
 
 }

jdbi/src/test/resources/schema.sql

@@ -12,4 +12,6 @@ CREATE TABLE book
     CONSTRAINT fk_author
         FOREIGN KEY (author_id)
             REFERENCES author (id)
-);
+);
+
+INSERT INTO author (name) VALUES ('Sun Tzu');