Chore/update appraisals (#934)

* ✅ Adding Webpacker-4-prerelease to tests

* ✅ Adding Rails 5.2, webpacker 3, 4.pre to travis

* ✅ Correcting appraisal

* Update to webpacker 4.0.0.pre.3

* Update Webpacker to 4.0.0.rc.2

* ✅ Update Webpacker to 4.0.x

* ✅ Upgrade rubies. Add 2.6

* ✅ Update chromedriver-helper to webdriver

* 🐛 Restrict bundler to < 2 for tests on Rails 4.2 to run

* Revert "✅ Update chromedriver-helper to webdriver"

This reverts commit 69305e5.

* 💚 Fix Travis matrix for modern rubies

* 💚 Include Jruby for allowed failure.

Author: BookOfGreg

.travis.yml

@@ -7,8 +7,9 @@ cache:
   bundler: true
   yarn: true
 rvm:
-  - 2.5.1
-  - 2.3.7
+  - 2.6.2
+  - 2.5.3
+  - 2.3.8
   - jruby-9.1.9.0
 
 gemfile:
@@ -18,6 +19,8 @@ gemfile:
   - gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
   - gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
   - gemfiles/rails_5_no_sprockets_webpacker_3.gemfile
+  - gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile
+  - gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
   # These don't have webpacker:
   - gemfiles/rails_4.2_sprockets_2.gemfile
   - gemfiles/rails_4.2_sprockets_3.gemfile
@@ -28,23 +31,44 @@ gemfile:
 matrix:
   fast_finish: true
   exclude:
-
-    # all except 5.1_sprockets_4, 5.1_webpacker_3, 4.2_sprockets_3
-    - rvm: jruby-9.1.9.0
+    # Oldest rails does not run on ruby 2.6
+    - rvm: 2.6.2
       gemfile: gemfiles/rails_4.2_sprockets_4.gemfile
+    - rvm: 2.6.2
+      gemfile: gemfiles/rails_4.2_sprockets_3.gemfile
+    - rvm: 2.6.2
+      gemfile: gemfiles/rails_4.2_sprockets_2.gemfile
+    - rvm: 2.5.3
+    - rvm: 2.3.8
     - rvm: jruby-9.1.9.0
-      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_1.gemfile
-    - rvm: jruby-9.1.9.0
-      gemfile: gemfiles/rails_5_no_sprockets_webpacker_1_x.gemfile
-    - rvm: jruby-9.1.9.0
-      gemfile: gemfiles/rails_5_no_sprockets_webpacker_2.gemfile
-    - rvm: jruby-9.1.9.0
+
+  include:
+    # Oldest rails does not run on ruby 2.6
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_4.2_sprockets_4.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_4.2_sprockets_3.gemfile
+    - rvm: 2.5.3
       gemfile: gemfiles/rails_4.2_sprockets_2.gemfile
+    # Newest gemfiles for universal testing
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
+    - rvm: 2.5.3
+      gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
+    - rvm: 2.3.8
+      gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
     - rvm: jruby-9.1.9.0
-      gemfile: gemfiles/rails_5_no_sprockets.gemfile
+      gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
 
   allow_failures:
     - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile
+    - rvm: jruby-9.1.9.0
+      gemfile: gemfiles/rails_5.2_sprockets_4.gemfile
 
 before_install:
   # Repo for Yarn

Appraisals

@@ -4,6 +4,20 @@ appraise 'rails-5.2-sprockets_4' do
   gem 'turbolinks', '~> 5'
 end
 
+appraise 'rails-5.2_no_sprockets_webpacker_3' do
+  gem 'rails', '~> 5.2.0'
+  gem 'webpacker', '~> 3.0'
+  gem 'mini_racer', :platforms => :mri
+  gem 'therubyrhino', :platforms => :jruby
+end
+
+appraise 'rails-5.2_no_sprockets_webpacker_4' do
+  gem 'rails', '~> 5.2.0'
+  gem 'webpacker', '~> 4.0'
+  gem 'mini_racer', :platforms => :mri
+  gem 'therubyrhino', :platforms => :jruby
+end
+
 appraise 'rails-5.1-sprockets_4' do
   gem 'rails', '~> 5.1.0'
   gem 'sprockets', '~> 4.0.x'

gemfiles/rails_5.2_no_sprockets_webpacker_3.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+gem "webpacker", "~> 3.0"
+gem "mini_racer", platforms: :mri
+gem "therubyrhino", platforms: :jruby
+
+gemspec path: "../"

gemfiles/rails_5.2_no_sprockets_webpacker_4.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "http://rubygems.org"
+
+gem "rails", "~> 5.2.0"
+gem "webpacker", "~> 4.0"
+gem "mini_racer", platforms: :mri
+gem "therubyrhino", platforms: :jruby
+
+gemspec path: "../"

react-rails.gemspec

@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
   s.email = ['paul@oshannessy.com', 'rmosolgo@gmail.com', 'neonmd@hotmail.co.uk', 'info@ttanimichi.com']
 
   s.add_development_dependency 'appraisal'
-  s.add_development_dependency 'bundler', '>= 1.2.2'
+  s.add_development_dependency 'bundler', '>= 1.2.2', '< 2.0'
   s.add_development_dependency 'codeclimate-test-reporter'
   s.add_development_dependency 'coffee-rails'
   s.add_development_dependency 'es5-shim-rails', '>= 2.0.5'