Skip to content

Commit 8c812c6

Browse files
jderochervlkjderochervlk
committed
tables looking good
1 parent f571352 commit 8c812c6

File tree

5 files changed

+57
-49
lines changed

5 files changed

+57
-49
lines changed

‎app/routes/MdxRoute.res‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ let components = {
3030
"table": Markdown.Table.make,
3131
"th": Markdown.Th.make,
3232
"thead": Markdown.Thead.make,
33+
"td": Markdown.Td.make,
3334
"ul": Markdown.Ul.make,
3435
// These are custom components we provide
3536
"Cite": Markdown.Cite.make,

‎src/components/Markdown.res‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ module Table = {
218218
@react.component
219219
let make = (~children) =>
220220
<div className="overflow-x-auto mt-10 mb-16">
221-
<table className="md-table"> children </table>
221+
<table> children </table>
222222
</div>
223223
}
224224

‎src/components/Meta.res‎

Lines changed: 46 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -35,48 +35,52 @@ let make = (
3535
| None => title
3636
}
3737

38-
<Head>
39-
<title key="title"> {React.string(title)} </title>
40-
<meta charSet="utf-8" />
41-
<meta
42-
name="viewport"
43-
content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1, minimal-ui"
44-
/>
45-
<meta key="description" name="description" content=description />
46-
<meta key="keywords" name="keywords" content={Array.join(keywords, ",")} />
47-
{switch canonical {
48-
| Some(href) => <link key="canonical" href rel="canonical" />
49-
| None => React.null
50-
}}
51-
<link rel="apple-touch-icon" sizes="180x180" href="/favicon/apple-touch-icon.png" />
52-
<link rel="icon" type_="image/png" sizes="32x32" href="/favicon/favicon-32x32.png" />
53-
<link rel="icon" type_="image/png" sizes="16x16" href="/favicon/favicon-16x16.png" />
54-
<link rel="manifest" href="/favicon/site.webmanifest" />
38+
React.null
5539

56-
/* OG link preview meta data */
57-
<meta key="og:site_name" property="og:site_name" content=ogSiteName />
58-
<meta key="og:locale" property="og:locale" content=ogLocale />
59-
<meta key="og:title" property="og:title" content=ogTitle />
60-
<meta key="og:description" property="og:description" content=ogDescription />
61-
<meta key="og:image" property="og:image" content=ogImage />
40+
// TODO RR7 - fix meta tags
6241

63-
/* Twitter Meta */
64-
<meta key="twitter:title" name="twitter:title" content=title />
65-
<meta key="twitter:description" name="twitter:description" content=description />
66-
<meta key="twitter:site" name="twitter:site" content="@rescriptlang" />
67-
<meta key="twitter:image" property="og:image" content=ogImage />
68-
<meta key="twitter:creator" name="twitter:creator" content="@ReScriptAssoc" />
69-
<meta key="twitter:card" name="twitter:card" content="summary_large_image" />
70-
<link rel="alternate" type_="application/rss+xml" title="ReScript Blog" href="/blog/feed.xml" />
71-
// Docsearch meta tags
72-
<meta
73-
name="docsearch:version"
74-
content={switch version {
75-
| Some(Version(v)) => v
76-
| Some(Latest) => Constants.versions.latest
77-
| Some(Next) => Constants.versions.next
78-
| _ => Constants.versions.latest
79-
}}
80-
/>
81-
</Head>
42+
// <Head>
43+
// <title key="title"> {React.string(title)} </title>
44+
// <meta charSet="utf-8" />
45+
// <meta
46+
// name="viewport"
47+
// content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=1, minimal-ui"
48+
// />
49+
// <meta key="description" name="description" content=description />
50+
// <meta key="keywords" name="keywords" content={Array.join(keywords, ",")} />
51+
// {switch canonical {
52+
// | Some(href) => <link key="canonical" href rel="canonical" />
53+
// | None => React.null
54+
// }}
55+
// <link rel="apple-touch-icon" sizes="180x180" href="/favicon/apple-touch-icon.png" />
56+
// <link rel="icon" type_="image/png" sizes="32x32" href="/favicon/favicon-32x32.png" />
57+
// <link rel="icon" type_="image/png" sizes="16x16" href="/favicon/favicon-16x16.png" />
58+
// <link rel="manifest" href="/favicon/site.webmanifest" />
59+
60+
// /* OG link preview meta data */
61+
// <meta key="og:site_name" property="og:site_name" content=ogSiteName />
62+
// <meta key="og:locale" property="og:locale" content=ogLocale />
63+
// <meta key="og:title" property="og:title" content=ogTitle />
64+
// <meta key="og:description" property="og:description" content=ogDescription />
65+
// <meta key="og:image" property="og:image" content=ogImage />
66+
67+
// /* Twitter Meta */
68+
// <meta key="twitter:title" name="twitter:title" content=title />
69+
// <meta key="twitter:description" name="twitter:description" content=description />
70+
// <meta key="twitter:site" name="twitter:site" content="@rescriptlang" />
71+
// <meta key="twitter:image" property="og:image" content=ogImage />
72+
// <meta key="twitter:creator" name="twitter:creator" content="@ReScriptAssoc" />
73+
// <meta key="twitter:card" name="twitter:card" content="summary_large_image" />
74+
// <link rel="alternate" type_="application/rss+xml" title="ReScript Blog" href="/blog/feed.xml" />
75+
// // Docsearch meta tags
76+
// <meta
77+
// name="docsearch:version"
78+
// content={switch version {
79+
// | Some(Version(v)) => v
80+
// | Some(Latest) => Constants.versions.latest
81+
// | Some(Next) => Constants.versions.next
82+
// | _ => Constants.versions.latest
83+
// }}
84+
// />
85+
// </Head>
8286
}

‎src/layouts/DocsLayout.res‎

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -183,15 +183,17 @@ module Make = (Content: StaticContent) => {
183183
~theme: option<ColorTheme.t>=?,
184184
~children: React.element,
185185
) => {
186-
let router = Next.Router.useRouter()
187-
let route = router.route
186+
// TODO RR7 - make this work for React Router
187+
188+
// let router = Next.Router.useRouter()
189+
// let route = router.route
188190

189191
// Extend breadcrumbs with document title
190-
let breadcrumbs = Dict.get(Content.tocData, route)->Option.mapOr(breadcrumbs, data => {
191-
let title = data["title"]
192+
// let breadcrumbs = Dict.get(Content.tocData, route)->Option.mapOr(breadcrumbs, data => {
193+
// let title = data["title"]
192194

193-
Option.map(breadcrumbs, bc => List.concat(bc, list{{Url.name: title, href: route}}))
194-
})
195+
// Option.map(breadcrumbs, bc => List.concat(bc, list{{Url.name: title, href: route}}))
196+
// })
195197

196198
let {toc} = TableOfContents.Context.useTocContext()
197199

‎styles/_markdown.css‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,4 +72,5 @@
7272
}
7373
}
7474
}
75+
7576
}

0 commit comments

Comments
 (0)