Cleanups

Author: eregon

lib/concurrent-ruby/concurrent/utility/processor_counter.rb

@@ -82,7 +82,7 @@ def compute_physical_processor_count
       end
 
       def compute_cpu_quota
-        if RbConfig::CONFIG["target_os"].match(/linux/i)
+        if RbConfig::CONFIG["target_os"].include?("linux")
           if File.exist?("/sys/fs/cgroup/cpu.max")
             # cgroups v2: https://docs.kernel.org/admin-guide/cgroup-v2.html#cpu-interface-files
             cpu_max = File.read("/sys/fs/cgroup/cpu.max")
@@ -158,7 +158,7 @@ def self.available_processor_count
     processor_counter.available_processor_count
   end
 
-  # The maximun number of processors cores available for process scheduling.
+  # The maximum number of processors cores available for process scheduling.
   # Returns `nil` if there is no enforced limit, or a `Float` if the
   # process is inside a cgroup with a dedicated CPU quota (typically Docker).
   #
@@ -168,7 +168,7 @@ def self.available_processor_count
   # For performance reasons the calculated value will be memoized on the first
   # call.
   #
-  # @return [nil, Float] Maximum number of available processors seen by the OS or Java runtime
+  # @return [nil, Float] Maximum number of available processors as set by a cgroup CPU quota, or nil if none set
   def self.cpu_quota
     processor_counter.cpu_quota
   end

spec/concurrent/utility/processor_count_spec.rb

@@ -27,7 +27,7 @@ module Concurrent
     end
 
     it 'returns nil if no quota is detected' do
-      if RbConfig::CONFIG["target_os"].match(/linux/i)
+      if RbConfig::CONFIG["target_os"].include?("linux")
         expect(File).to receive(:exist?).twice.and_return(nil) # Checks for cgroups V1 and V2
       end
       expect(counter.cpu_quota).to be_nil
@@ -72,21 +72,21 @@ module Concurrent
 
     it 'returns #processor_count if #cpu_quota is nil' do
       expect(Concurrent::processor_counter).to receive(:cpu_quota).and_return(nil)
-      available_processor_count = Concurrent::available_processor_count
+      available_processor_count = Concurrent.available_processor_count
       expect(available_processor_count).to be == Concurrent::processor_count
       expect(available_processor_count).to be_a Float
     end
 
     it 'returns #processor_count if #cpu_quota is higher' do
       expect(Concurrent::processor_counter).to receive(:cpu_quota).and_return(Concurrent::processor_count.to_f * 2)
-      available_processor_count = Concurrent::available_processor_count
+      available_processor_count = Concurrent.available_processor_count
       expect(available_processor_count).to be == Concurrent::processor_count
       expect(available_processor_count).to be_a Float
     end
 
     it 'returns #cpu_quota if #cpu_quota is lower than #processor_count' do
       expect(Concurrent::processor_counter).to receive(:cpu_quota).and_return(Concurrent::processor_count.to_f / 2)
-      available_processor_count = Concurrent::available_processor_count
+      available_processor_count = Concurrent.available_processor_count
       expect(available_processor_count).to be == Concurrent::processor_count.to_f / 2
       expect(available_processor_count).to be_a Float
     end