fix all clippy lints

Author: nyurik

bindgen-tests/tests/parse_callbacks/item_discovery_callback/mod.rs

@@ -20,7 +20,7 @@ impl ParseCallbacks for ItemDiscovery {
 
 fn test_item_discovery_callback(
     header: &str,
-    expected: HashMap<DiscoveredItemId, DiscoveredItem>,
+    expected: &HashMap<DiscoveredItemId, DiscoveredItem>,
 ) {
     let discovery = ItemDiscovery::default();
     let info = Rc::clone(&discovery.0);
@@ -34,7 +34,7 @@ fn test_item_discovery_callback(
         .generate()
         .expect("TODO: panic message");
 
-    compare_item_caches(&info.borrow(), &expected);
+    compare_item_caches(&info.borrow(), expected);
 }
 
 #[test]
@@ -103,7 +103,7 @@ fn test_item_discovery_callback_c() {
         ),
     ]);
     test_item_discovery_callback(
-        "/tests/parse_callbacks/item_discovery_callback/header_item_discovery.h", expected);
+        "/tests/parse_callbacks/item_discovery_callback/header_item_discovery.h", &expected);
 }
 
 #[test]
@@ -125,7 +125,7 @@ fn test_item_discovery_callback_cpp() {
         ),
     ]);
     test_item_discovery_callback(
-        "/tests/parse_callbacks/item_discovery_callback/header_item_discovery.hpp", expected);
+        "/tests/parse_callbacks/item_discovery_callback/header_item_discovery.hpp", &expected);
 }
 
 pub fn compare_item_caches(generated: &ItemCache, expected: &ItemCache) {

bindgen-tests/tests/quickchecking/src/fuzzers.rs

@@ -1,5 +1,6 @@
 use quickcheck::{Arbitrary, Gen};
 use std::fmt;
+use std::fmt::Write as _;
 
 /// `BaseTypeC` is used in generation of C headers to represent the C language's
 /// primitive types as well as `void*`.
@@ -223,11 +224,10 @@ impl Arbitrary for DeclarationListC {
 /// Enables to string and format for `DeclarationListC` types.
 impl fmt::Display for DeclarationListC {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let mut display = String::new();
         for decl in &self.decls {
-            display += &format!("{decl}");
+            write!(f, "{decl}")?;
         }
-        write!(f, "{display}")
+        Ok(())
     }
 }
 
@@ -330,7 +330,7 @@ impl Arbitrary for ArrayDimensionC {
 
         for _ in 1..dimensions {
             // 16 is an arbitrary "not too big" number for capping array size.
-            def += &format!("[{}]", gen_range(g, lower_bound, 16));
+            let _ = write!(def, "[{}]", gen_range(g, lower_bound, 16));
         }
         ArrayDimensionC { def }
     }
@@ -347,7 +347,7 @@ impl fmt::Display for ArrayDimensionC {
 /// identifiers unique.
 impl MakeUnique for BasicTypeDeclarationC {
     fn make_unique(&mut self, stamp: usize) {
-        self.ident_id += &format!("_{stamp}");
+        let _ = write!(self.ident_id, "_{stamp}");
     }
 }
 
@@ -384,7 +384,7 @@ impl fmt::Display for BasicTypeDeclarationC {
 /// identifiers unique.
 impl MakeUnique for StructDeclarationC {
     fn make_unique(&mut self, stamp: usize) {
-        self.ident_id += &format!("_{stamp}");
+        let _ = write!(self.ident_id, "_{stamp}");
     }
 }
 
@@ -432,7 +432,7 @@ impl fmt::Display for StructDeclarationC {
 /// identifiers unique.
 impl MakeUnique for UnionDeclarationC {
     fn make_unique(&mut self, stamp: usize) {
-        self.ident_id += &format!("_{stamp}");
+        let _ = write!(self.ident_id, "_{stamp}");
     }
 }
 
@@ -480,7 +480,7 @@ impl fmt::Display for UnionDeclarationC {
 /// `FunctionPointerDeclarationC` identifiers unique.
 impl MakeUnique for FunctionPointerDeclarationC {
     fn make_unique(&mut self, stamp: usize) {
-        self.ident_id += &format!("_{stamp}");
+        let _ = write!(self.ident_id, "_{stamp}");
     }
 }
 
@@ -517,7 +517,7 @@ impl fmt::Display for FunctionPointerDeclarationC {
 /// identifiers unique.
 impl MakeUnique for FunctionPrototypeC {
     fn make_unique(&mut self, stamp: usize) {
-        self.ident_id += &format!("_{stamp}");
+        let _ = write!(self.ident_id, "_{stamp}");
     }
 }
 
@@ -586,14 +586,13 @@ impl Arbitrary for ParameterListC {
 /// Enables to string and format for `ParameterListC` types.
 impl fmt::Display for ParameterListC {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let mut display = String::new();
         for (i, p) in self.params.iter().enumerate() {
             match i {
-                0 => display += &format!("{p}"),
-                _ => display += &format!(",{p}"),
+                0 => write!(f, "{p}")?,
+                _ => write!(f, ",{p}")?,
             }
         }
-        write!(f, "{display}")
+        Ok(())
     }
 }
 
@@ -612,11 +611,10 @@ impl Arbitrary for HeaderC {
 /// Enables to string and format for `HeaderC` types.
 impl fmt::Display for HeaderC {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        let mut display = String::new();
         for decl in &self.def.decls {
-            display += &format!("{decl}");
+            write!(f, "{decl}")?;
         }
-        write!(f, "{display}")
+        Ok(())
     }
 }
 

bindgen-tests/tests/tests.rs

@@ -27,7 +27,7 @@ fn should_overwrite_expected() -> bool {
             return true;
         }
         assert!(
-            var == "0" || var == "",
+            var == "0" || var.is_empty(),
             "Invalid value of BINDGEN_OVERWRITE_EXPECTED"
         );
     }
@@ -57,7 +57,7 @@ fn error_diff_mismatch(
     if let Some(var) = env::var_os("BINDGEN_TESTS_DIFFTOOL") {
         //usecase: var = "meld" -> You can hand check differences
         let Some(std::path::Component::Normal(name)) =
-            filename.components().last()
+            filename.components().next_back()
         else {
             panic!("Why is the header variable so weird?")
         };
@@ -187,7 +187,7 @@ fn compare_generated_header(
             header.display(),
             looked_at,
         ),
-    };
+    }
 
     let (builder, roundtrip_builder) = builder.into_builder(check_roundtrip)?;
 

bindgen/codegen/mod.rs

@@ -3075,7 +3075,7 @@ impl Method {
                     parent: parent_id,
                     final_name: name.clone(),
                 },
-            )
+            );
         });
 
         let mut function_name = function_item.canonical_name(ctx);
@@ -3138,7 +3138,7 @@ impl Method {
             exprs[0] = quote! {
                 self
             };
-        };
+        }
 
         let call = quote! {
             #function_name (#( #exprs ),* )
@@ -3282,7 +3282,7 @@ impl FromStr for EnumVariation {
 struct EnumBuilder {
     /// Type identifier of the enum.
     ///
-    /// This is the base name, i.e. for ModuleConst enums, this does not include the module name.
+    /// This is the base name, i.e. for `ModuleConst` enums, this does not include the module name.
     enum_type: Ident,
     /// Attributes applying to the enum type
     attrs: Vec<proc_macro2::TokenStream>,
@@ -3453,7 +3453,7 @@ impl EnumBuilder {
     }
 
     fn newtype_bitfield_impl(
-        prefix: Ident,
+        prefix: &Ident,
         rust_ty: &syn::Type,
     ) -> proc_macro2::TokenStream {
         let rust_ty_name = &rust_ty;
@@ -3593,7 +3593,7 @@ impl EnumBuilder {
 
                 let prefix = ctx.trait_prefix();
                 let bitfield_impl_opt = is_bitfield
-                    .then(|| Self::newtype_bitfield_impl(prefix, rust_ty));
+                    .then(|| Self::newtype_bitfield_impl(&prefix, rust_ty));
 
                 quote! {
                     // Previously variant impls where before the enum definition.
@@ -4625,7 +4625,7 @@ impl CodeGenerator for Function {
             FunctionKind::Method(ref method_kind) => {
                 method_kind.is_pure_virtual()
             }
-            _ => false,
+            FunctionKind::Function => false,
         };
         if is_pure_virtual && !ctx.options().generate_pure_virtual_functions {
             // Pure virtual methods have no actual symbol, so we can't generate

bindgen/codegen/serialize.rs

@@ -368,7 +368,7 @@ impl<'a> CSerialize<'a> for Type {
                 match comp_info.kind() {
                     CompKind::Struct => write!(writer, "struct {name}")?,
                     CompKind::Union => write!(writer, "union {name}")?,
-                };
+                }
             }
             TypeKind::Enum(_enum_ty) => {
                 if self.is_const() {
@@ -384,7 +384,7 @@ impl<'a> CSerialize<'a> for Type {
                     loc: get_loc(item),
                 })
             }
-        };
+        }
 
         if !stack.is_empty() {
             write!(writer, " ")?;

bindgen/codegen/struct_layout.rs

@@ -266,11 +266,11 @@ impl<'a> StructLayoutTracker<'a> {
             }
         };
 
-        if !is_union {
-            self.latest_offset += field_layout.size;
-        } else {
+        if is_union {
             self.latest_offset =
                 cmp::max(self.latest_offset, field_layout.size);
+        } else {
+            self.latest_offset += field_layout.size;
         }
         self.latest_field_layout = Some(field_layout);
         self.max_field_align =

bindgen/ir/analysis/derive.rs

@@ -197,7 +197,7 @@ impl CannotDerive<'_> {
                         self.derive_trait
                     );
                 }
-            };
+            }
             return layout_can_derive;
         }
 
@@ -355,7 +355,7 @@ impl CannotDerive<'_> {
                                     self.derive_trait
                                 );
                             }
-                        };
+                        }
                         return layout_can_derive;
                     }
                 }

bindgen/ir/comp.rs

@@ -1855,7 +1855,7 @@ impl IsOpaque for CompInfo {
             // See https://github.com/rust-lang/rust-bindgen/issues/537 and
             // https://github.com/rust-lang/rust/issues/33158
             if self.is_packed(ctx, layout.as_ref()) &&
-                layout.map_or(false, |l| l.align > 1)
+                layout.is_some_and(|l| l.align > 1)
             {
                 warn!("Found a type that is both packed and aligned to greater than \
                        1; Rust before version 1.33 doesn't have `#[repr(packed(N))]`, so we \

bindgen/ir/context.rs

@@ -931,7 +931,7 @@ If you encounter an error missing from this list, please file an issue or a PR!"
                 *ty.kind()
             {
                 typerefs.push((id, *ty, loc, parent_id));
-            };
+            }
         }
         typerefs
     }
@@ -3076,7 +3076,7 @@ impl TemplateParameters for PartialType {
                             num_params += 1;
                         }
                         _ => {}
-                    };
+                    }
                     clang_sys::CXChildVisit_Continue
                 });
                 num_params

bindgen/ir/item.rs

@@ -727,15 +727,15 @@ impl Item {
         to.push_str(&self.canonical_name(ctx));
         if let ItemKind::Type(ref ty) = *self.kind() {
             if let TypeKind::TemplateInstantiation(ref inst) = *ty.kind() {
-                to.push_str(&format!("_open{level}_"));
+                let _ = write!(to, "_open{level}_");
                 for arg in inst.template_arguments() {
                     arg.into_resolver()
                         .through_type_refs()
                         .resolve(ctx)
                         .push_disambiguated_name(ctx, to, level + 1);
                     to.push('_');
                 }
-                to.push_str(&format!("close{level}"));
+                let _ = write!(to, "close{level}");
             }
         }
     }