Added suggestions and changes from review

Changed example suggestion from const to snippet

Shortend error message

Followed clippy naming conventions

Author: rommeld

clippy_lints/src/declared_lints.rs

@@ -352,7 +352,7 @@ pub static LINTS: &[&::declare_clippy_lint::LintInfo] = &[
     crate::methods::CASE_SENSITIVE_FILE_EXTENSION_COMPARISONS_INFO,
     crate::methods::CHARS_LAST_CMP_INFO,
     crate::methods::CHARS_NEXT_CMP_INFO,
-    crate::methods::CHUNKS_EXACT_TO_AS_CHUNKS_INFO,
+    crate::methods::CHUNKS_EXACT_WITH_CONST_SIZE_INFO,
     crate::methods::CLEAR_WITH_DRAIN_INFO,
     crate::methods::CLONED_INSTEAD_OF_COPIED_INFO,
     crate::methods::CLONE_ON_COPY_INFO,

clippy_lints/src/methods/chunks_exact_to_as_chunks.rs renamed to clippy_lints/src/methods/chunks_exact_with_const_size.rs

@@ -1,12 +1,13 @@
 use clippy_utils::consts::{ConstEvalCtxt, Constant};
 use clippy_utils::diagnostics::span_lint_and_help;
 use clippy_utils::msrvs::{self, Msrv};
+use clippy_utils::source::snippet;
 use clippy_utils::sym;
 use rustc_hir::Expr;
 use rustc_lint::LateContext;
 use rustc_span::Symbol;
 
-use super::CHUNKS_EXACT_TO_AS_CHUNKS;
+use super::CHUNKS_EXACT_WITH_CONST_SIZE;
 
 pub(super) fn check(
     cx: &LateContext<'_>,
@@ -29,21 +30,21 @@ pub(super) fn check(
 
     // Check if argument is a constant
     let constant_eval = ConstEvalCtxt::new(cx);
-    if let Some(Constant::Int(chunk_size)) = constant_eval.eval(arg) {
+    if let Some(Constant::Int(_)) = constant_eval.eval(arg) {
         // Emit the lint
         let suggestion = if method_name == sym::chunks_exact_mut {
             "as_chunks_mut"
         } else {
             "as_chunks"
         };
-
+        let arg_str = snippet(cx, arg.span, "_");
         span_lint_and_help(
             cx,
-            CHUNKS_EXACT_TO_AS_CHUNKS,
+            CHUNKS_EXACT_WITH_CONST_SIZE,
             expr.span,
-            format!("using `{method_name}` with a constant chunk size"),
+            "chunks_exact_with_const_size",
             None,
-            format!("consider using `{suggestion}::<{chunk_size}>()` for better ergonomics"),
+            format!("consider using `{suggestion}::<{arg_str}>()` for better ergonomics"),
         );
     }
 }

clippy_lints/src/methods/mod.rs

@@ -9,7 +9,7 @@ mod chars_last_cmp;
 mod chars_last_cmp_with_unwrap;
 mod chars_next_cmp;
 mod chars_next_cmp_with_unwrap;
-mod chunks_exact_to_as_chunks;
+mod chunks_exact_with_const_size;
 mod clear_with_drain;
 mod clone_on_copy;
 mod clone_on_ref_ptr;
@@ -2109,7 +2109,7 @@ declare_clippy_lint! {
     /// for chunk in chunks {}
     /// ```
     #[clippy::version = "1.93.0"]
-    pub CHUNKS_EXACT_TO_AS_CHUNKS,
+    pub CHUNKS_EXACT_WITH_CONST_SIZE,
     style,
     "using `chunks_exact` with constant when `as_chunks` is more ergonomic"
 }
@@ -4814,7 +4814,7 @@ impl_lint_pass!(Methods => [
     ITER_NTH,
     ITER_NTH_ZERO,
     BYTES_NTH,
-    CHUNKS_EXACT_TO_AS_CHUNKS,
+    CHUNKS_EXACT_WITH_CONST_SIZE,
     ITER_SKIP_NEXT,
     GET_UNWRAP,
     GET_LAST_WITH_LEN,
@@ -5744,7 +5744,7 @@ impl Methods {
                     );
                 },
                 (name @ (sym::chunks_exact | sym::chunks_exact_mut), [arg]) => {
-                    chunks_exact_to_as_chunks::check(cx, expr, recv, arg, name, self.msrv);
+                    chunks_exact_with_const_size::check(cx, expr, recv, arg, name, self.msrv);
                 },
                 _ => {},
             }

tests/ui/chunks_exact_to_as_chunks.rs renamed to tests/ui/chunks_exact_with_const_size.rs

@@ -1,18 +1,18 @@
-#![warn(clippy::chunks_exact_to_as_chunks)]
+#![warn(clippy::chunks_exact_with_const_size)]
 #![allow(unused)]
 
 fn main() {
     let slice = [1, 2, 3, 4, 5, 6, 7, 8];
 
     // Should trigger lint - literal constant
     let mut it = slice.chunks_exact(4);
-    //~^ ERROR: using `chunks_exact` with a constant chunk size
+    //~^ ERROR: chunks_exact_with_const_size
     for chunk in it {}
 
     // Should trigger lint - const value
     const CHUNK_SIZE: usize = 4;
     let mut it = slice.chunks_exact(CHUNK_SIZE);
-    //~^ ERROR: using `chunks_exact` with a constant chunk size
+    //~^ ERROR: chunks_exact_with_const_size
     for chunk in it {}
 
     // Should NOT trigger - runtime value
@@ -22,13 +22,13 @@ fn main() {
 
     // Should trigger lint - with remainder
     let mut it = slice.chunks_exact(3);
-    //~^ ERROR: using `chunks_exact` with a constant chunk size
+    //~^ ERROR: chunks_exact_with_const_size
     for chunk in &mut it {}
     for e in it.remainder() {}
 
     // Should trigger - mutable variant
     let mut arr = [1, 2, 3, 4, 5, 6, 7, 8];
     let mut it = arr.chunks_exact_mut(4);
-    //~^ ERROR: using `chunks_exact_mut` with a constant chunk size
+    //~^ ERROR: chunks_exact_with_const_size
     for chunk in it {}
 }

tests/ui/chunks_exact_to_as_chunks.stderr renamed to tests/ui/chunks_exact_with_const_size.stderr

@@ -1,31 +1,31 @@
-error: using `chunks_exact` with a constant chunk size
-  --> tests/ui/chunks_exact_to_as_chunks.rs:8:18
+error: chunks_exact_with_const_size
+  --> tests/ui/chunks_exact_with_const_size.rs:8:18
    |
 LL |     let mut it = slice.chunks_exact(4);
    |                  ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `as_chunks::<4>()` for better ergonomics
-   = note: `-D clippy::chunks-exact-to-as-chunks` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_to_as_chunks)]`
+   = note: `-D clippy::chunks-exact-with-const-size` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::chunks_exact_with_const_size)]`
 
-error: using `chunks_exact` with a constant chunk size
-  --> tests/ui/chunks_exact_to_as_chunks.rs:14:18
+error: chunks_exact_with_const_size
+  --> tests/ui/chunks_exact_with_const_size.rs:14:18
    |
 LL |     let mut it = slice.chunks_exact(CHUNK_SIZE);
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
-   = help: consider using `as_chunks::<4>()` for better ergonomics
+   = help: consider using `as_chunks::<CHUNK_SIZE>()` for better ergonomics
 
-error: using `chunks_exact` with a constant chunk size
-  --> tests/ui/chunks_exact_to_as_chunks.rs:24:18
+error: chunks_exact_with_const_size
+  --> tests/ui/chunks_exact_with_const_size.rs:24:18
    |
 LL |     let mut it = slice.chunks_exact(3);
    |                  ^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `as_chunks::<3>()` for better ergonomics
 
-error: using `chunks_exact_mut` with a constant chunk size
-  --> tests/ui/chunks_exact_to_as_chunks.rs:31:18
+error: chunks_exact_with_const_size
+  --> tests/ui/chunks_exact_with_const_size.rs:31:18
    |
 LL |     let mut it = arr.chunks_exact_mut(4);
    |                  ^^^^^^^^^^^^^^^^^^^^^^^