refactor: address PR review feedback for line numbering feature

- Remove manual CHANGELOG.md entry (auto-generated at release)
- Revert docs/capabilities.md changes (auto-generated via mcp-discovery)
- Improve documentation clarity for with_line_numbers parameter format
- Add test for Windows line endings (\r\n)
- Add edge case tests for newline-only content

Addresses review comments on PR #61

[agent commit]

Author: Abderraouf Belalia

CHANGELOG.md

@@ -1,15 +1,5 @@
 # Changelog
 
-## [Unreleased]
-
-### 🚀 Features
-
-* Add optional line numbering to read_text_file tool ([#60](https://github.com/rust-mcp-stack/rust-mcp-filesystem/issues/60))
-  - Added `with_line_numbers` optional parameter to `read_text_file` tool
-  - When enabled, prefixes each line with right-aligned line numbers and pipe separator
-  - Useful for AI agents that need to target specific lines for code patches
-  - Maintains backward compatibility with existing usage
-
 ## [0.3.6](https://github.com/rust-mcp-stack/rust-mcp-filesystem/compare/v0.3.5...v0.3.6) (2025-10-15)
 
 

docs/capabilities.md

@@ -230,11 +230,10 @@
             <td>
                 <code><b>read_text_file</b></code>
             </td>
-            <td>Read the complete contents of a text file from the file system as text. Handles various text encodings and provides detailed error messages if the file cannot be read. Use this tool when you need to examine the contents of a single file. Optionally include line numbers for precise code targeting. Only works within allowed directories.</td>
+            <td>Read the complete contents of a text file from the file system as text. Handles various text encodings and provides detailed error messages if the file cannot be read. Use this tool when you need to examine the contents of a single file. Only works within allowed directories.</td>
             <td>
                 <ul>
                     <li> <code>path</code> : string<br /></li>
-                    <li> <code>with_line_numbers</code> : boolean<br /></li>
                 </ul>
             </td>
         </tr>

src/tools/read_text_file.rs

@@ -24,8 +24,8 @@ pub struct ReadTextFile {
     /// The path of the file to read.
     pub path: String,
     /// Optional: Include line numbers in output (default: false).
-    /// When enabled, each line is prefixed with its line number (1-based).
-    /// Useful for AI agents that need to target specific lines for code patches.
+    /// When enabled, each line is prefixed with a right-aligned, 1-based line number
+    /// Followed by a space, a vertical bar (`|`), and another space in the format: `   123 | <original line content>`
     #[serde(default)]
     pub with_line_numbers: Option<bool>,
 }

tests/test_fs_service.rs

@@ -306,6 +306,42 @@ async fn test_read_text_file_with_line_numbers_large_file() {
     assert!(content.contains("  1000 | line1000"));
 }
 
+#[tokio::test]
+async fn test_read_text_file_with_line_numbers_windows_line_endings() {
+    let (temp_dir, service, _allowed_dirs) = setup_service(vec!["dir1".to_string()]);
+    let file_path = create_temp_file(
+        temp_dir.join("dir1").as_path(),
+        "windows.txt",
+        "line1\r\nline2\r\nline3",
+    );
+    let content = service.read_text_file(&file_path, true).await.unwrap();
+    assert_eq!(content, "     1 | line1\n     2 | line2\n     3 | line3");
+}
+
+#[tokio::test]
+async fn test_read_text_file_with_line_numbers_single_newline_unix() {
+    let (temp_dir, service, _allowed_dirs) = setup_service(vec!["dir1".to_string()]);
+    // A file with just "\n" is treated by lines() as having one empty line before the newline
+    // To get two empty lines, we need "\n\n"
+    let file_path = create_temp_file(temp_dir.join("dir1").as_path(), "newline_unix.txt", "\n\n");
+    let content = service.read_text_file(&file_path, true).await.unwrap();
+    assert_eq!(content, "     1 | \n     2 | ");
+}
+
+#[tokio::test]
+async fn test_read_text_file_with_line_numbers_single_newline_windows() {
+    let (temp_dir, service, _allowed_dirs) = setup_service(vec!["dir1".to_string()]);
+    // A file with just "\r\n" is treated by lines() as having one empty line
+    // To get two empty lines, we need "\r\n\r\n"
+    let file_path = create_temp_file(
+        temp_dir.join("dir1").as_path(),
+        "newline_windows.txt",
+        "\r\n\r\n",
+    );
+    let content = service.read_text_file(&file_path, true).await.unwrap();
+    assert_eq!(content, "     1 | \n     2 | ");
+}
+
 #[tokio::test]
 async fn test_create_directory() {
     let (temp_dir, service, _allowed_dirs) = setup_service(vec!["dir1".to_string()]);