Merge pull request #2946 from dotty-staging/fix-#2928

Fix #2928: Add special mode for computing the type of a LHS

Author: odersky

compiler/src/dotty/tools/dotc/typer/Typer.scala

@@ -587,8 +587,13 @@ class Typer extends Namer with TypeAssigner with Applications with Implicits wit
         lhsCore.tpe match {
           case ref: TermRef =>
             val lhsVal = lhsCore.denot.suchThat(!_.is(Method))
-            if (canAssign(lhsVal.symbol))
-              assignType(cpy.Assign(tree)(lhs1, typed(tree.rhs, lhsVal.info)))
+            if (canAssign(lhsVal.symbol)) {
+              // lhsBounds: (T .. Any) as seen from lhs prefix, where T is the type of lhsVal.symbol
+              // This ensures we do the as-seen-from on T with variance -1. Test case neg/i2928.scala
+              val lhsBounds =
+                TypeBounds.lower(lhsVal.symbol.info).asSeenFrom(ref.prefix, lhsVal.symbol.owner)
+              assignType(cpy.Assign(tree)(lhs1, typed(tree.rhs, lhsBounds.loBound)))
+            }
             else {
               val pre = ref.prefix
               val setterName = ref.name.setterName

tests/neg/i2928.scala

@@ -0,0 +1,15 @@
+class Box[T22](var v: T22)
+
+object Test {
+ def main(args: Array[String]): Unit = {
+   val s = new Box[String]("")
+   val i = new Box[Int](3)
+
+   var box: Box[_] = s
+   val sv = box.v
+   box = i
+   box.v = sv // error
+
+   val c: Int = i.v
+ }
+}