Add missing signal tests

Resolves: #57

Author: adazem009

test/penlayer/CMakeLists.txt

@@ -10,6 +10,7 @@ target_link_libraries(
   scratchcpp-render
   scratchcpprender_mocks
   ${QT_LIBS}
+  Qt6::Test
 )
 
 add_test(penlayer_test)

test/penlayer/penlayer_test.cpp

@@ -2,6 +2,7 @@
 #include <QOpenGLExtraFunctions>
 #include <QBuffer>
 #include <QFile>
+#include <QSignalSpy>
 #include <penlayer.h>
 #include <penattributes.h>
 #include <projectloader.h>
@@ -53,6 +54,7 @@ TEST_F(PenLayerTest, Constructors)
 TEST_F(PenLayerTest, Engine)
 {
     PenLayer penLayer;
+    QSignalSpy spy(&penLayer, &PenLayer::engineChanged);
     ASSERT_EQ(penLayer.engine(), nullptr);
 
     EngineMock engine1, engine2;
@@ -61,15 +63,33 @@ TEST_F(PenLayerTest, Engine)
     EXPECT_CALL(engine1, stageWidth()).WillOnce(Return(480));
     penLayer.setEngine(&engine1);
     ASSERT_EQ(penLayer.engine(), &engine1);
+    ASSERT_EQ(spy.count(), 1);
 
     penLayer.setWidth(500);
     penLayer.setHeight(400);
     EXPECT_CALL(engine2, stageWidth()).WillOnce(Return(500));
     penLayer.setEngine(&engine2);
     ASSERT_EQ(penLayer.engine(), &engine2);
+    ASSERT_EQ(spy.count(), 2);
 
     penLayer.setEngine(nullptr);
     ASSERT_EQ(penLayer.engine(), nullptr);
+    ASSERT_EQ(spy.count(), 3);
+}
+
+TEST_F(PenLayerTest, HqPen)
+{
+    PenLayer penLayer;
+    QSignalSpy spy(&penLayer, &PenLayer::hqPenChanged);
+    ASSERT_FALSE(penLayer.hqPen());
+
+    penLayer.setHqPen(true);
+    ASSERT_TRUE(penLayer.hqPen());
+    ASSERT_EQ(spy.count(), 1);
+
+    penLayer.setHqPen(false);
+    ASSERT_FALSE(penLayer.hqPen());
+    ASSERT_EQ(spy.count(), 2);
 }
 
 TEST_F(PenLayerTest, FramebufferObject)

test/projectscene/CMakeLists.txt

@@ -10,6 +10,7 @@ target_link_libraries(
   scratchcpp-render
   scratchcpprender_mocks
   ${QT_LIBS}
+  Qt6::Test
 )
 
 add_test(projectscene_test)

test/projectscene/projectscene_test.cpp

@@ -1,3 +1,4 @@
+#include <QSignalSpy>
 #include <scratchcpp/keyevent.h>
 #include <projectscene.h>
 #include <enginemock.h>
@@ -11,20 +12,24 @@ using ::testing::Return;
 TEST(ProjectSceneTest, Engine)
 {
     ProjectScene scene;
+    QSignalSpy spy(&scene, &ProjectScene::engineChanged);
     ASSERT_EQ(scene.engine(), nullptr);
 
     EngineMock engine;
     scene.setEngine(&engine);
     ASSERT_EQ(scene.engine(), &engine);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST(ProjectSceneTest, StageScale)
 {
     ProjectScene scene;
+    QSignalSpy spy(&scene, &ProjectScene::stageScaleChanged);
     ASSERT_EQ(scene.stageScale(), 1);
 
     scene.setStageScale(5.79);
     ASSERT_EQ(scene.stageScale(), 5.79);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST(ProjectSceneTest, HandleMouseMove)

test/renderedtarget/renderedtarget_test.cpp

@@ -623,31 +623,37 @@ TEST_F(RenderedTargetTest, SpriteDragging)
 TEST_F(RenderedTargetTest, Engine)
 {
     RenderedTarget target;
+    QSignalSpy spy(&target, &RenderedTarget::engineChanged);
     ASSERT_EQ(target.engine(), nullptr);
 
     EngineMock engine;
     target.setEngine(&engine);
     ASSERT_EQ(target.engine(), &engine);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(RenderedTargetTest, StageModel)
 {
     RenderedTarget target;
+    QSignalSpy spy(&target, &RenderedTarget::stageModelChanged);
     ASSERT_EQ(target.stageModel(), nullptr);
 
     StageModel model;
     target.setStageModel(&model);
     ASSERT_EQ(target.stageModel(), &model);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(RenderedTargetTest, SpriteModel)
 {
     RenderedTarget target;
+    QSignalSpy spy(&target, &RenderedTarget::spriteModelChanged);
     ASSERT_EQ(target.spriteModel(), nullptr);
 
     SpriteModel model;
     target.setSpriteModel(&model);
     ASSERT_EQ(target.spriteModel(), &model);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(RenderedTargetTest, ScratchTarget)
@@ -672,20 +678,24 @@ TEST_F(RenderedTargetTest, ScratchTarget)
 TEST_F(RenderedTargetTest, MouseArea)
 {
     RenderedTarget target;
+    QSignalSpy spy(&target, &RenderedTarget::mouseAreaChanged);
     ASSERT_EQ(target.mouseArea(), nullptr);
 
     SceneMouseArea mouseArea;
     target.setMouseArea(&mouseArea);
     ASSERT_EQ(target.mouseArea(), &mouseArea);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(RenderedTargetTest, StageScale)
 {
     RenderedTarget target;
+    QSignalSpy spy(&target, &RenderedTarget::stageScaleChanged);
     ASSERT_EQ(target.stageScale(), 1);
 
     target.setStageScale(6.4);
     ASSERT_EQ(target.stageScale(), 6.4);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(RenderedTargetTest, GraphicEffects)

test/textbubbleshape/CMakeLists.txt

@@ -8,6 +8,7 @@ target_link_libraries(
   GTest::gtest_main
   scratchcpp-render
   ${QT_LIBS}
+  Qt6::Test
 )
 
 add_test(textbubbleshape_test)

test/textbubbleshape/textbubbleshape_test.cpp

@@ -1,5 +1,6 @@
 #include <QOpenGLContext>
 #include <QOffscreenSurface>
+#include <QSignalSpy>
 #include <textbubbleshape.h>
 
 #include "../common.h"
@@ -41,56 +42,70 @@ TEST_F(TextBubbleShapeTest, Constructors)
 TEST_F(TextBubbleShapeTest, Type)
 {
     TextBubbleShape bubble;
+    QSignalSpy spy(&bubble, &TextBubbleShape::typeChanged);
     ASSERT_EQ(bubble.type(), TextBubbleShape::Type::Say);
 
     bubble.setType(TextBubbleShape::Type::Think);
     ASSERT_EQ(bubble.type(), TextBubbleShape::Type::Think);
+    ASSERT_EQ(spy.count(), 1);
 
     bubble.setType(TextBubbleShape::Type::Think);
     ASSERT_EQ(bubble.type(), TextBubbleShape::Type::Think);
+    ASSERT_EQ(spy.count(), 1);
 
     bubble.setType(TextBubbleShape::Type::Say);
     ASSERT_EQ(bubble.type(), TextBubbleShape::Type::Say);
+    ASSERT_EQ(spy.count(), 2);
 }
 
 TEST_F(TextBubbleShapeTest, OnSpriteRight)
 {
     TextBubbleShape bubble;
+    QSignalSpy spy(&bubble, &TextBubbleShape::onSpriteRightChanged);
     ASSERT_TRUE(bubble.onSpriteRight());
 
     bubble.setOnSpriteRight(false);
     ASSERT_FALSE(bubble.onSpriteRight());
+    ASSERT_EQ(spy.count(), 1);
 
     bubble.setOnSpriteRight(false);
     ASSERT_FALSE(bubble.onSpriteRight());
+    ASSERT_EQ(spy.count(), 1);
 
     bubble.setOnSpriteRight(true);
     ASSERT_TRUE(bubble.onSpriteRight());
+    ASSERT_EQ(spy.count(), 2);
 }
 
 TEST_F(TextBubbleShapeTest, StageScale)
 {
     TextBubbleShape bubble;
+    QSignalSpy spy(&bubble, &TextBubbleShape::stageScaleChanged);
     ASSERT_EQ(bubble.stageScale(), 1);
 
     bubble.setStageScale(6.48);
     ASSERT_EQ(bubble.stageScale(), 6.48);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(TextBubbleShapeTest, NativeWidth)
 {
     TextBubbleShape bubble;
+    QSignalSpy spy(&bubble, &TextBubbleShape::nativeWidthChanged);
     ASSERT_EQ(bubble.nativeWidth(), 0);
 
     bubble.setNativeWidth(48.1);
     ASSERT_EQ(bubble.nativeWidth(), 48.1);
+    ASSERT_EQ(spy.count(), 1);
 }
 
 TEST_F(TextBubbleShapeTest, NativeHeight)
 {
     TextBubbleShape bubble;
+    QSignalSpy spy(&bubble, &TextBubbleShape::nativeHeightChanged);
     ASSERT_EQ(bubble.nativeHeight(), 0);
 
     bubble.setNativeHeight(87.5);
     ASSERT_EQ(bubble.nativeHeight(), 87.5);
+    ASSERT_EQ(spy.count(), 1);
 }