Polishing.

See #3373

Author: mp911de

src/main/java/org/springframework/data/repository/core/RepositoryCreationException.java

@@ -15,6 +15,8 @@
  */
 package org.springframework.data.repository.core;
 
+import org.jspecify.annotations.Nullable;
+
 import org.springframework.dao.InvalidDataAccessApiUsageException;
 
 /**
@@ -34,7 +36,7 @@ public class RepositoryCreationException extends InvalidDataAccessApiUsageExcept
 	 * @param msg the detail message.
 	 * @param repositoryInterface the repository interface.
 	 */
-	public RepositoryCreationException(String msg, Class<?> repositoryInterface) {
+	public RepositoryCreationException(@Nullable String msg, Class<?> repositoryInterface) {
 		super(msg);
 		this.repositoryInterface = repositoryInterface;
 	}
@@ -46,12 +48,13 @@ public RepositoryCreationException(String msg, Class<?> repositoryInterface) {
 	 * @param cause the root cause from the data access API in use.
 	 * @param repositoryInterface the repository interface.
 	 */
-	public RepositoryCreationException(String msg, Throwable cause, Class<?> repositoryInterface) {
+	public RepositoryCreationException(@Nullable String msg, @Nullable Throwable cause, Class<?> repositoryInterface) {
 		super(msg, cause);
 		this.repositoryInterface = repositoryInterface;
 	}
 
 	public Class<?> getRepositoryInterface() {
 		return repositoryInterface;
 	}
+
 }

src/main/java/org/springframework/data/repository/query/QueryCreationException.java

@@ -17,6 +17,9 @@
 
 import java.io.Serial;
 import java.lang.reflect.Method;
+import java.lang.reflect.Type;
+import java.util.Arrays;
+import java.util.stream.Collectors;
 
 import org.jspecify.annotations.Nullable;
 
@@ -31,7 +34,6 @@
 public final class QueryCreationException extends RepositoryCreationException {
 
 	private static final @Serial long serialVersionUID = -1238456123580L;
-	private static final String MESSAGE_TEMPLATE = "Could not create query for method [%s]; Could not find property '%s' on domain class '%s'";
 
 	private final Method method;
 
@@ -81,7 +83,8 @@ private QueryCreationException(@Nullable String message, @Nullable Throwable cau
 	public static QueryCreationException invalidProperty(QueryMethod method, String propertyName) {
 
 		return new QueryCreationException(
-				String.format(MESSAGE_TEMPLATE, method, propertyName, method.getDomainClass().getName()), method);
+				"Could not find property '%s' on domain class '%s'".formatted(propertyName, method.getDomainClass().getName()),
+				method);
 	}
 
 	/**
@@ -92,7 +95,7 @@ public static QueryCreationException invalidProperty(QueryMethod method, String
 	 * @return the {@link QueryCreationException}.
 	 */
 	public static QueryCreationException create(QueryMethod method, String message) {
-		return new QueryCreationException(createMessage(message, method.getMethod()), method);
+		return new QueryCreationException(message, method);
 	}
 
 	/**
@@ -134,13 +137,10 @@ public static QueryCreationException create(QueryMethod method, String message,
 	 */
 	public static QueryCreationException create(@Nullable String message, @Nullable Throwable cause,
 			Class<?> repositoryInterface, Method method) {
-		return new QueryCreationException(createMessage(message, method),
+		return new QueryCreationException(message,
 				cause, repositoryInterface, method);
 	}
 
-	private static String createMessage(@Nullable String message, Method method) {
-		return String.format("Could not create query for [%s]; Reason: %s", method, message);
-	}
 
 	/**
 	 * @return the method causing the exception.
@@ -150,4 +150,19 @@ public Method getMethod() {
 		return method;
 	}
 
+	@Override
+	public String getLocalizedMessage() {
+
+		StringBuilder sb = new StringBuilder();
+		sb.append(method.getDeclaringClass().getSimpleName()).append('.');
+		sb.append(method.getName());
+
+		sb.append(method.getName());
+		sb.append(Arrays.stream(method.getParameterTypes()) //
+				.map(Type::getTypeName) //
+				.collect(Collectors.joining(",", "(", ")")));
+
+		return "Cannot create query for method [%s]; %s".formatted(sb.toString(), getMessage());
+	}
+
 }

src/test/java/org/springframework/data/repository/core/support/RepositoryFactorySupportUnitTests.java

@@ -539,7 +539,7 @@ protected Optional<QueryLookupStrategy> getQueryLookupStrategy(QueryLookupStrate
 		};
 
 		assertThatThrownBy(() -> factory.getRepository(WithQueryMethodUsingInvalidProperty.class))
-				.isInstanceOf(QueryCreationException.class).hasMessageContaining("findAllByName")
+				.isInstanceOf(QueryCreationException.class)
 				.hasMessageContaining("No property 'name' found for type 'Object'");
 	}