Remove specific verify use occurrences and replace with atLeastOnce()

Author: bamapookie

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/DefaultDbRefResolverUnitTests.java

@@ -164,15 +164,16 @@ void resolveEmptyMapIsNotNull() {
 
 		Object target = resolver.resolveReference(property, source, lookupDelegate, entityReader);
 
-		verify(property, times(3)).isMap();
-		verify(property, times(2)).isDocumentReference();
-		verify(property, times(2)).getDocumentReference();
-		verify(property, times(3)).isCollectionLike();
-		verify(documentReference, times(1)).lookup();
-		verify(documentReference, times(1)).sort();
-		verify(documentReference, times(1)).lazy();
-		verify(source, times(3)).getTargetSource();
+		verify(property, atLeastOnce()).isMap();
+		verify(property, atLeastOnce()).isDocumentReference();
+		verify(property, atLeastOnce()).getDocumentReference();
+		verify(property, atLeastOnce()).isCollectionLike();
+		verify(documentReference, atLeastOnce()).lookup();
+		verify(documentReference, atLeastOnce()).sort();
+		verify(documentReference, atLeastOnce()).lazy();
+		verify(source, atLeastOnce()).getTargetSource();
 		verifyNoMoreInteractions(documentReference, property, source); // Make sure we only call the properties we mocked.
+
 		assertThat(target)
 				.isNotNull()
 				.isInstanceOf(Map.class);
@@ -200,13 +201,13 @@ void resolveLazyLoadedEmptyMapIsNotNull() {
 
 		Object target = resolver.resolveReference(property, source, lookupDelegate, entityReader);
 
-		verify(property, times(1)).isMap();
-		verify(property, times(1)).isDocumentReference();
-		verify(property, times(1)).getDocumentReference();
-		verify(property, times(1)).isCollectionLike();
-		verify(property, times(1)).getType();
-		verify(documentReference, times(1)).lazy();
-		verify(source, times(1)).getTargetSource();
+		verify(property, atLeastOnce()).isMap();
+		verify(property, atLeastOnce()).isDocumentReference();
+		verify(property, atLeastOnce()).getDocumentReference();
+		verify(property, atLeastOnce()).isCollectionLike();
+		verify(property, atLeastOnce()).getType();
+		verify(documentReference, atLeastOnce()).lazy();
+		verify(source, atLeastOnce()).getTargetSource();
 		verifyNoMoreInteractions(documentReference, property, source); // Make sure we only call the properties we mocked.
 
 		assertThat(target)

spring-data-mongodb/src/test/java/org/springframework/data/mongodb/core/convert/ReferenceLookupDelegateUnitTests.java

@@ -111,18 +111,26 @@ void shouldResolveEmptyMapOnEmptyDocumentReferenceMapProperty() {
 		when(property.isCollectionLike()).thenReturn(false);
 		DocumentReferenceSource source = mock(DocumentReferenceSource.class);
 		when(source.getTargetSource()).thenReturn(Document.parse("{}"));
+
+		// Placeholder mock.  It should never get called.
 		ReferenceLookupDelegate.LookupFunction lookupFunction = mock(ReferenceLookupDelegate.LookupFunction.class);
 
 		Object target = lookupDelegate.readReference(property, source, lookupFunction, entityReader);
 
-		verify(lookupFunction, never()).apply(any(), any()); // Since we mocked it, make sure it is never called.
-		verify(property, times(2)).isMap();
-		verify(property, times(1)).isDocumentReference();
-		verify(property, times(1)).getDocumentReference();
-		verify(property, times(2)).isCollectionLike();
-		verify(documentReference, times(1)).lookup();
-		verify(documentReference, times(1)).sort();
-		verifyNoMoreInteractions(documentReference, property, source); // Make sure we only call the properties we mocked.
+		// Since we mocked a placeholder that should never be called, make sure it is never called.
+		verify(lookupFunction, never()).apply(any(), any());
+
+		// Verify that all the mocks we created are used.
+		verify(property, atLeastOnce()).isMap();
+		verify(property, atLeastOnce()).isDocumentReference();
+		verify(property, atLeastOnce()).getDocumentReference();
+		verify(property, atLeastOnce()).isCollectionLike();
+		verify(documentReference, atLeastOnce()).lookup();
+		verify(documentReference, atLeastOnce()).sort();
+
+		// Make sure we only call the properties we mocked.
+		verifyNoMoreInteractions(documentReference, property, source);
+
 		assertThat(target)
 				.isNotNull()
 				.isInstanceOf(Map.class);