Remove unnecessary throws Exception from spring-security-config

Closes gh-17957

Author: rwinch

config/src/main/java/org/springframework/security/config/annotation/AbstractConfiguredSecurityBuilder.java

@@ -96,10 +96,10 @@ protected AbstractConfiguredSecurityBuilder(ObjectPostProcessor<Object> objectPo
 	}
 
 	/**
-	 * Similar to {@link #build()} and {@link #getObject()} but checks the state to
-	 * determine if {@link #build()} needs to be called first.
-	 * @return the result of {@link #build()} or {@link #getObject()}. If an error occurs
-	 * while building, returns null.
+	 * Similar to {@link SecurityBuilder#build()} and {@link #getObject()} but checks the
+	 * state to determine if {@link SecurityBuilder#build()} needs to be called first.
+	 * @return the result of {@link SecurityBuilder#build()} or {@link #getObject()}. If
+	 * an error occurs while building, returns null.
 	 */
 	public O getOrBuild() {
 		if (!isUnbuilt()) {
@@ -122,7 +122,7 @@ public O getOrBuild() {
 	 * @return the {@link SecurityConfigurerAdapter} for further customizations
 	 * @throws Exception
 	 */
-	public <C extends SecurityConfigurer<O, B>> C apply(C configurer) throws Exception {
+	public <C extends SecurityConfigurer<O, B>> C apply(C configurer) {
 		add(configurer);
 		return configurer;
 	}
@@ -145,7 +145,7 @@ public <C extends SecurityConfigurer<O, B>> C apply(C configurer) throws Excepti
 	 * @throws Exception
 	 * @since 7.0
 	 */
-	public <C extends SecurityConfigurerAdapter<O, B>> B with(C configurer) throws Exception {
+	public <C extends SecurityConfigurerAdapter<O, B>> B with(C configurer) {
 		return with(configurer, Customizer.withDefaults());
 	}
 
@@ -158,7 +158,7 @@ public <C extends SecurityConfigurerAdapter<O, B>> B with(C configurer) throws E
 	 * @since 6.2
 	 */
 	@SuppressWarnings("unchecked")
-	public <C extends SecurityConfigurerAdapter<O, B>> B with(C configurer, Customizer<C> customizer) throws Exception {
+	public <C extends SecurityConfigurerAdapter<O, B>> B with(C configurer, Customizer<C> customizer) {
 		configurer.addObjectPostProcessor(this.objectPostProcessor);
 		configurer.setBuilder((B) this);
 		add(configurer);
@@ -326,7 +326,7 @@ protected <P> P postProcess(P object) {
 	 * </ul>
 	 */
 	@Override
-	protected final O doBuild() throws Exception {
+	protected final O doBuild() {
 		synchronized (this.configurers) {
 			this.buildState = BuildState.INITIALIZING;
 			beforeInit();
@@ -346,7 +346,7 @@ protected final O doBuild() throws Exception {
 	 * method. Subclasses may override this method to hook into the lifecycle without
 	 * using a {@link SecurityConfigurer}.
 	 */
-	protected void beforeInit() throws Exception {
+	protected void beforeInit() {
 	}
 
 	/**
@@ -355,17 +355,17 @@ protected void beforeInit() throws Exception {
 	 * override this method to hook into the lifecycle without using a
 	 * {@link SecurityConfigurer}.
 	 */
-	protected void beforeConfigure() throws Exception {
+	protected void beforeConfigure() {
 	}
 
 	/**
 	 * Subclasses must implement this method to build the object that is being returned.
 	 * @return the Object to be buit or null if the implementation allows it
 	 */
-	protected abstract O performBuild() throws Exception;
+	protected abstract O performBuild();
 
 	@SuppressWarnings("unchecked")
-	private void init() throws Exception {
+	private void init() {
 		Collection<SecurityConfigurer<O, B>> configurers = getConfigurers();
 		for (SecurityConfigurer<O, B> configurer : configurers) {
 			configurer.init((B) this);
@@ -380,7 +380,7 @@ private void init() throws Exception {
 	}
 
 	@SuppressWarnings("unchecked")
-	private void configure() throws Exception {
+	private void configure() {
 		Collection<SecurityConfigurer<O, B>> configurers = getConfigurers();
 		for (SecurityConfigurer<O, B> configurer : configurers) {
 			configurer.configure((B) this);

config/src/main/java/org/springframework/security/config/annotation/AbstractSecurityBuilder.java

@@ -33,7 +33,7 @@ public abstract class AbstractSecurityBuilder<O> implements SecurityBuilder<O> {
 	private O object;
 
 	@Override
-	public final O build() throws Exception {
+	public final O build() {
 		if (this.building.compareAndSet(false, true)) {
 			this.object = doBuild();
 			return this.object;
@@ -55,9 +55,9 @@ public final O getObject() {
 
 	/**
 	 * Subclasses should implement this to perform the build.
-	 * @return the object that should be returned by {@link #build()}.
+	 * @return the object that should be returned by {@link SecurityBuilder#build()}.
 	 * @throws Exception if an error occurs
 	 */
-	protected abstract O doBuild() throws Exception;
+	protected abstract O doBuild();
 
 }

config/src/main/java/org/springframework/security/config/annotation/AlreadyBuiltException.java

@@ -17,7 +17,7 @@
 package org.springframework.security.config.annotation;
 
 /**
- * Thrown when {@link AbstractSecurityBuilder#build()} is two or more times.
+ * Thrown when {@link SecurityBuilder#build()} is two or more times.
  *
  * @author Rob Winch
  * @since 3.2

config/src/main/java/org/springframework/security/config/annotation/SecurityBuilder.java

@@ -30,6 +30,6 @@ public interface SecurityBuilder<O> {
 	 * @return the Object to be built or null if the implementation allows it.
 	 * @throws Exception if an error occurred when building the Object
 	 */
-	O build() throws Exception;
+	O build();
 
 }

config/src/main/java/org/springframework/security/config/annotation/SecurityConfigurer.java

@@ -38,14 +38,14 @@ public interface SecurityConfigurer<O, B extends SecurityBuilder<O>> {
 	 * @param builder
 	 * @throws Exception
 	 */
-	void init(B builder) throws Exception;
+	void init(B builder);
 
 	/**
 	 * Configure the {@link SecurityBuilder} by setting the necessary properties on the
 	 * {@link SecurityBuilder}.
 	 * @param builder
 	 * @throws Exception
 	 */
-	void configure(B builder) throws Exception;
+	void configure(B builder);
 
 }

config/src/main/java/org/springframework/security/config/annotation/SecurityConfigurerAdapter.java

@@ -44,11 +44,11 @@ public abstract class SecurityConfigurerAdapter<O, B extends SecurityBuilder<O>>
 	private CompositeObjectPostProcessor objectPostProcessor = new CompositeObjectPostProcessor();
 
 	@Override
-	public void init(B builder) throws Exception {
+	public void init(B builder) {
 	}
 
 	@Override
-	public void configure(B builder) throws Exception {
+	public void configure(B builder) {
 	}
 
 	/**

config/src/main/java/org/springframework/security/config/annotation/authentication/builders/AuthenticationManagerBuilder.java

@@ -127,8 +127,7 @@ public AuthenticationManagerBuilder eraseCredentials(boolean eraseCredentials) {
 	 * the in memory authentication
 	 * @throws Exception if an error occurs when adding the in memory authentication
 	 */
-	public InMemoryUserDetailsManagerConfigurer<AuthenticationManagerBuilder> inMemoryAuthentication()
-			throws Exception {
+	public InMemoryUserDetailsManagerConfigurer<AuthenticationManagerBuilder> inMemoryAuthentication() {
 		return apply(new InMemoryUserDetailsManagerConfigurer<>());
 	}
 
@@ -156,7 +155,7 @@ public InMemoryUserDetailsManagerConfigurer<AuthenticationManagerBuilder> inMemo
 	 * JDBC authentication
 	 * @throws Exception if an error occurs when adding the JDBC authentication
 	 */
-	public JdbcUserDetailsManagerConfigurer<AuthenticationManagerBuilder> jdbcAuthentication() throws Exception {
+	public JdbcUserDetailsManagerConfigurer<AuthenticationManagerBuilder> jdbcAuthentication() {
 		return apply(new JdbcUserDetailsManagerConfigurer<>());
 	}
 
@@ -177,7 +176,7 @@ public JdbcUserDetailsManagerConfigurer<AuthenticationManagerBuilder> jdbcAuthen
 	 * based authentication
 	 */
 	public <T extends UserDetailsService> DaoAuthenticationConfigurer<AuthenticationManagerBuilder, T> userDetailsService(
-			T userDetailsService) throws Exception {
+			T userDetailsService) {
 		this.defaultUserDetailsService = userDetailsService;
 		return apply(new DaoAuthenticationConfigurer<>(userDetailsService));
 	}
@@ -222,7 +221,7 @@ public AuthenticationManagerBuilder authenticationProvider(AuthenticationProvide
 	}
 
 	@Override
-	protected ProviderManager performBuild() throws Exception {
+	protected ProviderManager performBuild() {
 		if (!isConfigured()) {
 			this.logger.debug("No authenticationProviders and no parentAuthenticationManager defined. Returning null.");
 			return null;
@@ -277,7 +276,7 @@ public UserDetailsService getDefaultUserDetailsService() {
 	 * @throws Exception if an error occurs
 	 */
 	private <C extends UserDetailsAwareConfigurer<AuthenticationManagerBuilder, ? extends UserDetailsService>> C apply(
-			C configurer) throws Exception {
+			C configurer) {
 		this.defaultUserDetailsService = configurer.getUserDetailsService();
 		with(configurer);
 		return configurer;

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java

@@ -107,7 +107,7 @@ public static InitializeAuthenticationProviderBeanManagerConfigurer initializeAu
 		return new InitializeAuthenticationProviderBeanManagerConfigurer(context);
 	}
 
-	public AuthenticationManager getAuthenticationManager() throws Exception {
+	public AuthenticationManager getAuthenticationManager() {
 		if (this.authenticationManagerInitialized) {
 			return this.authenticationManager;
 		}
@@ -274,19 +274,18 @@ static class DefaultPasswordEncoderAuthenticationManagerBuilder extends Authenti
 		}
 
 		@Override
-		public InMemoryUserDetailsManagerConfigurer<AuthenticationManagerBuilder> inMemoryAuthentication()
-				throws Exception {
+		public InMemoryUserDetailsManagerConfigurer<AuthenticationManagerBuilder> inMemoryAuthentication() {
 			return super.inMemoryAuthentication().passwordEncoder(this.defaultPasswordEncoder);
 		}
 
 		@Override
-		public JdbcUserDetailsManagerConfigurer<AuthenticationManagerBuilder> jdbcAuthentication() throws Exception {
+		public JdbcUserDetailsManagerConfigurer<AuthenticationManagerBuilder> jdbcAuthentication() {
 			return super.jdbcAuthentication().passwordEncoder(this.defaultPasswordEncoder);
 		}
 
 		@Override
 		public <T extends UserDetailsService> DaoAuthenticationConfigurer<AuthenticationManagerBuilder, T> userDetailsService(
-				T userDetailsService) throws Exception {
+				T userDetailsService) {
 			return super.userDetailsService(userDetailsService).passwordEncoder(this.defaultPasswordEncoder);
 		}
 

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/GlobalAuthenticationConfigurerAdapter.java

@@ -35,11 +35,11 @@ public abstract class GlobalAuthenticationConfigurerAdapter
 		implements SecurityConfigurer<AuthenticationManager, AuthenticationManagerBuilder> {
 
 	@Override
-	public void init(AuthenticationManagerBuilder auth) throws Exception {
+	public void init(AuthenticationManagerBuilder auth) {
 	}
 
 	@Override
-	public void configure(AuthenticationManagerBuilder auth) throws Exception {
+	public void configure(AuthenticationManagerBuilder auth) {
 	}
 
 }

config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java

@@ -49,7 +49,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer extends GlobalAuthen
 	}
 
 	@Override
-	public void init(AuthenticationManagerBuilder auth) throws Exception {
+	public void init(AuthenticationManagerBuilder auth) {
 		auth.apply(new InitializeAuthenticationProviderManagerConfigurer());
 	}