Make qualifiedName type private to parse package

Signed-off-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com>

Author: agarciamontoro

sql/parse/util.go

@@ -517,18 +517,18 @@ func maybeList(opening, separator, closing rune, list *[]string) parseFunc {
 	}
 }
 
-// A QualifiedName represents an identifier of type "db_name.table_name"
-type QualifiedName struct {
+// A qualifiedName represents an identifier of type "db_name.table_name"
+type qualifiedName struct {
 	qualifier string
 	name      string
 }
 
-// readQualifiedIdentifierList reads a comma-separated list of QualifiedNames.
+// readQualifiedIdentifierList reads a comma-separated list of qualifiedNames.
 // Any number of spaces between the qualified names are accepted. The qualifier
 // may be empty, in which case the period is optional.
 // An example of a correctly formed list is:
 // "my_db.myview, db_2.mytable ,   aTable"
-func readQualifiedIdentifierList(list *[]QualifiedName) parseFunc {
+func readQualifiedIdentifierList(list *[]qualifiedName) parseFunc {
 	return func(rd *bufio.Reader) error {
 		for {
 			var newItem []string
@@ -559,7 +559,7 @@ func readQualifiedIdentifierList(list *[]QualifiedName) parseFunc {
 				name = newItem[1]
 			}
 
-			*list = append(*list, QualifiedName{qualifier, name})
+			*list = append(*list, qualifiedName{qualifier, name})
 
 			r, _, err := rd.ReadRune()
 			if err != nil {

sql/parse/util_test.go

@@ -474,19 +474,19 @@ func TestReadQualifiedIdentifierList(t *testing.T) {
 
 	testFixtures := []struct {
 		string            string
-		expectedList      []QualifiedName
+		expectedList      []qualifiedName
 		expectedError     bool
 		expectedRemaining string
 	}{
 		{
 			"my_db.myview, db_2.mytable ,   aTable",
-			[]QualifiedName{{"my_db", "myview"}, {"db_2", "mytable"}, {"", "aTable"}},
+			[]qualifiedName{{"my_db", "myview"}, {"db_2", "mytable"}, {"", "aTable"}},
 			false,
 			"",
 		},
 		{
 			"single_identifier -remaining",
-			[]QualifiedName{{"", "single_identifier"}},
+			[]qualifiedName{{"", "single_identifier"}},
 			false,
 			"-remaining",
 		},
@@ -498,15 +498,15 @@ func TestReadQualifiedIdentifierList(t *testing.T) {
 		},
 		{
 			"partial_list,",
-			[]QualifiedName{{"", "partial_list"}},
+			[]qualifiedName{{"", "partial_list"}},
 			true,
 			"",
 		},
 	}
 
 	for _, fixture := range testFixtures {
 		reader := bufio.NewReader(strings.NewReader(fixture.string))
-		var actualList []QualifiedName
+		var actualList []qualifiedName
 
 		err := readQualifiedIdentifierList(&actualList)(reader)
 

sql/parse/views.go

@@ -98,7 +98,7 @@ func parseDropView(ctx *sql.Context, s string) (sql.Node, error) {
 	r := bufio.NewReader(strings.NewReader(s))
 
 	var (
-		views      []QualifiedName
+		views      []qualifiedName
 		ifExists   bool
 		unusedBool bool
 	)